Skip to content

Commit 48cb7ab

Browse files
committed
Loosen puma and rspec-rails version constraints in solidus_dev_support
Goal ---- As a solidus_starter_frontend user I would like solidus_dev_support to support `puma ~> 5.0` And I would like solidus_dev_support to support `rspec-rails ~> 5.0` So that if solidus_starter_frontend is installed with specs on a Rails app with those versions of the gems, solidus_starter_frontend won't have to revert the gems to older version in order to support solidus_dev_support. Background ---------- In https://github.com/nebulab/solidus_starter_frontend/pull/175/files#r690067361, `SolidusStarterFrontend::RspecGenerator#install` has to revert the puma version of a Rails 6.1.4 app to 4.x. Otherwise, it won't be able to install solidus_dev_support. Rails 6.1.4 sets puma to `'~> 5.0'`. In solidusio/solidus_starter_frontend#180, the generator also has to revert rspec-rails to `~> 4.0.0.beta3` in order to install solidus_dev_support.
1 parent ead6752 commit 48cb7ab

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

solidus_dev_support.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ Gem::Specification.new do |spec|
3737
spec.add_dependency 'ffaker', '~> 2.13'
3838
spec.add_dependency 'gem-release', '~> 2.1'
3939
spec.add_dependency 'github_changelog_generator', '~> 1.15'
40-
spec.add_dependency 'puma', '~> 4.3'
40+
spec.add_dependency 'puma', '>= 4.3', '< 6.0'
4141
spec.add_dependency 'rspec_junit_formatter'
42-
spec.add_dependency 'rspec-rails', '~> 4.0.0.beta3'
42+
spec.add_dependency 'rspec-rails', '>= 4.0.0.beta3', '< 6.0'
4343
spec.add_dependency 'rubocop', '~> 1.0'
4444
spec.add_dependency 'rubocop-performance', '~> 1.5'
4545
spec.add_dependency 'rubocop-rails', '~> 2.3'

0 commit comments

Comments
 (0)