Commit 48cb7ab
committed
Loosen puma and rspec-rails version constraints in solidus_dev_support
Goal
----
As a solidus_starter_frontend user
I would like solidus_dev_support to support `puma ~> 5.0`
And I would like solidus_dev_support to support `rspec-rails ~> 5.0`
So that if solidus_starter_frontend is installed with specs on a Rails app with
those versions of the gems, solidus_starter_frontend won't have to revert the
gems to older version in order to support solidus_dev_support.
Background
----------
In
https://github.com/nebulab/solidus_starter_frontend/pull/175/files#r690067361,
`SolidusStarterFrontend::RspecGenerator#install` has to revert the puma version
of a Rails 6.1.4 app to 4.x. Otherwise, it won't be able to install
solidus_dev_support. Rails 6.1.4 sets puma to `'~> 5.0'`.
In solidusio/solidus_starter_frontend#180, the generator
also has to revert rspec-rails to `~> 4.0.0.beta3` in order to install
solidus_dev_support.1 parent ead6752 commit 48cb7ab
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments