Generate legacy paths with helpers

Co-Authored-By: Elia Schito <elia@schito.me>

Author: cpfergus1

config/routes.rb

@@ -16,23 +16,39 @@
     resources :users, only: [:edit, :update]
 
     devise_scope :spree_user do
-      # Legacy devise generated routes
-      get 'user/spree_user/sign_in', to: 'user_sessions#new', as: :new_spree_user_session
-      post 'user/spree_user/sign_in', to: 'user_sessions#create', as: :spree_user_session
-      match 'user/spree_user/logout', to: 'user_sessions#destroy', as: :destroy_spree_user_session, via: Devise.sign_out_via
-      get 'user/spree_user/password/new', to: 'user_passwords#new', as: :new_spree_user_password
-      get 'user/spree_user/password/edit', to: 'user_passwords#edit', as: :edit_spree_user_password
-      patch 'user/spree_user/password', to: 'user_passwords#update', as: :spree_user_password
-      put 'user/spree_user/password', to: 'user_passwords#update'
-      post 'user/spree_user/password', to: 'user_passwords#create'
-      get 'user/spree_user/cancel', to: 'user_registrations#cancel', as: :cancel_spree_user_registration
-      get 'user/spree_user/sign_up', to: 'user_registrations#new', as: :new_spree_user_registration
-      get 'user/spree_user/edit', to: 'user_registrations#edit', as: :edit_spree_user_registration
-      patch 'user/spree_user', to: 'user_registrations#update', as: :spree_user_registration
+      # Legacy devise generated paths
+      # These are deprecated but we still want to support the incoming routes,
+      # in order to give existing stores an upgrade path.
+      get 'user/spree_user/sign_in', to: 'user_sessions#new', as: nil
+      post 'user/spree_user/sign_in', to: 'user_sessions#create', as: nil
+      match 'user/spree_user/logout', to: 'user_sessions#destroy', via: Devise.sign_out_via, as: nil
+      get 'user/spree_user/password/new', to: 'user_passwords#new', as: nil
+      get 'user/spree_user/password/edit', to: 'user_passwords#edit', as: nil
+      patch 'user/spree_user/password', to: 'user_passwords#update', as: nil
+      put 'user/spree_user/password', to: 'user_passwords#update', as: nil
+      post 'user/spree_user/password', to: 'user_passwords#create', as: nil
+      get 'user/spree_user/cancel', to: 'user_registrations#cancel', as: nil
+      get 'user/spree_user/sign_up', to: 'user_registrations#new', as: nil
+      get 'user/spree_user/edit', to: 'user_registrations#edit', as: nil
+      patch 'user/spree_user', to: 'user_registrations#update', as: nil
       put 'user/spree_user', to: 'user_registrations#update', as: nil
       delete 'user/spree_user', to: 'user_registrations#destroy', as: nil
       post 'user/spree_user', to: 'user_registrations#create', as: nil
 
+      # Legacy devise generated helpers
+      # These helpers are deprecated but we still want to support them
+      # in order to give existing stores an upgrade path.
+      get '/login', to: 'user_sessions#new', as: :new_spree_user_session
+      post '/login', to: 'user_sessions#create', as: :spree_user_session
+      match '/logout', to: 'user_sessions#destroy', as: :destroy_spree_user_session, via: Devise.sign_out_via
+      get '/password/recover', to: 'user_passwords#new', as: :new_spree_user_password
+      get '/password/change', to: 'user_passwords#edit', as: :edit_spree_user_password
+      patch '/password/change', to: 'user_passwords#update', as: :spree_user_password
+      get '/spree_user/cancel', to: 'user_registrations#cancel', as: :cancel_spree_user_registration
+      get '/signup', to: 'user_registrations#new', as: :new_spree_user_registration
+      get '/spree_user/edit', to: 'user_registrations#edit', as: :edit_spree_user_registration
+      patch '/spree_user', to: 'user_registrations#update', as: :spree_user_registration
+
       # Custom devise routes
       get '/login', to: 'user_sessions#new', as: :login
       post '/login', to: 'user_sessions#create', as: :create_new_session

spec/controllers/spree/user_passwords_controller_spec.rb

@@ -10,7 +10,7 @@
       it 'redirects to the new session path' do
         get :edit
         expect(response).to redirect_to(
-          'http://test.host/user/spree_user/sign_in'
+          'http://test.host/login'
         )
       end
 

spec/features/checkout_spec.rb

@@ -111,7 +111,7 @@
       # Need to do this now because the token stored in the DB is the encrypted version
       # The 'plain-text' version is sent in the email and there's one way to get that!
       reset_password_email = ActionMailer::Base.deliveries.first
-      token_url_regex = /\/user\/spree_user\/password\/edit\?reset_password_token=(.*)$/
+      token_url_regex = /\/password\/change\?reset_password_token=(.*)$/
       token = token_url_regex.match(reset_password_email.body.to_s)[1]
 
       visit spree.edit_spree_user_password_path(reset_password_token: token)

spec/mailers/user_mailer_spec.rb

@@ -31,7 +31,7 @@
 
       context 'body includes' do
         it 'password reset url' do
-          expect(@message.body.raw_source).to include "http://#{store.url}/user/spree_user/password/edit"
+          expect(@message.body.raw_source).to include "http://#{store.url}/password/change"
         end
       end
     end