Commit 5bcf4c8
committed
Remove Slack notifications for CI failures
We were storing the Slack secrets on a CircleCI context [1]. Although we
were also passing them to forks [2], it resulted on unauthorized builds
for external contributions.
We could work around the issue in two ways:
- Having the secrets outside of any context, but that would compromise
the security of the associated Slack channel for:
- Send messages as @circleci notifications
- Send messages to channels @circleci notifications isn't a member of
- Upload, edit, and delete files as CircleCI notifications
- Using CircleCI logic statements [3] to conditionally run jobs when
`CIRCLECI_USERNAME` or `CIRCLE_PR_USERNAME` env vars [4] are in a list
of allowed users. However, that would be something difficult to
maintain, and there's no other way to check the user's role.
Given that we don't find those trade-offs to be acceptable, we remove
the integration for now.
[1] - https://circleci.com/docs/contexts/
[2] - https://circleci.com/docs/oss/#pass-secrets-to-builds-from-forked-pull-requests
[3] - https://circleci.com/docs/configuration-reference/#logic-statements
[4] - https://circleci.com/docs/variables/1 parent 6385cf6 commit 5bcf4c8
1 file changed
Lines changed: 7 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | 13 | | |
24 | 14 | | |
25 | 15 | | |
| |||
30 | 20 | | |
31 | 21 | | |
32 | 22 | | |
33 | | - | |
34 | 23 | | |
35 | 24 | | |
36 | 25 | | |
| |||
41 | 30 | | |
42 | 31 | | |
43 | 32 | | |
44 | | - | |
45 | 33 | | |
46 | 34 | | |
47 | 35 | | |
| |||
52 | 40 | | |
53 | 41 | | |
54 | 42 | | |
55 | | - | |
56 | 43 | | |
57 | 44 | | |
58 | 45 | | |
59 | 46 | | |
60 | 47 | | |
61 | | - | |
62 | 48 | | |
63 | 49 | | |
64 | 50 | | |
65 | 51 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
74 | 56 | | |
75 | 57 | | |
76 | 58 | | |
| |||
81 | 63 | | |
82 | 64 | | |
83 | 65 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
0 commit comments