test: Harden feature specs

We need to wait for the page to load before clicking
links or making assumptions about its content.

Author: tvdeyen

spec/features/account_spec.rb

@@ -9,6 +9,7 @@
       fill_in "Email", with: user.email
       fill_in "Password", with: user.password
       click_button "Login"
+      expect(page).to have_text "Logged in successfully"
 
       click_link "My Account"
       expect(page).to have_text "admin@person.com"
@@ -22,6 +23,7 @@
       fill_in "Password", with: "password"
       fill_in "Password Confirmation", with: "password"
       click_button "Create"
+      expect(page).to have_text "You have signed up successfully"
 
       click_link "My Account"
       expect(page).to have_text "email@person.com"
@@ -43,6 +45,7 @@
       fill_in "Email", with: user.email
       fill_in "Password", with: user.password
       click_button "Login"
+      expect(page).to have_text "Logged in successfully"
 
       click_link "My Account"
       expect(page).to have_text "email@person.com"

spec/features/admin/sign_out_spec.rb

@@ -12,6 +12,7 @@
     # Regression test for #1257
     check "Remember me"
     click_button "Login"
+    expect(page).to have_text "Logged in successfully"
   end
 
   scenario "allows a signed in user to logout" do

spec/features/admin_permissions_spec.rb

@@ -10,6 +10,7 @@
       fill_in "Email", with: user.email
       fill_in "Password", with: user.password
       click_button "Login"
+      expect(page).to have_text "Logged in successfully"
     end
 
     context "admin is restricted from accessing orders" do

spec/features/change_email_spec.rb

@@ -11,6 +11,7 @@
     fill_in "spree_user[email]", with: user.email
     fill_in "spree_user[password]", with: "secret"
     click_button "Login"
+    expect(page).to have_text "Logged in successfully"
 
     visit spree.edit_account_path
   end

spec/features/checkout_spec.rb

@@ -79,11 +79,13 @@
       user = create(:user, email: "email@person.com", password: "password", password_confirmation: "password")
       click_link "RoR Mug"
       click_button "Add To Cart"
+      within("h1") { expect(page).to have_text "Shopping Cart" }
 
       click_link "Login"
       fill_in "Email", with: user.email
       fill_in "Password", with: user.password
       click_button "Login"
+      expect(page).to have_text "Logged in successfully"
       click_link "Cart"
 
       expect(page).to have_text "RoR Mug"
@@ -112,6 +114,7 @@
       create(:user, email: "email@person.com", password: "password", password_confirmation: "password")
       click_link "RoR Mug"
       click_button "Add To Cart"
+      within("h1") { expect(page).to have_text "Shopping Cart" }
 
       click_link "Login"
       click_link "Forgot Password?"
@@ -142,6 +145,7 @@
     scenario "allow a user to register during checkout" do
       click_link "RoR Mug"
       click_button "Add To Cart"
+      within("h1") { expect(page).to have_text "Shopping Cart" }
       click_button "Checkout"
 
       expect(page).to have_text "Registration"

spec/features/order_spec.rb

@@ -40,6 +40,7 @@
       fill_in "Email", with: user.email
       fill_in "Password", with: user.password
       click_button "Login"
+      expect(page).to have_text "Logged in successfully"
 
       # Order should have been merged with first session
       click_link "Cart"

spec/features/sign_in_spec.rb

@@ -48,6 +48,7 @@
     fill_in "Email", with: @user.email
     fill_in "Password", with: @user.password
     click_button "Login"
+    expect(page).to have_text "Logged in successfully"
     expect(current_path).to eq "/account"
   end
 end

spec/features/sign_out_spec.rb

@@ -15,6 +15,7 @@
     # Regression test for #1257
     check "Remember me"
     click_button "Login"
+    expect(page).to have_text "Logged in successfully"
   end
 
   scenario "allow a signed in user to logout" do

spec/support/features/fill_addresses_fields.rb

@@ -14,6 +14,8 @@ def fill_addresses_fields_with(address)
       %w[firstname lastname]
     end
 
+    expect(page).to have_text "Billing Address"
+
     fields.each do |field|
       fill_in "order_bill_address_attributes_#{field}", with: address.send(field).to_s
     end