contacts: add contact to group failing e2e test and module interface

Author: angelo-v

contacts/src/e2e-tests/contacts.e2e.spec.ts

@@ -150,6 +150,29 @@ describe("contacts module", () => {
       });
     }
   });
+
+  it("can add an existing contact to an existing group", async () => {
+    const contacts = setupModule();
+
+    const groupUri =
+      "http://localhost:3456/4243dbb6-3126-4bf9-9ea7-45e35c3c8d9d/Group/88f4eb67-f510-49c8-8d52-9080cd3e489f/index.ttl#this";
+
+    const contactUri =
+      "http://localhost:3456/4243dbb6-3126-4bf9-9ea7-45e35c3c8d9d/Person/1973dcec-e71c-476c-87db-0d3332291214/index.ttl#this";
+
+    const groupBefore = await contacts.readGroup(groupUri);
+    expect(
+      groupBefore.members.some((contact) => contact.uri == contactUri),
+    ).toBe(false);
+
+    await contacts.addContactToGroup({ contactUri, groupUri });
+
+    const groupAfter = await contacts.readGroup(groupUri);
+    expect(groupAfter.members).toContainEqual({
+      uri: "http://localhost:3456/4243dbb6-3126-4bf9-9ea7-45e35c3c8d9d/Person/1973dcec-e71c-476c-87db-0d3332291214/index.ttl#this",
+      name: "Molly Braaten",
+    });
+  });
 });
 
 function setupModule() {

contacts/src/index.ts

@@ -51,6 +51,12 @@ export interface ContactsModule {
    * @return FullGroup name and list of group members
    */
   readGroup(uri: string): Promise<FullGroup>;
+
+  /**
+   * Adds an existing contact to an existing group
+   * @param command
+   */
+  addContactToGroup(command: AddContactToGroupCommand): Promise<void>;
 }
 
 /**
@@ -185,3 +191,17 @@ export interface CreateNewGroupCommand {
    */
   groupName: string;
 }
+
+/**
+ * Data needed to add an existing contact to an existing group
+ */
+export interface AddContactToGroupCommand {
+  /**
+   * The URI of an existing group, to that the contact should be added
+   */
+  contactUri: string;
+  /**
+   * The URI of an existing contact, that should be added to the group
+   */
+  groupUri: string;
+}

contacts/src/rdflib/ContactsModuleRdfLib.ts

@@ -1,5 +1,6 @@
 import { Fetcher, IndexedFormula, Node, sym, UpdateManager } from "rdflib";
 import {
+  AddContactToGroupCommand,
   AddressBook,
   ContactsModule,
   CreateAddressBookCommand,
@@ -114,4 +115,6 @@ export class ContactsModuleRdfLib implements ContactsModule {
       members,
     };
   }
+
+  async addContactToGroup({ contactUri, groupUri }: AddContactToGroupCommand) {}
 }