Cleaned up comments, reorganized code slightly.

Author: caoimghgin

TableViewCellWithAutoLayout/TableViewController/RJTableViewCell.m

@@ -10,7 +10,6 @@
 
 @interface RJTableViewCell ()
 
-// We'll set this to YES once this instance of the cell has setup its constraints, so that any additional calls to updateConstraints are no-ops
 @property (nonatomic, assign) BOOL hasSetupConstraints;
 
 @end
@@ -31,33 +30,17 @@ - (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reus
         [self.titleLabel setFont: [UIFont fontWithName:@"Helvetica-Bold" size:21]];
         [self.titleLabel setTextColor:[UIColor blackColor]];
         [self.titleLabel setBackgroundColor:[UIColor clearColor]];
-//        [self.titleLabel setContentCompressionResistancePriority:UILayoutPriorityDefaultHigh forAxis:UILayoutConstraintAxisVertical];
-//        [self.titleLabel setContentHuggingPriority:UILayoutPriorityDefaultHigh forAxis:UILayoutConstraintAxisVertical];
-
+        
         self.bodyLabel = [[UILabel alloc] initWithFrame:CGRectZero];
         [self.bodyLabel setTranslatesAutoresizingMaskIntoConstraints:NO];
+        [self.bodyLabel setContentCompressionResistancePriority:UILayoutPriorityRequired forAxis:UILayoutConstraintAxisVertical];
         [self.bodyLabel setLineBreakMode:NSLineBreakByTruncatingTail];
-        
-        // You don't want the below line; let the font size for the multi-line body label remain fixed.
-//        [self.titleLabel setAdjustsFontSizeToFitWidth:YES];
-        
         [self.bodyLabel setNumberOfLines:0];
         [self.bodyLabel setTextAlignment:NSTextAlignmentLeft];
         [self.bodyLabel setFont: [UIFont fontWithName:@"Helvetica" size:14]];
         [self.bodyLabel setTextColor:[UIColor darkGrayColor]];
         [self.bodyLabel setBackgroundColor:[UIColor clearColor]];
-        
-        // If you don't do this, the auto layout solver engine may calculate a ever-so-slightly smaller height than actually required
-        // (probably due to rounding errors internally) which will cause the bodyLabel to truncate the last line. This will force
-        // the bodyLabel to always get the size it needs for all the lines. (The titleLabel height will be reduced ever so slightly
-        // in this case if needed to satisfy this constraint, but in this case it shouldn't be noticeable.)
-        // Another way to solve this is to return a slightly larger cell height (add 1 point) than the auto layout calculations return.
-        // Or a third way is to build in a few points of padding (perhaps between the labels, or above or below them) which has a priority of
-        // UILayoutPriorityDefaultHigh - 1, so that it will be the first thing to be reduced if the cell height is a tiny bit too small -
-        // it will act as a buffer to prevent the labels from getting smaller than the size they really want.
-        [self.bodyLabel setContentCompressionResistancePriority:UILayoutPriorityRequired forAxis:UILayoutConstraintAxisVertical];
 
-        // Add your subviews right away during init - no reason to wait until later
         [self.contentView addSubview:self.titleLabel];
         [self.contentView addSubview:self.bodyLabel];
     }
@@ -68,8 +51,6 @@ - (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reus
 - (void)updateConstraints {
     [super updateConstraints];
 
-    // Modified to a single-line return. No biggie.
-    //
     if (self.hasSetupConstraints) return;
 
     [self.contentView addConstraint:[NSLayoutConstraint
@@ -99,31 +80,7 @@ - (void)updateConstraints {
                                      multiplier:1.0f
                                      constant:-kLabelHorizontalInsets]];
 
-    // You don't need the below constraint - the auto-generated content compression resistance constraints on UILabel are sufficient!
-//    [self.contentView  addConstraint:[NSLayoutConstraint
-//                                      constraintWithItem:self.titleLabel
-//                                      attribute:NSLayoutAttributeHeight
-//                                      relatedBy:NSLayoutRelationGreaterThanOrEqual
-//                                      toItem:nil
-//                                      attribute:NSLayoutAttributeNotAnAttribute
-//                                      multiplier:1.0f
-//                                      constant:22.0f]];
-    
-    // "You don't need the below constraint - the auto-generated content compression resistance constraints on UILabel are sufficient!"
-    //
-    // OK, this is weird. Without NSLayoutAttributeHeight-NSLayoutRelationGreaterThanOrEqual self.titleLabel collapses?
-    // Adding the NSLayoutAttributeHeight-NSLayoutRelationGreaterThanOrEqual resolves issue. Perhaps there is another way...
-    // ...
-    [self.contentView  addConstraint:[NSLayoutConstraint
-                                      constraintWithItem:self.titleLabel
-                                      attribute:NSLayoutAttributeHeight
-                                      relatedBy:NSLayoutRelationGreaterThanOrEqual
-                                      toItem:nil
-                                      attribute:NSLayoutAttributeNotAnAttribute
-                                      multiplier:1.0f
-                                      constant:22.0f]];
-    
-    ///////////////////////////////////////////////////////////////////////////////////////////
+    //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
     [self.contentView  addConstraint:[NSLayoutConstraint
                                       constraintWithItem:self.bodyLabel
@@ -161,16 +118,6 @@ - (void)updateConstraints {
                                       multiplier:1.0f
                                       constant:-(kLabelHorizontalInsets / 2)]];
 
-    // You don't need the below constraint - the auto-generated content compression resistance constraints on UILabel are sufficient!
-//    [self.contentView  addConstraint:[NSLayoutConstraint
-//                                      constraintWithItem:self.bodyLabel
-//                                      attribute:NSLayoutAttributeHeight
-//                                      relatedBy:NSLayoutRelationGreaterThanOrEqual
-//                                      toItem:nil
-//                                      attribute:NSLayoutAttributeNotAnAttribute
-//                                      multiplier:1.0f
-//                                      constant:22.0f]];
-    
     self.hasSetupConstraints = YES;
 
 }

TableViewCellWithAutoLayout/TableViewController/RJTableViewController.m

@@ -67,17 +67,14 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
 {
 
     RJTableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier forIndexPath:indexPath];
- 
-    NSDictionary *dataSourceItem = [self.model.dataSource objectAtIndex:indexPath.row];
 
     // Configure the cell...
+    
+    NSDictionary *dataSourceItem = [self.model.dataSource objectAtIndex:indexPath.row];
+
     cell.titleLabel.text =  [dataSourceItem valueForKey:@"title"];
     cell.bodyLabel.text = [dataSourceItem valueForKey:@"body"];
 
-    // Don't need to set the preferredMaxLayoutWidth here because the cell will now have a fixed width, which will cause
-    // the multi-line label to wrap correctly since it is pinned to the left & right edges of the cell's contentView.
-//    cell.bodyLabel.preferredMaxLayoutWidth = tableView.bounds.size.width - kLabelHorizontalInsets * 2.0f;
-    
     // Make sure the constraints have been added to this cell, since it may have just been created from scratch
     [cell setNeedsUpdateConstraints];
 
@@ -100,6 +97,7 @@ - (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPa
     // Configure the cell with content for the given indexPath, for example:
     // cell.textLabel.text = someTextForThisCell;
     // ...
+    
     NSDictionary *dataSourceItem = [self.model.dataSource objectAtIndex:indexPath.row];
     cell.titleLabel.text =  [dataSourceItem valueForKey:@"title"];
     cell.bodyLabel.text = [dataSourceItem valueForKey:@"body"];
@@ -116,17 +114,14 @@ - (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPa
 
     CGFloat height = [cell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize].height;
 
-    NSLog(@"My returned height = %f", height);
     return height;
 }
 
 - (CGFloat)tableView:(UITableView *)tableView estimatedHeightForRowAtIndexPath:(NSIndexPath *)indexPath
 {
     // Return a fixed constant if possible, or do some minimal calculations if needed to be able to return an
     // estimated row height that's at least within an order of magnitude of the actual height.
-    // For example:
 
-//    NSLog(@"%@ %@", NSStringFromClass([self class]), NSStringFromSelector(_cmd));
     return 500.0f;
 
 }