Update sample project for iOS 8 self sizing cells

Author: smileyborg

TableViewCellWithAutoLayout.xcodeproj/project.pbxproj

@@ -405,6 +405,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "TableViewCellWithAutoLayout/TableViewCellWithAutoLayout-Prefix.pch";
 				INFOPLIST_FILE = "TableViewCellWithAutoLayout/TableViewCellWithAutoLayout-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};
@@ -418,6 +419,7 @@
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = "TableViewCellWithAutoLayout/TableViewCellWithAutoLayout-Prefix.pch";
 				INFOPLIST_FILE = "TableViewCellWithAutoLayout/TableViewCellWithAutoLayout-Info.plist";
+				IPHONEOS_DEPLOYMENT_TARGET = 8.0;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				WRAPPER_EXTENSION = app;
 			};

TableViewCellWithAutoLayout/TableViewController/RJTableViewCell.m

@@ -46,16 +46,16 @@ - (id)initWithStyle:(UITableViewCellStyle)style reuseIdentifier:(NSString *)reus
         [self.titleLabel setNumberOfLines:1];
         [self.titleLabel setTextAlignment:NSTextAlignmentLeft];
         [self.titleLabel setTextColor:[UIColor blackColor]];
-        self.titleLabel.backgroundColor = [UIColor colorWithRed:0 green:0 blue:1 alpha:0.1];
+        self.titleLabel.backgroundColor = [UIColor colorWithRed:0 green:0 blue:1 alpha:0.1]; // light blue
 
         self.bodyLabel = [UILabel newAutoLayoutView];
         [self.bodyLabel setLineBreakMode:NSLineBreakByTruncatingTail];
         [self.bodyLabel setNumberOfLines:0];
         [self.bodyLabel setTextAlignment:NSTextAlignmentLeft];
         [self.bodyLabel setTextColor:[UIColor darkGrayColor]];
-        self.bodyLabel.backgroundColor = [UIColor colorWithRed:1 green:0 blue:0 alpha:0.1];
+        self.bodyLabel.backgroundColor = [UIColor colorWithRed:1 green:0 blue:0 alpha:0.1]; // light red
 
-        self.contentView.backgroundColor = [UIColor colorWithRed:0 green:1 blue:0 alpha:0.1];
+        self.contentView.backgroundColor = [UIColor colorWithRed:0 green:1 blue:0 alpha:0.1]; // light green
 
         [self.contentView addSubview:self.titleLabel];
         [self.contentView addSubview:self.bodyLabel];
@@ -86,12 +86,7 @@ - (void)updateConstraints
     [self.titleLabel autoPinEdgeToSuperviewEdge:ALEdgeLeading withInset:kLabelHorizontalInsets];
     [self.titleLabel autoPinEdgeToSuperviewEdge:ALEdgeTrailing withInset:kLabelHorizontalInsets];
 
-    // This is the constraint that connects the title and body labels. It is a "greater than or equal" inequality so that if the row height is
-    // slightly larger than what is actually required to fit the cell's subviews, the extra space will go here. (This is the case on iOS 7
-    // where the cell separator is only 0.5 points tall, but in the tableView:heightForRowAtIndexPath: method of the view controller, we add
-    // a full 1.0 point in extra height to account for it, which results in 0.5 points extra space in the cell.)
-    // See https://github.com/smileyborg/TableViewCellWithAutoLayout/issues/3 for more info.
-    [self.bodyLabel autoPinEdge:ALEdgeTop toEdge:ALEdgeBottom ofView:self.titleLabel withOffset:kLabelVerticalInsets relation:NSLayoutRelationGreaterThanOrEqual];
+    [self.bodyLabel autoPinEdge:ALEdgeTop toEdge:ALEdgeBottom ofView:self.titleLabel withOffset:kLabelVerticalInsets];
 
     [UIView autoSetPriority:UILayoutPriorityRequired forConstraints:^{
         [self.bodyLabel autoSetContentCompressionResistancePriorityForAxis:ALAxisVertical];
@@ -103,20 +98,6 @@ - (void)updateConstraints
     self.didSetupConstraints = YES;
 }
 
-- (void)layoutSubviews
-{
-    [super layoutSubviews];
-    
-    // Make sure the contentView does a layout pass here so that its subviews have their frames set, which we
-    // need to use to set the preferredMaxLayoutWidth below.
-    [self.contentView setNeedsLayout];
-    [self.contentView layoutIfNeeded];
-    
-    // Set the preferredMaxLayoutWidth of the mutli-line bodyLabel based on the evaluated width of the label's frame,
-    // as this will allow the text to wrap correctly, and as a result allow the label to take on the correct height.
-    self.bodyLabel.preferredMaxLayoutWidth = CGRectGetWidth(self.bodyLabel.frame);
-}
-
 - (void)updateFonts
 {
     self.titleLabel.font = [UIFont preferredFontForTextStyle:UIFontTextStyleHeadline];

TableViewCellWithAutoLayout/TableViewController/RJTableViewController.m

@@ -34,17 +34,6 @@ @interface RJTableViewController ()
 
 @property (strong, nonatomic) RJModel *model;
 
-// A dictionary of offscreen cells that are used within the tableView:heightForRowAtIndexPath: method to
-// handle the height calculations. These are never drawn onscreen. The dictionary is in the format:
-//      { NSString *reuseIdentifier : UITableViewCell *offscreenCell, ... }
-@property (strong, nonatomic) NSMutableDictionary *offscreenCells;
-
-// For iOS 7.0.x compatibility ONLY (this bug is fixed in iOS 7.1):
-// This property is used to work around the constraint exception that is thrown if the
-// estimated row height for an inserted row is greater than the actual height for that row.
-// See: https://github.com/caoimghgin/TableViewCellWithAutoLayout/issues/6
-@property (assign, nonatomic) BOOL isInsertingRow;
-
 @end
 
 @implementation RJTableViewController
@@ -55,7 +44,6 @@ - (id)initWithStyle:(UITableViewStyle)style
     if (self) {
         self.model = [[RJModel alloc] init];
         [self.model populateDataSource];
-        self.offscreenCells = [NSMutableDictionary dictionary];
     }
     return self;
 }
@@ -64,17 +52,21 @@ - (void)viewDidLoad
 {
     [super viewDidLoad];
 
-    self.title = @"Auto Layout Table View";
+    self.title = @"iOS 8 Self Sizing Cells";
     self.navigationItem.leftBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemTrash target:self action:@selector(clear:)];
     self.navigationItem.rightBarButtonItem = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemAdd target:self action:@selector(addRow:)];
 
+    self.tableView.allowsSelection = NO;
+    
     [self.tableView registerClass:[RJTableViewCell class] forCellReuseIdentifier:CellIdentifier];
 
+    // Self-sizing table view cells in iOS 8 require that the rowHeight property of the table view be set to the constant UITableViewAutomaticDimension
+    self.tableView.rowHeight = UITableViewAutomaticDimension;
+    
+    // Self-sizing table view cells in iOS 8 are enabled when the estimatedRowHeight property of the table view is set to a non-zero value.
     // Setting the estimated row height prevents the table view from calling tableView:heightForRowAtIndexPath: for every row in the table on first load;
     // it will only be called as cells are about to scroll onscreen. This is a major performance optimization.
-    self.tableView.estimatedRowHeight = UITableViewAutomaticDimension;
-    
-    self.tableView.allowsSelection = NO;
+    self.tableView.estimatedRowHeight = 44.0;
 }
 
 - (void)viewDidAppear:(BOOL)animated
@@ -120,12 +112,8 @@ - (void)addRow:(id)sender
 {
     [self.model addSingleItemToDataSource];
 
-    self.isInsertingRow = YES;
-    
     NSIndexPath *lastIndexPath = [NSIndexPath indexPathForRow:[self.model.dataSource count] - 1 inSection:0];
     [self.tableView insertRowsAtIndexPaths:@[lastIndexPath] withRowAnimation:UITableViewRowAnimationAutomatic];
-    
-    self.isInsertingRow = NO;
 }
 
 #pragma mark - Table view data source
@@ -157,58 +145,6 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
     return cell;
 }
 
-- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath
-{
-    // This project has only one cell identifier, but if you are have more than one, this is the time
-    // to figure out which reuse identifier should be used for the cell at this index path.
-    NSString *reuseIdentifier = CellIdentifier;
-    
-    // Use the dictionary of offscreen cells to get a cell for the reuse identifier, creating a cell and storing
-    // it in the dictionary if one hasn't already been added for the reuse identifier.
-    // WARNING: Don't call the table view's dequeueReusableCellWithIdentifier: method here because this will result
-    // in a memory leak as the cell is created but never returned from the tableView:cellForRowAtIndexPath: method!
-    RJTableViewCell *cell = [self.offscreenCells objectForKey:reuseIdentifier];
-    if (!cell) {
-        cell = [[RJTableViewCell alloc] init];
-        [self.offscreenCells setObject:cell forKey:reuseIdentifier];
-    }
-    
-    // Configure the cell for this indexPath
-    [cell updateFonts];
-    NSDictionary *dataSourceItem = [self.model.dataSource objectAtIndex:indexPath.row];
-    cell.titleLabel.text =  [dataSourceItem valueForKey:@"title"];
-    cell.bodyLabel.text = [dataSourceItem valueForKey:@"body"];
-    
-    // Make sure the constraints have been added to this cell, since it may have just been created from scratch
-    [cell setNeedsUpdateConstraints];
-    [cell updateConstraintsIfNeeded];
-    
-    // The cell's width must be set to the same size it will end up at once it is in the table view.
-    // This is important so that we'll get the correct height for different table view widths, since our cell's
-    // height depends on its width due to the multi-line UILabel word wrapping. Don't need to do this above in
-    // -[tableView:cellForRowAtIndexPath:] because it happens automatically when the cell is used in the table view.
-    cell.bounds = CGRectMake(0.0f, 0.0f, CGRectGetWidth(tableView.bounds), CGRectGetHeight(cell.bounds));
-    // NOTE: if you are displaying a section index (e.g. alphabet along the right side of the table view), or
-    // if you are using a grouped table view style where cells have insets to the edges of the table view,
-    // you'll need to adjust the cell.bounds.size.width to be smaller than the full width of the table view we just
-    // set it to above. See http://stackoverflow.com/questions/3647242 for discussion on the section index width.
-    
-    // Do the layout pass on the cell, which will calculate the frames for all the views based on the constraints
-    // (Note that the preferredMaxLayoutWidth is set on multi-line UILabels inside the -[layoutSubviews] method
-    // in the UITableViewCell subclass
-    [cell setNeedsLayout];
-    [cell layoutIfNeeded];
-    
-    // Get the actual height required for the cell
-    CGFloat height = [cell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize].height;
-    
-    // Add an extra point to the height to account for the cell separator, which is added between the bottom
-    // of the cell's contentView and the bottom of the table view cell.
-    height += 1;
-    
-    return height;
-}
-
 /*
 - (CGFloat)tableView:(UITableView *)tableView estimatedHeightForRowAtIndexPath:(NSIndexPath *)indexPath
 {
@@ -219,17 +155,8 @@ - (CGFloat)tableView:(UITableView *)tableView estimatedHeightForRowAtIndexPath:(
     // Only implement this method if you have row heights that vary by extreme amounts and you notice the scroll indicator
     // "jumping" as you scroll the table view when using a constant estimatedRowHeight. If you do implement this method,
     // be sure to do as little work as possible to get a reasonably-accurate estimate.
- 
-    // NOTE for iOS 7.0.x ONLY, this bug has been fixed by Apple as of iOS 7.1:
-    // A constraint exception will be thrown if the estimated row height for an inserted row is greater
-    // than the actual height for that row. In order to work around this, we need to return the actual
-    // height for the the row when inserting into the table view - uncomment the below 3 lines of code.
-    // See: https://github.com/caoimghgin/TableViewCellWithAutoLayout/issues/6
-    //    if (self.isInsertingRow) {
-    //        return [self tableView:tableView heightForRowAtIndexPath:indexPath];
-    //    }
     
-    return UITableViewAutomaticDimension;
+    return 44.0;
 }
 */