COMMON: fix compiler warnings

Author: Chris Warren-Smith

src/common/blib.c

@@ -1002,7 +1002,7 @@ bcip_t cmd_push_args(int cmd, bcip_t goto_addr, bcip_t rvid) {
 
         prog_ip = ofs;       // back to the start of the expression
         // now we are sure, this parameter is not a single variable
-        // no 'break' here
+        // fallthrough
 
       default:
         // default: the parameter is an expression
@@ -1096,7 +1096,7 @@ void cmd_call_unit_udp(int cmd, int udp_tid, bcip_t goto_addr, bcip_t rvid) {
 
         prog_ip = ofs;       // back to the start of the expression
         // now we are sure, this parameter is not a single variable
-        // no 'break' here
+        // fallthrough
 
       default:
         // default: the parameter is an expression

src/common/blib_func.c

@@ -2574,7 +2574,8 @@ void cmd_genfunc(long funcCode, var_t *r) {
           }
         }
         prog_ip = ofs;
-        // no 'break' here
+        // fallthrough
+
       default:
         // default --- expression
         v_init(&arg);
@@ -2646,7 +2647,8 @@ void cmd_genfunc(long funcCode, var_t *r) {
           }
         }
         prog_ip = ofs;
-        // no 'break' here
+        // fallthrough
+
       default:
         // default --- expression
         v_init(&arg);

src/common/ceval.c

@@ -198,9 +198,11 @@ void cev_prim() {
   case kwTYPE_CALLEXTF:        // [lib][index]
     bc_add_n(bc_out, bc_in->ptr + bc_in->cp, ADDRSZ);
     IP += ADDRSZ;              // no break here
+    // fallthrough
   case kwTYPE_CALLF:           // [code]
     bc_add_n(bc_out, bc_in->ptr + bc_in->cp, ADDRSZ);
     IP += ADDRSZ;              // no break here
+    // fallthrough
   default:
     if (CODE_PEEK() == kwTYPE_LEVEL_BEGIN) {
       if (CODE(IP + 1) == kwTYPE_LEVEL_END) {

src/common/plugins.c

@@ -443,7 +443,7 @@ int plugin_import(const char *name, const char *alias) {
     for (int i = 0; i < MAX_SLIBS; i++) {
       if (!plugins[i]) {
         // found free slot
-        slib_t *lib = plugins[i] = (slib_t *)calloc(sizeof(slib_t), 1);
+        slib_t *lib = plugins[i] = (slib_t *)calloc(1, sizeof(slib_t));
         if (!lib) {
           sc_raise("LIB: plugin_import failed");
           break;
@@ -465,7 +465,7 @@ int plugin_import(const char *name, const char *alias) {
 void plugin_open(const char *name, int lib_id) {
   slib_t *lib = get_lib(lib_id);
   if (!lib && lib_id >= 0 && lib_id < MAX_SLIBS) {
-    lib = plugins[lib_id] = (slib_t *)calloc(sizeof(slib_t), 1);
+    lib = plugins[lib_id] = (slib_t *)calloc(1, sizeof(slib_t));
     if (lib) {
       char path[PATH_SIZE];
       char file[PATH_SIZE];
@@ -622,7 +622,8 @@ int plugin_build_ptable(slib_par_t *ptable, int size) {
 
         // restore IP
         prog_ip = ofs;
-        // no 'break' here
+        // fallthrough
+
       default:
         // default --- expression (BYVAL ONLY)
         arg = v_new();

src/common/proc.c

@@ -878,8 +878,8 @@ int par_getpartable(par_t **ptable_pp, const char *valid_sep, unsigned max_items
       // Its no a single variable, its an expression
       // restore IP
       prog_ip = ofs;
+      // fallthrough
 
-      // no 'break' here
     default:
       // default --- expression (BYVAL ONLY)
       par = v_new();
@@ -1026,6 +1026,7 @@ int par_massget(const char *fmt, ...) {
           va_arg(ap, char **);
           break;
         }
+        // fallthrough
       case 'S':
         // string
         s = va_arg(ap, char **);
@@ -1038,6 +1039,7 @@ int par_massget(const char *fmt, ...) {
           va_arg(ap, var_int_t *);
           break;
         }
+        // fallthrough
       case 'I':
         // integer
         i = va_arg(ap, var_int_t *);
@@ -1050,6 +1052,7 @@ int par_massget(const char *fmt, ...) {
           va_arg(ap, var_num_t *);
           break;
         }
+        // fallthrough
       case 'F':
         // real (var_num_t)
         f = va_arg(ap, var_num_t *);
@@ -1062,6 +1065,7 @@ int par_massget(const char *fmt, ...) {
           va_arg(ap, var_t **);
           break;
         }
+        // fallthrough
       case 'P':
         // variable
         vt = va_arg(ap, var_t **);

src/lib/match.c

@@ -228,6 +228,7 @@ int reg_match_jk(const char *p, char *t) {
        */
       if (*p == '\0')
         return reg_match_bad_pattern;
+      // fallthrough
 
       /*
        * must match this character exactly