Skip to content

Commit 737dcf1

Browse files
authored
Merge pull request #69 from singularityware/v3.3.0
Updating v3.3.0 to be on master
2 parents a093e80 + 2108703 commit 737dcf1

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2016-2018 Vanessa Sochat
3+
Copyright (c) 2016-2019 Vanessa Sochat
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ If you want a legacy version, see the following other branches:
5555
- [v2.5](https://github.com/singularityware/docker2singularity/tree/v2.5): Version 2.5.1 of Singularity. Same as 2.4 but with many bug fixes.
5656
- [v2.6](https://github.com/singularityware/docker2singularity/tree/v2.6): Version 2.6 of Singularity.
5757

58-
Intermediate versions built on [Docker Hub](https://hub.docker.com/r/singularityware/docker2singularity/tags/). A tag with prefix `v` corresponds to a release of the Singularity software, while the others are in reference to releases of Docker.
58+
Intermediate versions built on [Docker Hub](https://hub.docker.com/r/singularityware/docker2singularity/tags/). A tag with prefix `v` corresponds to a release of the Singularity software, while the others are in reference to releases of Docker. Previously used [scripts](https://github.com/singularityware/docker2singularity/tree/master/scripts), including environment and action files, are provided in this repository for reference.
5959

6060
## Requirements
6161

docker2singularity.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,10 @@ chmod +x $build_sandbox/.singularity.d/runscript;
269269

270270
echo "(5/10) Setting ENV variables..."
271271

272-
# First add templates for actions and env
273-
cp -R /scripts/env $build_sandbox/.singularity.d/
274-
cp -R /scripts/actions $build_sandbox/.singularity.d/
272+
# Removed copying of template files to avoid scripts permissions issue (see #66)
273+
# Create env scripts directory
274+
mkdir -p $build_sandbox/.singularity.d/env
275+
chmod 755 $build_sandbox/.singularity.d/env
275276

276277
# Then customize by adding Docker variables
277278
docker run --rm --entrypoint="/usr/bin/env" $image > $TMPDIR/docker_environment

0 commit comments

Comments
 (0)