Skip to content

Commit 5cd3b84

Browse files
committed
Updating based on PR #67 review comments.
1 parent dd9372a commit 5cd3b84

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

docker2singularity.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,12 +269,10 @@ chmod +x $build_sandbox/.singularity.d/runscript;
269269

270270
echo "(5/10) Setting ENV variables..."
271271

272-
# First add templates for actions and env
273-
## Removed to avoid permissions issue with scripts (see #66)
274-
## cp -R /scripts/env $build_sandbox/.singularity.d/
275-
## cp -R /scripts/actions $build_sandbox/.singularity.d/
272+
# Removed copying of template files to avoid scripts permissions issue (see #66)
276273
# Create env scripts directory
277-
mkdir $build_sandbox/.singularity.d/env; chmod 755 $build_sandbox/.singularity.d/env
274+
mkdir -p $build_sandbox/.singularity.d/env
275+
chmod 755 $build_sandbox/.singularity.d/env
278276

279277
# Then customize by adding Docker variables
280278
docker run --rm --entrypoint="/usr/bin/env" $image > $TMPDIR/docker_environment

0 commit comments

Comments
 (0)