Achieve 100% test coverage

Add missing test cases and mark uncoverable code paths.

Author: simukappu

app/controllers/activity_notification/notifications_controller.rb

@@ -159,8 +159,7 @@ def set_index_options
         limit              = params[:limit].to_i > 0 ? params[:limit].to_i : nil
         reverse            = params[:reverse].present? ?
                                params[:reverse].to_s.to_boolean(false) : nil
-        with_group_members = params[:with_group_members].present? || params[:without_grouping].present? ?
-                               params[:with_group_members].to_s.to_boolean(false) || params[:without_grouping].to_s.to_boolean(false) : nil
+        with_group_members = params[:with_group_members].present? || params[:without_grouping].present? ? params[:with_group_members].to_s.to_boolean(false) || params[:without_grouping].to_s.to_boolean(false) : nil
         @index_options     = params.permit(:filter, :filtered_by_type, :filtered_by_group_type, :filtered_by_group_id, :filtered_by_key, :later_than, :earlier_than, :routing_scope, :devise_default_routes)
                                    .to_h.symbolize_keys
                                    .merge(limit: limit, reverse: reverse, with_group_members: with_group_members)

app/controllers/activity_notification/subscriptions_controller.rb

@@ -199,8 +199,7 @@ def subscription_params
       # @return [Hash] options to load subscription index
       def set_index_options
         limit          = params[:limit].to_i > 0 ? params[:limit].to_i : nil
-        reverse        = params[:reverse].present? ?
-                           params[:reverse].to_s.to_boolean(false) : nil
+        reverse        = params[:reverse].present? ? params[:reverse].to_s.to_boolean(false) : nil
         @index_options = params.permit(:filter, :filtered_by_key, :routing_scope, :devise_default_routes)
                                .to_h.symbolize_keys.merge(limit: limit, reverse: reverse)
       end

lib/activity_notification/controllers/common_controller.rb

@@ -72,9 +72,7 @@ def controller_path
       def target_view_path
         target_type = @target.to_resources_name
         view_path = [controller_path, target_type].join('/')
-        lookup_context.exists?(action_name, view_path) ?
-          view_path :
-          [controller_path, DEFAULT_VIEW_DIRECTORY].join('/')
+        lookup_context.exists?(action_name, view_path) ? view_path : [controller_path, DEFAULT_VIEW_DIRECTORY].join('/')
       end
 
       # Sets view prefixes for target view path.

lib/activity_notification/models/concerns/notifiable.rb

@@ -435,9 +435,7 @@ def resolve_parameter(target_typed_method_name, parameter_field, default_value,
       # @api private
       # @param [String] target_type Target type of generated notifications
       def generated_notifications_as_notifiable_for(target_type = nil)
-        target_type.nil? ?
-          generated_notifications_as_notifiable.all :
-          generated_notifications_as_notifiable.filtered_by_target_type(target_type.to_s.to_model_name)
+        target_type.nil? ? generated_notifications_as_notifiable.all : generated_notifications_as_notifiable.filtered_by_target_type(target_type.to_s.to_model_name)
       end
 
       # Destroies generated notifications for specified target type with dependency.