fix(cleanup): spend an attempt when the lowest unfinished image sweep stalls

The inline image handler continued without consuming an attempt whenever any
chat hit the deadline, even when the lowest unfinished chat had stalled and
the checkpoint could not advance, so the event could rerun forever. It now
continues only after the checkpoint advanced or when the lowest unfinished
chat is itself still advancing, and defers otherwise.

Author: waleedlatif1

apps/sim/lib/cleanup/chat-backend-cleanup-outbox.test.ts

@@ -105,4 +105,20 @@ describe('chat inline image cleanup', () => {
     expect(result).not.toMatchObject({ consumeAttempt: false })
     expect(context.checkpointPayload).not.toHaveBeenCalled()
   })
+
+  it('spends an attempt when the lowest unfinished chat stalls, though a later one continues', async () => {
+    queueTableRows(copilotChats, [])
+    mockSweepStoragePrefix.mockImplementation(async (prefix: string) => {
+      if (prefix === prefixOf(chatIds[0])) return 'stalled'
+      deadline.near = true
+      return 'continue'
+    })
+    const context = outboxContext()
+
+    const result = await sweepImages({ chatIds: chatIds.slice(0, 2) }, context)
+
+    expect(result).toMatchObject({ outcome: 'deferred' })
+    expect(result).not.toMatchObject({ consumeAttempt: false })
+    expect(context.checkpointPayload).not.toHaveBeenCalled()
+  })
 })

apps/sim/lib/cleanup/chat-backend-cleanup-outbox.ts

@@ -123,7 +123,9 @@ export const chatBackendCleanupOutboxHandlers = {
     const unfinished = outcomes.findIndex((outcome) => outcome !== 'done')
     if (unfinished === -1) return
     if (unfinished > 0) await context.checkpointPayload({ swept: swept + unfinished })
-    if (outcomes.includes('continue'))
+    // A free rerun only after durable progress, or while the lowest unfinished chat itself advances;
+    // a stalled one behind a continuing chat would otherwise rerun without end.
+    if (unfinished > 0 || outcomes[unfinished] === 'continue')
       return continueOutboxHandler('Continuing chat inline image cleanup')
     return deferOutboxHandler('Chat inline image cleanup removed nothing from its listing')
   },