fix(workflows): scope the typed-elements check to arrays and type the field helper

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.test.ts

@@ -20,4 +20,12 @@ describe('createFieldFromOutput', () => {
     })
     expect(field.children?.map((child) => child.name)).toEqual(['id'])
   })
+
+  it('keeps the fields of an untyped object that has a field named items', () => {
+    const field = createFieldFromOutput('page', {
+      items: { type: 'string' },
+      total: { type: 'number' },
+    })
+    expect(field.children?.map((child) => child.name)).toEqual(['items', 'total'])
+  })
 })

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-output-fields.ts

@@ -12,7 +12,8 @@ const RESERVED_KEYS = new Set(['type', 'description'])
 /**
  * Checks if a property is an object type
  */
-const isObject = (prop: any): boolean => prop && typeof prop === 'object'
+const isObject = (prop: unknown): prop is Record<string, any> =>
+  prop !== null && typeof prop === 'object'
 
 /**
  * Gets a subblock value from the store
@@ -36,7 +37,7 @@ const extractChildFields = (prop: any): SchemaField[] | undefined => {
   }
 
   /** Typed elements without `properties` (strings, `any`) have no fields to reference. */
-  if (isObject(prop.items) && typeof prop.items.type === 'string') {
+  if (prop.type === 'array' && isObject(prop.items) && typeof prop.items.type === 'string') {
     return undefined
   }
 
@@ -76,7 +77,7 @@ const extractNestedFields = (properties: Record<string, any>): SchemaField[] =>
 /**
  * Creates a schema field from an output definition
  */
-export const createFieldFromOutput = (name: string, output: any): SchemaField => {
+export const createFieldFromOutput = (name: string, output: unknown): SchemaField => {
   const hasExplicitType = isObject(output) && typeof output.type === 'string'
   const type = hasExplicitType ? output.type : isObject(output) ? 'object' : 'string'