fix(search): keep admin setup out of member integrations

Author: Vikhyath Mondreti

apps/sim/app/o/[organizationId]/integrations/live-member-integrations.test.tsx

@@ -122,10 +122,12 @@ describe('live member connection states', () => {
   it.each([
     ['disabled', { credentialGroup: { ...group, status: 'disabled' } }],
     ['unconfigured', { credentialGroup: null }],
-  ])('does not offer a connection when %s', async (_name, overrides) => {
+  ])('disables connection when %s', async (_name, overrides) => {
     mocks.inventory.mockReturnValue({ data: inventory(overrides) })
     await render()
-    expect(button('Connect')).toBeUndefined()
+    expect(button('Connect')?.disabled).toBe(true)
+    await act(async () => button('Connect')!.click())
+    expect(mocks.connect).not.toHaveBeenCalled()
   })
   it('shows the current account and reconnect action without enabling a disabled integration', async () => {
     mocks.inventory.mockReturnValue({
@@ -192,13 +194,21 @@ describe('live member connection states', () => {
     await render()
     expect(container.textContent).toBe('')
   })
-  it('sends admins to Credential Groups when member sign-in is not configured', async () => {
-    mocks.inventory.mockReturnValue({ data: inventory({ credentialGroup: null, canManage: true }) })
-    await render()
-    expect(container.querySelector('a')?.getAttribute('href')).toBe(
-      '/o/org/settings/connected-accounts'
-    )
-  })
+  it.each([false, true])(
+    'keeps Slack app setup out of member Integrations, admin=%s',
+    async (canManage) => {
+      mocks.policies.mockReturnValue({ data: [{ connectorType: 'slack', approved: true }] })
+      mocks.inventory.mockReturnValue({ data: inventory({ canManage }) })
+      await render()
+      expect(container.textContent).toContain('Slack')
+      expect(container.textContent).toContain('Not configured')
+      expect(container.textContent).not.toContain('Finish setup')
+      expect(container.querySelector('a')).toBeNull()
+      expect(button('Connect')?.disabled).toBe(true)
+      await act(async () => button('Connect')!.click())
+      expect(mocks.connect).not.toHaveBeenCalled()
+    }
+  )
   it('explains service-account scope without hiding member connection controls', async () => {
     mocks.policies.mockReturnValue({
       data: [

apps/sim/app/o/[organizationId]/integrations/live-member-integrations.tsx

@@ -1,8 +1,7 @@
 'use client'
 
-import { Chip, ChipLink, toast } from '@sim/emcn'
+import { Chip, toast } from '@sim/emcn'
 import type { OrganizationAccountConnectionResponse } from '@/lib/api/contracts/organization-accounts'
-import { organizationRoutes } from '@/lib/navigation/paths'
 import { connectorDisplayName, SEARCH_SOURCE_TYPES } from '@/lib/sim-search/connectors'
 import { LIVE_SEARCH_SCOPE_FIELDS } from '@/lib/sim-search/live/policy-schema'
 import { DisconnectAccountMenu } from '@/app/o/[organizationId]/integrations/disconnect-account-menu'
@@ -149,7 +148,7 @@ export function LiveMemberIntegrations({ organizationId, search }: LiveMemberInt
           : group && group.status !== 'active'
             ? 'Connections are paused by your organization'
             : !ready
-              ? 'An admin needs to finish connection setup'
+              ? 'Not configured'
               : accounts.length
                 ? scope
                 : undefined
@@ -191,10 +190,10 @@ export function LiveMemberIntegrations({ organizationId, search }: LiveMemberInt
                       Reconnect{accounts.length > 1 ? ` ${account.displayName}` : ''}
                     </Chip>
                   ))}
-                {ready ? (
+                {approved && (
                   <Chip
                     variant={accounts.length ? undefined : 'primary'}
-                    disabled={pending}
+                    disabled={pending || !ready}
                     onClick={() =>
                       connect.mutate(
                         {
@@ -216,13 +215,7 @@ export function LiveMemberIntegrations({ organizationId, search }: LiveMemberInt
                         ? 'Add account'
                         : 'Connect'}
                   </Chip>
-                ) : data.canManage && approved ? (
-                  <ChipLink
-                    href={organizationRoutes(organizationId).settingsSection('connected-accounts')}
-                  >
-                    Finish setup
-                  </ChipLink>
-                ) : null}
+                )}
               </div>
             }
           />