fix(cleanup): scope a chat's file row by the row's own workspace first

collectChatFiles placed a linked file row in the chat's organization whenever the chat had one, ignoring the workspace the row itself belongs to, so the reference check would look at the wrong scope's chats. A chat holds a workspace or an organization, never both, but a file row's own workspace is its real owner, so it now comes first.

Autopsy: the reference-check tests seeded only organization chats with organization keys, so no test placed a workspace-owned row attached in an organization chat.

Author: waleedlatif1

apps/sim/lib/cleanup/chat-cleanup.integration.ts

@@ -1,6 +1,14 @@
 /** Exercises chat cleanup's storage-key collection against real PostgreSQL message rows. */
 import { db, dbFor } from '@sim/db'
-import { copilotChats, copilotMessages, organization, user } from '@sim/db/schema'
+import {
+  copilotChats,
+  copilotMessages,
+  organization,
+  user,
+  workspace,
+  workspaceFiles,
+} from '@sim/db/schema'
+import { deleteWorkspaceFixture, insertWorkspaceFixture } from '@sim/db/testing/workspace-fixtures'
 import { generateId } from '@sim/utils/id'
 import { compareStrings } from '@sim/utils/string'
 import { eq } from 'drizzle-orm'
@@ -169,6 +177,40 @@ describe('deletable chat files against PostgreSQL message rows', () => {
     )
   })
 
+  it("scopes a chat's file row by the row's own workspace, not the chat's organization", async () => {
+    const workspaceId = generateId()
+    await insertWorkspaceFixture(db, {
+      id: workspaceId,
+      name: 'Chat cleanup fixture',
+      ownerId: userId,
+      billedAccountUserId: userId,
+    })
+    try {
+      const chatId = await seedChat([{ role: 'user', content: 'look' }], [], organizationId)
+      const key = `workspace/${workspaceId}/${generateId()}/linked.png`
+      await db.insert(workspaceFiles).values({
+        id: generateId(),
+        key,
+        userId,
+        workspaceId,
+        context: 'mothership',
+        chatId,
+        originalName: 'linked.png',
+        contentType: 'image/png',
+        sizeBytes: 1,
+      })
+
+      const files = await collectChatFiles([chatId])
+
+      expect(files.find((file) => file.key === key)?.scope).toEqual({
+        kind: 'workspace',
+        id: workspaceId,
+      })
+    } finally {
+      await deleteWorkspaceFixture(db, eq(workspace.id, workspaceId))
+    }
+  })
+
   it('places a legacy ref by its key, keeping one it cannot place', async () => {
     const referenced = `assistant/${organizationId}/${userId}/u1/kept.png`
     const unreferenced = `assistant/${organizationId}/${userId}/u2/gone.png`

apps/sim/lib/cleanup/chat-files.ts

@@ -187,10 +187,11 @@ export async function collectChatFiles(
       chatId: string,
       fileWorkspaceId?: string | null
     ): ChatFileReferenceScope | null => {
+      // A file row's own workspace owns it, whatever the chat it was attached in belongs to.
+      if (fileWorkspaceId) return { kind: 'workspace', id: fileWorkspaceId }
       const chat = chatScopes.get(chatId)
       if (chat?.organizationId) return { kind: 'organization', id: chat.organizationId }
-      const workspaceId = fileWorkspaceId ?? chat?.workspaceId
-      return workspaceId ? { kind: 'workspace', id: workspaceId } : null
+      return chat?.workspaceId ? { kind: 'workspace', id: chat.workspaceId } : null
     }
 
     for (const f of linkedFiles) {