fix(databricks): preserve blank input and validation semantics

Author: waleedlatif1

apps/sim/tools/databricks/cancel_all_runs.ts

@@ -1,4 +1,5 @@
 import { filterUndefined } from '@sim/utils/object'
+import { UserFailure } from '@/lib/core/errors/user-failure'
 import type {
   DatabricksCancelAllRunsParams,
   DatabricksSuccessResponse,
@@ -42,7 +43,7 @@ export const cancelAllRunsTool: ToolConfig<
     }),
     body: (params) => {
       if (params.jobId == null && params.allQueuedRuns !== true) {
-        throw new Error(
+        throw new UserFailure(
           'Provide jobId or set allQueuedRuns to true to cancel queued workspace runs'
         )
       }

apps/sim/tools/databricks/databricks.test.ts

@@ -3,6 +3,7 @@ import { jsonResponse } from '@sim/testing/helpers/http'
 import { partialToolRegistry } from '@sim/testing/mocks/tool-registry.mock'
 import { getErrorMessage } from '@sim/utils/errors'
 import { describe, expect, it, vi } from 'vitest'
+import { adoptToolFailure, classifyFailure } from '@/lib/core/errors/failure-log'
 
 vi.mock('@/lib/core/security/input-validation.server', () => inputValidationMock)
 
@@ -64,17 +65,19 @@ describe('Databricks mutation intent', () => {
 
     expect(update('')).toEqual({ description: '' })
     expect(update()).not.toHaveProperty('description')
+    expect(update(' \n\t ')).not.toHaveProperty('description')
   })
 
   it.each([undefined, false])(
     'rejects cancellation without a job or explicit queued scope (%s)',
-    (allQueuedRuns) => {
-      expect(() =>
-        prepareToolRequest(databricksTools.databricksCancelAllRunsTool, {
-          ...credentials,
-          allQueuedRuns,
-        })
-      ).toThrow('Provide jobId or set allQueuedRuns to true')
+    async (allQueuedRuns) => {
+      const result = await executeTool('databricks_cancel_all_runs', {
+        ...credentials,
+        allQueuedRuns,
+      })
+      expect(result.success).toBe(false)
+      expect(result.error).toContain('Provide jobId or set allQueuedRuns to true')
+      expect(classifyFailure(adoptToolFailure(new Error(result.error), result))).toBe('user')
     }
   )
 

apps/sim/tools/databricks/genie_update_space.ts

@@ -87,7 +87,7 @@ export const genieUpdateSpaceTool: ToolConfig<
       return filterUndefined({
         serialized_space: optionalDatabricksString(params.serializedSpace),
         title: optionalDatabricksString(params.title),
-        description: params.description?.trim(),
+        description: params.description === '' ? '' : optionalDatabricksString(params.description),
         warehouse_id: optionalDatabricksString(params.warehouseId),
         etag: optionalDatabricksString(params.etag),
         parent_path: optionalDatabricksString(params.parentPath),