fix(files): await browser readiness and guard sharing fixture cleanup

Author: waleedlatif1

apps/sim/scripts/files-e2e/sharing.ts

@@ -96,24 +96,26 @@ export async function runSharingChecks({
   const browser = page.context().browser()
   assert(browser)
   const anonymous = await browser.newContext({ viewport: { width: 1200, height: 900 } })
-  await anonymous.tracing.start({ screenshots: true, snapshots: true, sources: false })
-  const publicGet = (path: string) =>
-    anonymous.request.get(new URL(path, baseUrl).href, { timeout: 180_000 })
-  const visitor = await anonymous.newPage()
-  visitor.setDefaultTimeout(60_000)
-  visitor.setDefaultNavigationTimeout(180_000)
-  const browserErrors: string[] = []
-  visitor.on('pageerror', (error) => browserErrors.push(error.message))
-  let token = ''
-  let shareId = ''
-  const publicPath = () => `/api/files/public/${token}`
-  const folderPath = () => `${publicPath()}/folder`
-  const contentPath = (fileId: string) => `${publicPath()}/content?fileId=${fileId}`
-  const anonymousJson = (path: string, expected = 200) =>
-    json(path, { authenticated: false, expected })
-  const updateShare = (body: Record<string, unknown>) => json(sharePath, { method: 'PUT', body })
-
+  let tracingStarted = false
   try {
+    await anonymous.tracing.start({ screenshots: true, snapshots: true, sources: false })
+    tracingStarted = true
+    const publicGet = (path: string) =>
+      anonymous.request.get(new URL(path, baseUrl).href, { timeout: 180_000 })
+    const visitor = await anonymous.newPage()
+    visitor.setDefaultTimeout(60_000)
+    visitor.setDefaultNavigationTimeout(180_000)
+    const browserErrors: string[] = []
+    visitor.on('pageerror', (error) => browserErrors.push(error.message))
+    let token = ''
+    let shareId = ''
+    const publicPath = () => `/api/files/public/${token}`
+    const folderPath = () => `${publicPath()}/folder`
+    const contentPath = (fileId: string) => `${publicPath()}/content?fileId=${fileId}`
+    const anonymousJson = (path: string, expected = 200) =>
+      json(path, { authenticated: false, expected })
+    const updateShare = (body: Record<string, unknown>) => json(sharePath, { method: 'PUT', body })
+
     await sql.begin(async (tx) => {
       const readerEmail = `files-reader-${readerId}@files-e2e.test`
       await tx`insert into "user" (id, name, email, normalized_email, email_verified, created_at, updated_at)
@@ -613,9 +615,11 @@ export async function runSharingChecks({
     )
   } finally {
     try {
-      await anonymous.tracing.stop({
-        path: join(reportDirectory, 'public-folder-browser-trace.zip'),
-      })
+      if (tracingStarted) {
+        await anonymous.tracing.stop({
+          path: join(reportDirectory, 'public-folder-browser-trace.zip'),
+        })
+      }
     } finally {
       try {
         await anonymous.close()

apps/sim/scripts/files-e2e/upload-lifecycle.ts

@@ -13,7 +13,7 @@ export async function runUploadLifecycleChecks(context: FilesE2EContext, directo
     waitUntil: 'domcontentloaded',
   })
   await page.locator('input[webkitdirectory]').waitFor({ state: 'attached' })
-  await uploadMenuTrigger(page).waitFor()
+  await uploadMenuTrigger(page).and(page.locator(':enabled')).waitFor()
 
   await check(
     'cancel releases a delayed native directory read and permits a new upload',

apps/sim/scripts/test-files-e2e.ts

@@ -611,7 +611,7 @@ async function runNavigationChecks(page: Page) {
     const movedFolder = await createFolder('Move to ancestor', d)
     await page.setViewportSize({ width: 900, height: 800 })
     await page.goto(url(d), { waitUntil: 'domcontentloaded' })
-    const source = page.locator(`[data-row-id="folder:${movedFolder}"]`)
+    const source = page.locator(`[data-row-id="folder:${movedFolder}"][draggable="true"]`)
     await source.waitFor()
     const drag = await page.evaluateHandle(() => new DataTransfer())
     try {