chore(cleanup): use isRecordLike for inline record guards

Author: waleedlatif1

apps/sim/lib/knowledge/documents/processing-outbox-handler.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 import { assertBillingAttributionSnapshot } from '@/lib/billing/core/billing-attribution'
 import { env, envNumber } from '@/lib/core/config/env'
 import { isTriggerAvailable } from '@/lib/core/config/trigger-availability'
@@ -67,7 +68,7 @@ import {
 } from '@/lib/knowledge/documents/storage-cleanup'
 
 function requirePayloadRecord(payload: unknown): Record<string, unknown> {
-  if (!payload || typeof payload !== 'object' || Array.isArray(payload)) {
+  if (!isRecordLike(payload)) {
     throw new Error('Knowledge document processing outbox payload must be an object')
   }
   return payload as Record<string, unknown>

apps/sim/lib/knowledge/secret-provenance-selection.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 export interface KnowledgeDocumentTagProvenanceTarget {
   tagName: string
   value: unknown
@@ -16,7 +17,7 @@ export function parseKnowledgeDocumentTagProvenanceTargets(
     const parsed: unknown = JSON.parse(documentTagsData)
     if (!Array.isArray(parsed)) return []
     return parsed.flatMap((candidate) => {
-      if (!candidate || typeof candidate !== 'object' || Array.isArray(candidate)) return []
+      if (!isRecordLike(candidate)) return []
       const record = candidate as Record<string, unknown>
       const tagName = typeof record.tagName === 'string' ? record.tagName.trim() : ''
       if (!tagName || record.value === undefined || record.value === null || record.value === '') {

apps/sim/lib/table/columns/workflow-references.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 /**
  * Finds workflow Table blocks whose saved configuration still names a column by
  * its old name after a rename.
@@ -39,13 +40,9 @@ const TABLE_ID_SUB_BLOCKS = ['manualTableId', 'tableSelector', 'tableId'] as con
 
 const TABLE_BLOCK_TYPE = 'table_v2'
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === 'object' && value !== null && !Array.isArray(value)
-}
-
 function subBlockValue(subBlocks: SubBlockValues, id: string): unknown {
   const entry = subBlocks[id]
-  return isRecord(entry) ? entry.value : undefined
+  return isRecordLike(entry) ? entry.value : undefined
 }
 
 /** The raw text of a sub-block, or `undefined` when it holds nothing. */
@@ -70,7 +67,7 @@ export function isTableBlockBoundTo(subBlocks: SubBlockValues, tableId: string):
 
 /** Every column a row payload names: the keys of the `{ column: value }` object. */
 function collectDataFieldNames(root: unknown): string[] {
-  return isRecord(root) ? Object.keys(root) : []
+  return isRecordLike(root) ? Object.keys(root) : []
 }
 
 const FIELD_COLLECTORS: Record<TableBlockColumnReferenceField, (root: unknown) => string[]> = {
@@ -147,7 +144,7 @@ export async function findUnmigratedTableBlockReferences(input: {
 
   const unmigrated: UnmigratedTableBlockReference[] = []
   for (const row of rows) {
-    if (!isRecord(row.subBlocks)) continue
+    if (!isRecordLike(row.subBlocks)) continue
     const subBlocks = row.subBlocks as SubBlockValues
     if (!isTableBlockBoundTo(subBlocks, input.tableId)) continue
     const fields = collectTableBlockColumnReferences(subBlocks, input.columnName)

apps/sim/lib/table/import.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 /**
  * Shared CSV import helpers for user-defined tables.
  *
@@ -760,7 +761,7 @@ export function parseJsonRows(buffer: Buffer | string): {
   }
   const headerSet = new Set<string>()
   for (const row of parsed) {
-    if (typeof row !== 'object' || row === null || Array.isArray(row)) {
+    if (!isRecordLike(row)) {
       throw new OrchestrationError(
         'validation',
         'Each element in the JSON array must be a plain object'

apps/sim/lib/table/orchestration/import-resource.ts

@@ -4,6 +4,7 @@ import { tableJobs } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
 import { generateId } from '@sim/utils/id'
+import { isRecordLike } from '@sim/utils/object'
 import { and, eq } from 'drizzle-orm'
 import {
   type V2CreateTableImportBody,
@@ -527,7 +528,7 @@ function parseRejectionSummary(payload: unknown): TableImportRejectionSummary {
     cellsRejected: 0,
     rejectedSamples: [],
   }
-  if (!payload || typeof payload !== 'object' || Array.isArray(payload)) return empty
+  if (!isRecordLike(payload)) return empty
   const candidate = payload as Partial<TableImportRejectionSummary>
   const samples = Array.isArray(candidate.rejectedSamples) ? candidate.rejectedSamples : []
   return {
@@ -548,7 +549,7 @@ function parseRejectionSummary(payload: unknown): TableImportRejectionSummary {
  * handed unchanged to a `.strict()` schema and turn a read of the import into a 500.
  */
 function parseRejectedSample(value: unknown): CsvSkippedRecord | null {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return null
+  if (!isRecordLike(value)) return null
   const candidate = value as Partial<CsvSkippedRecord>
   if (typeof candidate.code !== 'string' || typeof candidate.message !== 'string') return null
   const line =
@@ -570,7 +571,7 @@ function parseRejectionCount(value: unknown): number {
  * an ordinary "not this resource" answer rather than an error condition.
  */
 function parseImportJobPayload(payload: unknown): ParsedTableImportPayload | null {
-  if (!payload || typeof payload !== 'object' || Array.isArray(payload)) return null
+  if (!isRecordLike(payload)) return null
   const candidate = payload as Partial<TableImportJobPayload>
   if (
     candidate.kind !== 'table_import' ||

apps/sim/lib/table/query-builder/converters.ts

@@ -251,7 +251,7 @@ function parseScalar(value: string): JsonValue {
 }
 
 function parseFilterGroup(group: Filter): FilterRule[] {
-  if (!group || typeof group !== 'object' || Array.isArray(group)) return []
+  if (!isRecordLike(group)) return []
 
   const rules: FilterRule[] = []
 

apps/sim/lib/table/query-builder/field-names.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 /**
  * Column names an authored filter or sort names, read from untrusted JSON.
  *
@@ -8,10 +9,6 @@
  * these are advisory readers of persisted block state.
  */
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === 'object' && value !== null && !Array.isArray(value)
-}
-
 /**
  * Every `field` a predicate tree names, in document order: a bare
  * `{ field, op, value }` condition, or nested `{ all | any: [...] }` groups.
@@ -29,7 +26,7 @@ export function collectPredicateFieldNames(root: unknown): string[] {
       visitLater(node)
       continue
     }
-    if (!isRecord(node)) continue
+    if (!isRecordLike(node)) continue
     if (typeof node.field === 'string') names.push(node.field)
     if (Array.isArray(node.any)) visitLater(node.any)
     if (Array.isArray(node.all)) visitLater(node.all)
@@ -44,8 +41,8 @@ export function collectPredicateFieldNames(root: unknown): string[] {
 export function collectSortFieldNames(root: unknown): string[] {
   if (Array.isArray(root)) {
     return root.flatMap((entry) =>
-      isRecord(entry) && typeof entry.field === 'string' ? [entry.field] : []
+      isRecordLike(entry) && typeof entry.field === 'string' ? [entry.field] : []
     )
   }
-  return isRecord(root) ? Object.keys(root) : []
+  return isRecordLike(root) ? Object.keys(root) : []
 }

apps/sim/lib/table/rows/cursor.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 /**
  * Opaque pagination cursor for the v2 table-query surface.
  *
@@ -235,7 +236,7 @@ export function decodeCursor(token: string): {
   } catch {
     invalidCursor()
   }
-  if (typeof payload !== 'object' || payload === null || Array.isArray(payload)) {
+  if (!isRecordLike(payload)) {
     invalidCursor()
   }
 

apps/sim/lib/table/rows/run-state.ts

@@ -1,3 +1,4 @@
+import { isRecordLike } from '@sim/utils/object'
 /**
  * Shared normalizers for the `tableRowExecutions` sidecar columns that are
  * stored looser than every consumer declares them.
@@ -17,7 +18,7 @@
  * rather than publish an empty map.
  */
 export function normalizeBlockErrors(value: unknown): Record<string, string> | undefined {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return undefined
+  if (!isRecordLike(value)) return undefined
 
   const blockErrors: Record<string, string> = {}
   for (const [blockId, error] of Object.entries(value)) {

apps/sim/lib/table/rows/secret-provenance.ts

@@ -6,6 +6,7 @@ import {
   userTableRows,
 } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
+import { isRecordLike } from '@sim/utils/object'
 import { compareStrings } from '@sim/utils/string'
 import { and, asc, eq, gt, inArray, type SQL, sql } from 'drizzle-orm'
 import { SecretProvenanceBudget } from '@/lib/execution/provenance-budget'
@@ -127,7 +128,7 @@ function serializedBytes(value: unknown): number {
 }
 
 function isStoredEntry(value: unknown): value is StoredTableRowSecretProvenanceEntry {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return false
+  if (!isRecordLike(value)) return false
   const record = value as Record<string, unknown>
   if (
     Reflect.ownKeys(record).some((key) => typeof key !== 'string' || !STORED_ENTRY_KEYS.has(key))