improvement(cli): sim credentials providers lists providers

Author: waleedlatif1

packages/sim-cli/src/contract/commands.ts

@@ -1461,6 +1461,10 @@ export const CLI_CONTRACT: CliContract = {
   // `serviceId`, while `credentials create` matches a service-account provider
   // on `providerId`. Each is empty on the kind of row that does not use it.
   listCredentialProviders: {
+    // The providers group holds nothing but this list, so naming the group lists them.
+    command: 'credentials providers',
+    groupDefault: true,
+    variants: [{ command: 'credentials providers list' }],
     columns: [
       { header: 'type' },
       { header: 'service', path: 'serviceId' },

packages/sim-cli/src/contract/types.ts

@@ -248,7 +248,7 @@ export interface CommandSpec {
    * `<resource> [sub-resource] <verb>` name.
    */
   command?: string
-  /** Run this operation when its top-level group is invoked without a subcommand. */
+  /** Run this operation when its group (`command`, top-level or nested) is invoked without a subcommand. */
   groupDefault?: boolean
   /** Alternate leaf command names, such as `ls` for `list`. */
   aliases?: readonly string[]

packages/sim-cli/src/runtime/build.ts

@@ -498,8 +498,10 @@ export function buildGeneratedCommands(): Command[] {
     const segments = spec.command ? spec.command.split(' ') : deriveCommandPath(operation)
     if (spec.groupDefault) {
       const [groupName, ...rest] = segments
-      const group = groupFor(groups, groupName)
-      if (rest.length > 0) throw new Error(`${operation} groupDefault must name a command group`)
+      const group = rest.reduce(
+        (parent, segment) => nestedGroup(parent, segment),
+        groupFor(groups, groupName)
+      )
       const pathPositionals = operationSpec.pathParams.filter(
         (param) => !spec.pathFlags?.[param] && !isProfileWorkspacePath(spec, param)
       )

packages/sim-cli/src/runtime/group-default.test.ts

@@ -0,0 +1,33 @@
+import { describe, expect, it } from 'vitest'
+import { runEmbeddedCli } from '../embed'
+
+const identity = { endpoint: 'https://sim.test', apiKey: 'fixture', workspaceId: 'workspace' }
+
+/** Runs one embedded invocation, recording the path of each request it sends. */
+async function run(argv: string[]) {
+  const paths: string[] = []
+  const result = await runEmbeddedCli(argv, {
+    ...identity,
+    transport: async (url) => {
+      paths.push(new URL(String(url)).pathname)
+      return Response.json({ data: [] })
+    },
+  })
+  return { ...result, paths }
+}
+
+describe('a nested group that defaults to its list', () => {
+  it('lists credential providers when the providers group is named, as list does', async () => {
+    const bare = await run(['credentials', 'providers'])
+    const listed = await run(['credentials', 'providers', 'list'])
+    expect(bare.exitCode).toBe(0)
+    expect(bare.paths).toEqual(['/api/v2/credentials/providers'])
+    expect(listed.paths).toEqual(bare.paths)
+  })
+
+  it('leaves a group without a default printing its usage, sending nothing', async () => {
+    const group = await run(['credentials'])
+    expect(group.paths).toEqual([])
+    expect(group.stderr + group.stdout).toContain('Usage: sim credentials')
+  })
+})