chore(cleanup): consolidate shared helpers and restore TSDoc on moved codec and subflow helpers

Author: waleedlatif1

apps/docs/components/ui/block-info-card.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import type * as React from 'react'
+import { isLightTileColor } from '@sim/workflow-renderer/tile-icon-color'
 import { blockTypeToIconMap } from '@/components/ui/icon-mapping'
 
 interface BlockInfoCardProps {
@@ -9,33 +10,6 @@ interface BlockInfoCardProps {
   icon?: React.ComponentType<{ className?: string }>
 }
 
-/**
- * Brightness above which a tile background is "clearly light" and a white
- * foreground icon would wash out. Mirrors apps/sim's LIGHT_TILE_THRESHOLD
- * (blocks/icon-color.ts) so monochrome `currentColor` icons (e.g. Daytona,
- * Notion) stay legible on white/pale tiles instead of white-on-white.
- */
-const LIGHT_TILE_THRESHOLD = 0.75
-
-function isLightTileColor(color: string): boolean {
-  const hex = color.trim().replace('#', '').toLowerCase()
-  let r: number
-  let g: number
-  let b: number
-  if (/^[0-9a-f]{3}$/.test(hex)) {
-    r = Number.parseInt(hex[0] + hex[0], 16)
-    g = Number.parseInt(hex[1] + hex[1], 16)
-    b = Number.parseInt(hex[2] + hex[2], 16)
-  } else if (/^[0-9a-f]{6}$/.test(hex)) {
-    r = Number.parseInt(hex.slice(0, 2), 16)
-    g = Number.parseInt(hex.slice(2, 4), 16)
-    b = Number.parseInt(hex.slice(4, 6), 16)
-  } else {
-    return false
-  }
-  return (0.299 * r + 0.587 * g + 0.114 * b) / 255 > LIGHT_TILE_THRESHOLD
-}
-
 export function BlockInfoCard({
   type,
   color,

apps/sim/app/api/v1/auth.ts

@@ -1,5 +1,8 @@
-import type { PersonalApiKeyPrincipal, WorkspaceApiKeyPrincipal } from '@sim/auth/principal'
-import { ANONYMOUS_USER_ID } from '@sim/auth/principal'
+import {
+  ANONYMOUS_USER_ID,
+  type PersonalApiKeyPrincipal,
+  type WorkspaceApiKeyPrincipal,
+} from '@sim/auth/principal'
 import { createLogger } from '@sim/logger'
 import type { NextRequest } from 'next/server'
 import { authenticateApiKeyFromHeader, updateApiKeyLastUsed } from '@/lib/api-key/service'

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/note-block/note-block.tsx

@@ -13,6 +13,7 @@ import {
   type NoteSearchHighlight,
   type NoteSearchRange,
 } from '@sim/workflow-renderer'
+import { isWorkflowBlockProtected } from '@sim/workflow-types/workflow'
 import { type Node, type NodeProps, useReactFlow } from '@xyflow/react'
 import dynamic from 'next/dynamic'
 import { useShallow } from 'zustand/react/shallow'
@@ -28,7 +29,6 @@ import { useNoteImageUpload } from '@/app/workspace/[workspaceId]/w/[workflowId]
 import type { WorkflowBlockProps } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/types'
 import { useBlockVisual } from '@/app/workspace/[workspaceId]/w/[workflowId]/hooks'
 import { useBlockDimensions } from '@/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-block-dimensions'
-import { isBlockProtected } from '@/app/workspace/[workspaceId]/w/[workflowId]/utils'
 import { useCollaborativeWorkflow } from '@/hooks/use-collaborative-workflow'
 import { useIsCurrentWorkflowExecuting } from '@/stores/execution'
 import { usePanelEditorSearchStore, usePanelEditorStore } from '@/stores/panel'
@@ -109,7 +109,7 @@ export const NoteBlock = memo(function NoteBlock({ id, data, selected }: NodePro
   const isWorkflowRunning = useIsCurrentWorkflowExecuting()
   const canEditWorkflow = userPermissions.canEdit && !data.isWorkflowLocked
   const isProtected = useWorkflowStore(
-    useCallback((state) => isBlockProtected(id, state.blocks), [id])
+    useCallback((state) => isWorkflowBlockProtected(id, state.blocks), [id])
   )
   const clearCurrentBlock = usePanelEditorStore((state) => state.clearCurrentBlock)
   /* Flattened to primitives under a shallow compare, never held as the target

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx

@@ -34,6 +34,16 @@ import {
   OPERATION_SUBBLOCK_ID,
 } from '@/lib/permission-groups/operation-access'
 import { resolveStoredToolName } from '@/lib/workflows/subblocks/display'
+import {
+  buildCanonicalIndex,
+  type CanonicalIndex,
+  type CanonicalModeOverrides,
+  isCanonicalPair,
+  reindexToolCanonicalModes,
+  resolveCanonicalMode,
+  resolveDependencyValue,
+  scopeCanonicalModesForTool,
+} from '@/lib/workflows/subblocks/visibility'
 import { buildToolSubBlockId } from '@/lib/workflows/tool-input/synthetic-subblocks'
 import {
   buildAgentToolUsageControlCanonicalKey,
@@ -104,16 +114,6 @@ import {
   isUserFacingToolParam,
   type SubBlocksForToolInput,
 } from '@/tools/params'
-import {
-  buildCanonicalIndex,
-  type CanonicalIndex,
-  type CanonicalModeOverrides,
-  isCanonicalPair,
-  reindexToolCanonicalModes,
-  resolveCanonicalMode,
-  resolveDependencyValue,
-  scopeCanonicalModesForTool,
-} from '@/tools/params-resolver'
 
 const logger = createLogger('ToolInput')
 

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx

@@ -12,7 +12,11 @@ import {
   SquareArrowUpRight,
   Unlock,
 } from '@sim/emcn/icons'
-import type { BlockRetryConfig } from '@sim/workflow-types/workflow'
+import {
+  type BlockRetryConfig,
+  isWorkflowBlockAncestorLocked,
+  isWorkflowBlockProtected,
+} from '@sim/workflow-types/workflow'
 import { isEqual } from 'es-toolkit'
 import { useParams } from 'next/navigation'
 import { usePostHog } from 'posthog-js/react'
@@ -50,10 +54,6 @@ import { LoopTool } from '@/app/workspace/[workspaceId]/w/[workflowId]/component
 import { ParallelTool } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/subflows/parallel/parallel-config'
 import { getSubBlockStableKey } from '@/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/utils'
 import { useCurrentWorkflow } from '@/app/workspace/[workspaceId]/w/[workflowId]/hooks'
-import {
-  isAncestorProtected,
-  isBlockProtected,
-} from '@/app/workspace/[workspaceId]/w/[workflowId]/utils/block-protection-utils'
 import { PreviewWorkflow } from '@/app/workspace/[workspaceId]/w/components/preview'
 import { BlockTile } from '@/blocks/block-tile'
 import { getBlock } from '@/blocks/registry'
@@ -138,8 +138,10 @@ export function Editor() {
   // Check if block is locked (or inside a locked ancestor) and compute edit permission
   // Locked blocks cannot be edited by anyone (admins can only lock/unlock)
   const blocks = useWorkflowStore((state) => state.blocks)
-  const isLocked = currentBlockId ? isBlockProtected(currentBlockId, blocks) : false
-  const isAncestorLocked = currentBlockId ? isAncestorProtected(currentBlockId, blocks) : false
+  const isLocked = currentBlockId ? isWorkflowBlockProtected(currentBlockId, blocks) : false
+  const isAncestorLocked = currentBlockId
+    ? isWorkflowBlockAncestorLocked(currentBlockId, blocks)
+    : false
   const canEditBlock = userPermissions.canEdit && !workflowLocked && !isLocked
 
   const { advancedMode, triggerMode } = useEditorBlockProperties(
@@ -332,7 +334,8 @@ export function Editor() {
     const block = blocks[blockId]
     if (!block) return
 
-    if (!userPermissions.canEdit || workflowLocked || isBlockProtected(blockId, blocks)) return
+    if (!userPermissions.canEdit || workflowLocked || isWorkflowBlockProtected(blockId, blocks))
+      return
 
     renamingBlockIdRef.current = blockId
     setEditedName(block.name || '')

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/block-protection-utils.ts

@@ -1,7 +1,5 @@
+import { isWorkflowBlockProtected } from '@sim/workflow-types/workflow'
 import type { BlockState } from '@/stores/workflows/workflow/types'
-import { isAncestorProtected, isBlockProtected } from '@/stores/workflows/workflow/utils'
-
-export { isAncestorProtected, isBlockProtected }
 
 /**
  * Result of filtering protected blocks from a deletion operation
@@ -28,7 +26,7 @@ export function isEdgeProtected(
   edge: { source: string; target: string },
   blocks: Record<string, BlockState>
 ): boolean {
-  return isBlockProtected(edge.target, blocks)
+  return isWorkflowBlockProtected(edge.target, blocks)
 }
 
 /**
@@ -43,7 +41,7 @@ export function filterProtectedBlocks(
   blockIds: string[],
   blocks: Record<string, BlockState>
 ): FilterProtectedBlocksResult {
-  const protectedIds = blockIds.filter((id) => isBlockProtected(id, blocks))
+  const protectedIds = blockIds.filter((id) => isWorkflowBlockProtected(id, blocks))
   const deletableIds = blockIds.filter((id) => !protectedIds.includes(id))
 
   return {

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import React, { lazy, Suspense, useCallback, useEffect, useMemo, useRef, useState } from 'react'
+import { isWorkflowBlockProtected } from '@sim/workflow-types/workflow'
 import {
   applyNodeChanges,
   ConnectionLineType,
@@ -102,7 +103,6 @@ import {
   getNodeSelectionContextId,
   getRunFromBlockDependencyState,
   getWorkflowLockToggleIds,
-  isBlockProtected,
   isEdgeProtected,
   isInEditableElement,
   isPositionalTriggerBlock,
@@ -2890,7 +2890,7 @@ const WorkflowContent = React.memo(
             className: block.data?.parentId ? SUBFLOW_CHILD_NODE_CLASS : undefined,
             extent: block.data?.extent || undefined,
             dragHandle: '.workflow-drag-handle',
-            draggable: !workflowReadOnly && !isBlockProtected(block.id, blocks),
+            draggable: !workflowReadOnly && !isWorkflowBlockProtected(block.id, blocks),
             zIndex: depth,
             data: {
               ...block.data,
@@ -2937,7 +2937,7 @@ const WorkflowContent = React.memo(
           parentId,
           className: parentId ? SUBFLOW_CHILD_NODE_CLASS : undefined,
           dragHandle,
-          draggable: !workflowReadOnly && !isBlockProtected(block.id, blocks),
+          draggable: !workflowReadOnly && !isWorkflowBlockProtected(block.id, blocks),
           zIndex: cardZIndex,
           extent: (() => {
             // Clamp children to subflow body (exclude header)

apps/sim/blocks/icon-color.ts

@@ -1,8 +1,9 @@
 /**
- * Contrast helpers for brand tiles. Pure colour maths — deliberately free of any
- * `@/blocks/registry` import so the public landing `/integrations` page can use
- * these without pulling 282 block configs and the tool registry into its bundle.
- * Registry-backed icon styling lives in `@/blocks/brand-icon`.
+ * Tailwind classes for brand-tile icons, built on the shared
+ * `isLightTileColor` predicate. Deliberately free of any `@/blocks/registry`
+ * import so the public landing `/integrations` page can use it without pulling
+ * every block config and the tool registry into its bundle. Registry-backed
+ * icon styling lives in `@/blocks/brand-icon`.
  */
 import { isLightTileColor } from '@sim/workflow-renderer/tile-icon-color'
 

apps/sim/blocks/pi-api-key-condition.test.ts

@@ -2,7 +2,7 @@ import { resetEnvFlagsMock, setEnvFlags } from '@sim/testing'
 import { afterAll, afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { evaluateSubBlockCondition } from '@/lib/workflows/subblocks/visibility'
 import { PiBlock } from '@/blocks/blocks/pi'
-import { getHostedModels } from '@/providers/utils'
+import { getHostedModels } from '@/providers/models'
 
 const apiKeySubBlock = PiBlock.subBlocks.find((subBlock) => subBlock.id === 'apiKey')
 const hostedModel = getHostedModels()[0]

apps/sim/ee/workspace-forking/components/fork-sync-detail-view/fork-sync-detail-view.tsx

@@ -6,6 +6,7 @@ import { ArrowLeft } from '@sim/emcn/icons'
 import { useQueryState } from 'nuqs'
 import { saveDiscardActions } from '@/components/settings/save-discard-actions'
 import type { SettingsAction } from '@/components/settings/settings-header'
+import { buildWebhookTriggerUrl } from '@/lib/webhooks/trigger-url'
 import { UnsavedChangesModal } from '@/app/workspace/[workspaceId]/components/credential-detail'
 import {
   forkSyncDirectionParam,
@@ -19,7 +20,6 @@ import {
   useForkSync,
 } from '@/ee/workspace-forking/components/fork-sync/use-fork-sync'
 import type { ForkDirection } from '@/ee/workspace-forking/hooks/workspace-fork'
-import { buildWebhookTriggerUrl } from '@/triggers/webhook-url'
 
 interface ForkSyncDetailViewProps {
   title: string