|
| 1 | +/** |
| 2 | + * Tests for knowledge base tag definitions API route |
| 3 | + * |
| 4 | + * @vitest-environment node |
| 5 | + */ |
| 6 | +import { |
| 7 | + createMockRequest, |
| 8 | + hybridAuthMockFns, |
| 9 | + knowledgeApiUtilsMock, |
| 10 | + knowledgeApiUtilsMockFns, |
| 11 | +} from '@sim/testing' |
| 12 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 13 | + |
| 14 | +const { mockGetTagDefinitions, mockCreateTagDefinition } = vi.hoisted(() => ({ |
| 15 | + mockGetTagDefinitions: vi.fn(), |
| 16 | + mockCreateTagDefinition: vi.fn(), |
| 17 | +})) |
| 18 | + |
| 19 | +vi.mock('@/lib/knowledge/tags/service', () => ({ |
| 20 | + getTagDefinitions: mockGetTagDefinitions, |
| 21 | + createTagDefinition: mockCreateTagDefinition, |
| 22 | +})) |
| 23 | + |
| 24 | +vi.mock('@/app/api/knowledge/utils', () => knowledgeApiUtilsMock) |
| 25 | + |
| 26 | +import { GET, POST } from '@/app/api/knowledge/[id]/tag-definitions/route' |
| 27 | + |
| 28 | +const KB_ID = 'kb-victim' |
| 29 | +const TAG_DEFINITIONS = [ |
| 30 | + { id: 'tag-def-1', tagSlot: 'tag1', displayName: 'Client Name', fieldType: 'text' }, |
| 31 | +] |
| 32 | +const CREATE_BODY = { tagSlot: 'tag1', displayName: 'Injected', fieldType: 'text' } |
| 33 | + |
| 34 | +const params = () => ({ params: Promise.resolve({ id: KB_ID }) }) |
| 35 | + |
| 36 | +const { mockCheckKnowledgeBaseAccess, mockCheckKnowledgeBaseWriteAccess } = knowledgeApiUtilsMockFns |
| 37 | + |
| 38 | +/** Stubs the auth result the route sees. Omit `userId` for a JWT with no acting user. */ |
| 39 | +function authenticateAs(userId?: string, authType = 'internal_jwt') { |
| 40 | + hybridAuthMockFns.mockCheckSessionOrInternalAuth.mockResolvedValue({ |
| 41 | + success: true, |
| 42 | + authType, |
| 43 | + ...(userId ? { userId } : {}), |
| 44 | + }) |
| 45 | +} |
| 46 | + |
| 47 | +const granted = { hasAccess: true, knowledgeBase: { id: KB_ID, userId: 'user-1' } } |
| 48 | + |
| 49 | +describe('Knowledge Base Tag Definitions API Route', () => { |
| 50 | + beforeEach(() => { |
| 51 | + vi.clearAllMocks() |
| 52 | + mockGetTagDefinitions.mockResolvedValue(TAG_DEFINITIONS) |
| 53 | + mockCreateTagDefinition.mockResolvedValue({ id: 'tag-def-new' }) |
| 54 | + }) |
| 55 | + |
| 56 | + describe('GET /api/knowledge/[id]/tag-definitions', () => { |
| 57 | + it('returns tag definitions to a caller with read access', async () => { |
| 58 | + authenticateAs('user-1', 'session') |
| 59 | + mockCheckKnowledgeBaseAccess.mockResolvedValue(granted) |
| 60 | + |
| 61 | + const response = await GET(createMockRequest('GET'), params()) |
| 62 | + |
| 63 | + expect(response.status).toBe(200) |
| 64 | + await expect(response.json()).resolves.toEqual({ success: true, data: TAG_DEFINITIONS }) |
| 65 | + }) |
| 66 | + |
| 67 | + it('gates reads on read access, not write access', async () => { |
| 68 | + authenticateAs('user-1', 'session') |
| 69 | + mockCheckKnowledgeBaseAccess.mockResolvedValue(granted) |
| 70 | + |
| 71 | + await GET(createMockRequest('GET'), params()) |
| 72 | + |
| 73 | + expect(mockCheckKnowledgeBaseAccess).toHaveBeenCalledWith(KB_ID, 'user-1') |
| 74 | + expect(mockCheckKnowledgeBaseWriteAccess).not.toHaveBeenCalled() |
| 75 | + }) |
| 76 | + |
| 77 | + it('authorizes internal JWT callers instead of trusting them', async () => { |
| 78 | + authenticateAs('attacker-1') |
| 79 | + mockCheckKnowledgeBaseAccess.mockResolvedValue({ hasAccess: false }) |
| 80 | + |
| 81 | + const response = await GET(createMockRequest('GET'), params()) |
| 82 | + |
| 83 | + expect(response.status).toBe(403) |
| 84 | + expect(mockCheckKnowledgeBaseAccess).toHaveBeenCalledWith(KB_ID, 'attacker-1') |
| 85 | + expect(mockGetTagDefinitions).not.toHaveBeenCalled() |
| 86 | + }) |
| 87 | + |
| 88 | + it('returns 404 for an unknown knowledge base', async () => { |
| 89 | + authenticateAs('attacker-1') |
| 90 | + mockCheckKnowledgeBaseAccess.mockResolvedValue({ hasAccess: false, notFound: true }) |
| 91 | + |
| 92 | + const response = await GET(createMockRequest('GET'), params()) |
| 93 | + |
| 94 | + expect(response.status).toBe(404) |
| 95 | + expect(mockGetTagDefinitions).not.toHaveBeenCalled() |
| 96 | + }) |
| 97 | + |
| 98 | + it('rejects a JWT that carries no acting user', async () => { |
| 99 | + authenticateAs() |
| 100 | + |
| 101 | + const response = await GET(createMockRequest('GET'), params()) |
| 102 | + |
| 103 | + expect(response.status).toBe(401) |
| 104 | + expect(mockCheckKnowledgeBaseAccess).not.toHaveBeenCalled() |
| 105 | + expect(mockGetTagDefinitions).not.toHaveBeenCalled() |
| 106 | + }) |
| 107 | + }) |
| 108 | + |
| 109 | + describe('POST /api/knowledge/[id]/tag-definitions', () => { |
| 110 | + it('creates a tag definition for a caller with write access', async () => { |
| 111 | + authenticateAs('user-1', 'session') |
| 112 | + mockCheckKnowledgeBaseWriteAccess.mockResolvedValue(granted) |
| 113 | + |
| 114 | + const response = await POST(createMockRequest('POST', CREATE_BODY), params()) |
| 115 | + |
| 116 | + expect(response.status).toBe(200) |
| 117 | + expect(mockCreateTagDefinition).toHaveBeenCalledWith( |
| 118 | + expect.objectContaining({ knowledgeBaseId: KB_ID, tagSlot: 'tag1' }), |
| 119 | + expect.any(String) |
| 120 | + ) |
| 121 | + }) |
| 122 | + |
| 123 | + it('authorizes internal JWT callers instead of trusting them', async () => { |
| 124 | + authenticateAs('attacker-1') |
| 125 | + mockCheckKnowledgeBaseWriteAccess.mockResolvedValue({ hasAccess: false }) |
| 126 | + |
| 127 | + const response = await POST(createMockRequest('POST', CREATE_BODY), params()) |
| 128 | + |
| 129 | + expect(response.status).toBe(403) |
| 130 | + expect(mockCheckKnowledgeBaseWriteAccess).toHaveBeenCalledWith(KB_ID, 'attacker-1') |
| 131 | + expect(mockCreateTagDefinition).not.toHaveBeenCalled() |
| 132 | + }) |
| 133 | + |
| 134 | + it('rejects a JWT that carries no acting user', async () => { |
| 135 | + authenticateAs() |
| 136 | + |
| 137 | + const response = await POST(createMockRequest('POST', CREATE_BODY), params()) |
| 138 | + |
| 139 | + expect(response.status).toBe(401) |
| 140 | + expect(mockCheckKnowledgeBaseWriteAccess).not.toHaveBeenCalled() |
| 141 | + expect(mockCreateTagDefinition).not.toHaveBeenCalled() |
| 142 | + }) |
| 143 | + }) |
| 144 | +}) |
0 commit comments