fix(scripts): skip deleted table workflows

Author: TheodoreSpeaks

apps/sim/scripts/backfill-table-workflow-deployments.test.ts

@@ -1,6 +1,7 @@
 /**
  * @vitest-environment node
  */
+import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockLoadRuntimeSecrets, mockPerformFullDeploy } = vi.hoisted(() => ({
@@ -20,6 +21,7 @@ import {
   backfillTableWorkflowDeployments,
   deployTableWorkflow,
   parseTableWorkflowDeploymentBackfillArgs,
+  postgresTableWorkflowDeploymentStore,
   prepareTableWorkflowDeploymentBackfillEnvironment,
   TABLE_WORKFLOW_DEPLOYMENT_BATCH_SIZE,
   type TableWorkflowDeploymentCandidate,
@@ -32,6 +34,10 @@ const ORIGINAL_ENV = {
   SIM_ENV_SECRET_ID: process.env.SIM_ENV_SECRET_ID,
 }
 
+interface MockSqlQuery {
+  toSQL(): { sql: string }
+}
+
 function restoreEnvironmentVariable(key: keyof typeof ORIGINAL_ENV): void {
   const value = ORIGINAL_ENV[key]
   if (value === undefined) {
@@ -63,6 +69,7 @@ function store(
 describe('backfillTableWorkflowDeployments', () => {
   beforeEach(() => {
     vi.clearAllMocks()
+    resetDbChainMock()
   })
 
   afterEach(() => {
@@ -112,6 +119,17 @@ describe('backfillTableWorkflowDeployments', () => {
     expect(mockLoadRuntimeSecrets).not.toHaveBeenCalled()
   })
 
+  it('silently excludes missing and archived workflow references from integrity checks', async () => {
+    await postgresTableWorkflowDeploymentStore.assertIntegrity()
+
+    const referenceQuery = dbChainMockFns.execute.mock.calls[2]?.[0] as MockSqlQuery
+    const queryText = referenceQuery.toSQL().sql
+    expect(queryText).toContain('INNER JOIN workflow')
+    expect(queryText).toContain('workflow.archived_at IS NULL')
+    expect(queryText).not.toContain('LEFT JOIN workflow')
+    expect(queryText).not.toContain('workflow.id IS NULL')
+  })
+
   it('deploys bounded keyset pages and verifies the final desired state', async () => {
     const listCandidates = vi
       .fn<TableWorkflowDeploymentStore['listCandidates']>()

apps/sim/scripts/backfill-table-workflow-deployments.ts

@@ -73,7 +73,7 @@ interface InvalidWorkflowReferenceRow extends Record<string, unknown> {
   table_id: string
   table_workspace_id: string
   workflow_id: string
-  workflow_workspace_id: string | null
+  workflow_workspace_id: string
 }
 
 interface MultipleActiveVersionsRow extends Record<string, unknown> {
@@ -212,22 +212,16 @@ async function assertTableWorkflowIntegrity(): Promise<void> {
       table_workflow_groups.workflow_id,
       workflow.workspace_id AS workflow_workspace_id
     FROM table_workflow_groups
-    LEFT JOIN workflow ON workflow.id = table_workflow_groups.workflow_id
+    INNER JOIN workflow ON workflow.id = table_workflow_groups.workflow_id
+      AND workflow.archived_at IS NULL
     WHERE table_workflow_groups.workflow_id <> ''
-      AND (
-        workflow.id IS NULL
-        OR (
-          workflow.archived_at IS NULL
-          AND workflow.workspace_id IS DISTINCT FROM table_workflow_groups.table_workspace_id
-        )
-      )
+      AND workflow.workspace_id IS DISTINCT FROM table_workflow_groups.table_workspace_id
     LIMIT 1
   `)
   if (invalidReference) {
-    const workflowScope = invalidReference.workflow_workspace_id ?? 'missing'
     throw new Error(
       `Table ${invalidReference.table_id} in workspace ${invalidReference.table_workspace_id} ` +
-        `references workflow ${invalidReference.workflow_id} in workspace ${workflowScope}`
+        `references workflow ${invalidReference.workflow_id} in workspace ${invalidReference.workflow_workspace_id}`
     )
   }