fix(quickbooks): align webhook event selection

Author: Bill Leoutsakos

apps/sim/lib/copilot/vfs/serializers.test.ts

@@ -245,6 +245,20 @@ describe('entitlement-projected block schemas', () => {
 })
 
 describe('hosted-key VFS metadata', () => {
+  it('preserves multi-select dropdown behavior in block schemas', () => {
+    const block = {
+      type: 'events',
+      name: 'Events',
+      subBlocks: [{ id: 'eventTypes', type: 'dropdown', multiSelect: true }],
+      tools: { access: [] },
+      inputs: {},
+      outputs: {},
+    } as unknown as BlockConfig
+
+    const schema = JSON.parse(serializeBlockSchema(block))
+    expect(schema.subBlocks[0].multiSelect).toBe(true)
+  })
+
   it('indexes hosted and conditional-hosted operations for every configured service', () => {
     const metadata = JSON.parse(
       serializeApiKeyIntegrations(

apps/sim/lib/copilot/vfs/serializers.ts

@@ -598,6 +598,7 @@ function serializeSubBlock(sb: SubBlockConfig): Record<string, unknown> {
   if (sb.required === true) result.required = true
   if (sb.defaultValue !== undefined) result.defaultValue = sb.defaultValue
   if (sb.mode) result.mode = sb.mode
+  if (sb.multiSelect) result.multiSelect = true
   if (sb.canonicalParamId) result.canonicalParamId = sb.canonicalParamId
   if (sb.condition && typeof sb.condition !== 'function') result.condition = sb.condition
   // Copied, not aliased: these are the registry's own arrays, shared by every

apps/sim/lib/webhooks/providers/quickbooks.test.ts

@@ -2,7 +2,7 @@ import crypto from 'node:crypto'
 import { NextRequest } from 'next/server'
 import { describe, expect, it } from 'vitest'
 import { quickBooksHandler, verifyQuickBooksSignature } from '@/lib/webhooks/providers/quickbooks'
-import { isQuickBooksEventMatch } from '@/triggers/quickbooks/utils'
+import { isQuickBooksEventMatch, quickBooksEventTypesSubBlockId } from '@/triggers/quickbooks/utils'
 
 const event = {
   specversion: '1.0',
@@ -33,6 +33,28 @@ describe('QuickBooks webhook provider', () => {
     expect(isQuickBooksEventMatch('quickbooks_bill_events', event.type, ['updated'])).toBe(false)
   })
 
+  it('normalizes Intuit void events to the configured voided action', async () => {
+    for (const entity of ['invoice', 'payment']) {
+      const voidEvent = { ...event, type: `qbo.${entity}.void.v1` }
+      expect(
+        isQuickBooksEventMatch(`quickbooks_${entity}_events`, voidEvent.type, ['voided'])
+      ).toBe(true)
+
+      const result = await quickBooksHandler.formatInput!({
+        body: voidEvent,
+        webhook: {},
+        workflow: { id: 'workflow-1', userId: 'user-1' },
+        headers: {},
+        requestId: `request-${entity}`,
+      })
+      expect(result.input).toMatchObject({
+        eventType: `qbo.${entity}.void.v1`,
+        entityType: entity,
+        action: 'voided',
+      })
+    }
+  })
+
   it('formats only the common verified event fields', async () => {
     const result = await quickBooksHandler.formatInput!({
       body: event,
@@ -66,7 +88,7 @@ describe('QuickBooks webhook provider', () => {
       requestId: 'request-5',
       providerConfig: {
         triggerId: 'quickbooks_invoice_events',
-        eventTypes: ['updated'],
+        [quickBooksEventTypesSubBlockId('quickbooks_invoice_events')]: ['updated'],
       },
       webhook: {},
       workflow: {},

apps/sim/lib/webhooks/providers/quickbooks.ts

@@ -53,8 +53,14 @@ export const quickBooksHandler: WebhookProviderHandler = {
     const event = asRecord(body)
     const triggerId = typeof providerConfig.triggerId === 'string' ? providerConfig.triggerId : ''
     const eventType = typeof event?.type === 'string' ? event.type : ''
-    const { isQuickBooksEventMatch } = await import('@/triggers/quickbooks/utils')
-    return isQuickBooksEventMatch(triggerId, eventType, providerConfig.eventTypes)
+    const { isQuickBooksEventMatch, quickBooksEventTypesSubBlockId } = await import(
+      '@/triggers/quickbooks/utils'
+    )
+    return isQuickBooksEventMatch(
+      triggerId,
+      eventType,
+      providerConfig[quickBooksEventTypesSubBlockId(triggerId)]
+    )
   },
 
   async formatInput({ body }: FormatInputContext): Promise<FormatInputResult> {

apps/sim/lib/workflows/editing/validation.test.ts

@@ -286,6 +286,7 @@ import {
   collectUnresolvedReferences,
   preValidateCredentialInputs,
   validateInputsForBlock,
+  validateValueForSubBlockType,
   validateWorkflowSelectorIds,
 } from './validation'
 
@@ -303,6 +304,36 @@ describe('validateInputsForBlock', () => {
     mockValidateSelectorIds.mockResolvedValue({ valid: [], invalid: [] })
   })
 
+  it('validates every value in a multi-select dropdown array', () => {
+    const config = {
+      id: 'eventTypes',
+      type: 'dropdown' as const,
+      multiSelect: true,
+      options: [
+        { id: 'created', label: 'Created' },
+        { id: 'updated', label: 'Updated' },
+      ],
+    }
+    expect(
+      validateValueForSubBlockType(
+        config,
+        ['created', 'updated'],
+        'eventTypes',
+        'quickbooks',
+        'quickbooks-1'
+      ).valid
+    ).toBe(true)
+    expect(
+      validateValueForSubBlockType(
+        config,
+        ['created', 'deleted'],
+        'eventTypes',
+        'quickbooks',
+        'quickbooks-1'
+      ).valid
+    ).toBe(false)
+  })
+
   it('accepts condition-input arrays with arbitrary item ids', () => {
     const result = validateInputsForBlock(
       'condition',

apps/sim/lib/workflows/editing/validation.ts

@@ -390,7 +390,8 @@ export function validateValueForSubBlockType(
           : subBlockConfig.options
       if (options && Array.isArray(options)) {
         const validIds = options.map((opt) => opt.id)
-        if (!validIds.includes(value)) {
+        const values = subBlockConfig.multiSelect && Array.isArray(value) ? value : [value]
+        if (values.some((item) => !validIds.includes(item))) {
           return {
             valid: false,
             error: {

apps/sim/triggers/quickbooks/quickbooks.test.ts

@@ -4,6 +4,7 @@ import { getTrigger } from '@/triggers'
 import {
   isQuickBooksEventMatch,
   QUICKBOOKS_TRIGGER_DEFINITIONS,
+  quickBooksEventTypesSubBlockId,
   quickBooksTriggerOptions,
 } from '@/triggers/quickbooks/utils'
 
@@ -32,11 +33,14 @@ describe('QuickBooks triggers', () => {
     ).toHaveLength(1)
     for (const definition of QUICKBOOKS_TRIGGER_DEFINITIONS) {
       const trigger = getTrigger(definition.id)
-      const eventTypes = trigger.subBlocks.find((subBlock) => subBlock.id === 'eventTypes')
+      const eventTypes = trigger.subBlocks.find(
+        (subBlock) => subBlock.id === quickBooksEventTypesSubBlockId(definition.id)
+      )
       if (definition.id === 'quickbooks_preferences_updated') {
         expect(eventTypes).toBeUndefined()
       } else {
         expect(eventTypes?.options?.map((option) => option.id)).toEqual(definition.actions)
+        expect(eventTypes?.multiSelect).toBe(true)
       }
       const instructions = trigger.subBlocks.find((subBlock) =>
         subBlock.id.startsWith('triggerInstructions')
@@ -47,15 +51,22 @@ describe('QuickBooks triggers', () => {
       }
       expect(trigger.outputs).toEqual(getTrigger('quickbooks_invoice_events').outputs)
     }
+
+    const eventTypeIds = QuickBooksBlock.subBlocks
+      .map((subBlock) => subBlock.id)
+      .filter((id) => id.startsWith('eventTypes_quickbooks_'))
+    expect(eventTypeIds).toHaveLength(28)
+    expect(new Set(eventTypeIds).size).toBe(eventTypeIds.length)
   })
 
   it('matches all 101 supported combinations and rejects unsupported actions', () => {
     for (const definition of QUICKBOOKS_TRIGGER_DEFINITIONS) {
       for (const action of definition.actions) {
+        const providerAction = action === 'voided' ? 'void' : action
         expect(
           isQuickBooksEventMatch(
             definition.id,
-            `qbo.${definition.entity}.${action}.v1`,
+            `qbo.${definition.entity}.${providerAction}.v1`,
             definition.actions
           )
         ).toBe(true)

apps/sim/triggers/quickbooks/utils.ts

@@ -260,6 +260,10 @@ export const quickBooksTriggerOptions = QUICKBOOKS_TRIGGER_DEFINITIONS.map((defi
   group: definition.group,
 }))
 
+export function quickBooksEventTypesSubBlockId(triggerId: string): string {
+  return `eventTypes_${triggerId}`
+}
+
 export const QUICKBOOKS_WEBHOOK_HEADERS = {
   'Content-Type': 'application/json',
   'intuit-signature': '<base64-hmac-sha256>',
@@ -276,7 +280,8 @@ export function parseQuickBooksWebhookType(type: string): {
   entity: string
 } | null {
   const match = /^qbo\.([a-z]+)\.([a-z]+)\.v1$/.exec(type)
-  return match ? { entity: match[1], action: match[2] } : null
+  if (!match) return null
+  return { entity: match[1], action: match[2] === 'void' ? 'voided' : match[2] }
 }
 
 export function isQuickBooksEventMatch(
@@ -326,7 +331,7 @@ export function buildQuickBooksTriggerSubBlocks(triggerId: string): SubBlockConf
       condition: { field: 'selectedTriggerId', value: triggerId },
     },
     {
-      id: 'eventTypes',
+      id: quickBooksEventTypesSubBlockId(triggerId),
       title: 'Event Types',
       type: 'dropdown',
       multiSelect: true,