fix(search): finalize refusal stream contract and validation

Author: waleedlatif1

apps/sim/app/o/[organizationId]/integrations/live-member-integrations.test.tsx

@@ -19,7 +19,10 @@ vi.mock('@/hooks/queries/organization-secrets', () => ({
   useOrganizationSecretSource: () => ({ data: { source: null } }),
 }))
 vi.mock('@/hooks/queries/search-integrations', () => ({
-  useSearchIntegrations: () => ({ data: [{ connectorType: 'coda', approved: true }] }),
+  useSearchIntegrations: () => ({
+    data: [{ connectorType: 'coda', approved: true }],
+    isSuccess: true,
+  }),
 }))
 vi.mock('@/app/o/[organizationId]/providers/organization-provider', () => organizationProviderMock)
 vi.mock('@/app/o/[organizationId]/integrations/disconnect-account-menu', () => ({

apps/sim/lib/assistant-actions/tool-permissions.integration.ts

@@ -902,7 +902,8 @@ describe('Assistant action delivery through the durable executor', () => {
           ])
         )
         const resultEvent = events.find(
-          (event) => event.type === 'tool' && event.payload.phase === 'result'
+          (event) =>
+            event.type === 'tool' && 'phase' in event.payload && event.payload.phase === 'result'
         )
         expect(resultEvent?.payload).not.toHaveProperty('error')
       }

apps/sim/lib/credentials/managed-oauth.ts

@@ -374,10 +374,10 @@ export async function rejectManagedOAuthToken(input: {
 }
 
 async function resolveProviderTokenContext(
-  providerId: string,
+  providerId: string | null,
   token: ResolvedManagedOAuthToken
 ): Promise<ResolvedManagedOAuthToken> {
-  if (!isSalesforceOAuthProviderId(providerId)) return token
+  if (!providerId || !isSalesforceOAuthProviderId(providerId)) return token
   const instanceUrl = await fetchSalesforceInstanceUrl(providerId, token.accessToken)
   if (!instanceUrl)
     throw new ManagedOAuthCredentialError(

apps/sim/lib/mothership/request/tools/executor.test.ts

@@ -1151,10 +1151,6 @@ describe('watchdog completion provenance', () => {
 
     await failPendingToolCall(toolCall.id, context, execContext)
     const persisted = completeAsyncToolCall.mock.calls[0][0]
-    expect(persisted.result).toEqual({
-      __sealedClientToolCompletionV1: expect.any(String),
-      __sealedClientToolContextV1: expect.any(String),
-    })
     waitForToolConfirmation.mockResolvedValue({
       status: 'error',
       message: persisted.error,
@@ -1391,18 +1387,34 @@ describe('watchdog completion provenance', () => {
     expect(registry.isComplete()).toBe(true)
   })
 
-  it('retains structural failure compatibility when no provenance registry exists', async () => {
+  it('restores a trusted timeout when its writer had no provenance registry', async () => {
     const { toolCall, context } = createHungClient()
 
     await failPendingToolCall(toolCall.id, context, { userId: 'user-1' })
 
     expect(toolCall.status).toBe('error')
-    expect(completeAsyncToolCall).toHaveBeenCalledWith(
-      expect.objectContaining({
-        result: { error: expect.any(String), outcomeUnknown: true, doNotRetry: true },
-      })
-    )
-    expect(encryptSecret).not.toHaveBeenCalled()
+    const persisted = completeAsyncToolCall.mock.calls[0][0]
+    waitForToolConfirmation.mockResolvedValue({
+      status: 'error',
+      message: persisted.error,
+      data: persisted.result,
+    })
+    const completion = await waitForClientToolCompletion({
+      toolCallId: toolCall.id,
+      runId: context.runId,
+      userId: 'user-1',
+      timeoutMs: 1,
+      registry: new ResolvedSecretTraceRegistry(),
+    })
+    expect(completion).toEqual({
+      status: 'error',
+      message: expect.stringContaining('outcome is unknown'),
+      data: {
+        error: expect.stringContaining('never came back'),
+        outcomeUnknown: true,
+        doNotRetry: true,
+      },
+    })
   })
 
   it.each([

apps/sim/lib/mothership/request/tools/executor.ts

@@ -770,6 +770,8 @@ async function refuseUnstartedExecution(
         toolCallId: toolCall.id,
         toolName: toolCall.name,
         phase: MothershipStreamV1ToolPhase.result,
+        executor: MothershipStreamV1ToolExecutor.sim,
+        mode: MothershipStreamV1ToolMode.async,
         status: completion.status,
         success: completion.status === 'success',
         output: completion.data,

scripts/check-explicit-any.baseline.json

@@ -868,7 +868,6 @@
     "apps/sim/tools/salesforce/update_contact.ts": 1,
     "apps/sim/tools/salesforce/update_lead.ts": 1,
     "apps/sim/tools/salesforce/update_opportunity.ts": 1,
-    "apps/sim/tools/salesforce/update_task.ts": 1,
     "apps/sim/tools/salesforce/utils.ts": 9,
     "apps/sim/tools/sentry/events_get.ts": 1,
     "apps/sim/tools/sentry/events_list.ts": 2,

scripts/check-unused-exports.baseline.json

@@ -4240,7 +4240,6 @@
   "apps/sim/lib/core/storage/storage.ts#isDatabaseStorage",
   "apps/sim/lib/core/storage/storage.ts#isRedisStorage",
   "apps/sim/lib/core/storage/storage.ts#requireRedis",
-  "apps/sim/lib/core/utils/browser-storage.ts#BrowserStorage",
   "apps/sim/lib/core/utils/multipart.ts#MultipartFilePart",
   "apps/sim/lib/core/utils/response-format.ts#hasResponseFormatSelection",
   "apps/sim/lib/core/utils/smooth-bottom-chase.ts#CHASE_REST_GAP",