fix(auth): type the SSO token-auth selector against 1.7's config and the new test calls

Author: waleedlatif1

apps/sim/app/(auth)/oauth/sign-in/route.test.ts

@@ -63,7 +63,8 @@ describe('OAuth login bridge', () => {
     const response = await GET(
       request(
         'client_id=mcp-client&scope=api%3Aread&sim_resource=https%3A%2F%2Fsim.test%2Fapi%2Fmcp&sig=signed'
-      )
+      ),
+      { params: Promise.resolve({}) }
     )
     const { callback } = redirectParts(response)
 

apps/sim/app/api/auth/[...all]/route.test.ts

@@ -227,7 +227,7 @@ describe('auth catch-all route email OTP sign-in', () => {
       'http://localhost:3000/api/auth/sign-in/email-otp'
     )
 
-    expect((await POST(req)).status).toBe(404)
+    expect((await POST(req, { params: Promise.resolve({}) })).status).toBe(404)
     expect(handlerMocks.betterAuthPOST).not.toHaveBeenCalled()
   })
 })
@@ -242,7 +242,7 @@ describe('auth catch-all route legacy SAML ACS path', () => {
       body: form,
     })
 
-    const res = await POST(req)
+    const res = await POST(req, { params: Promise.resolve({}) })
 
     expect(res.status).toBe(302)
     const forwarded: Request = handlerMocks.betterAuthPOST.mock.calls[0][0]
@@ -260,7 +260,7 @@ describe('auth catch-all route legacy SAML ACS path', () => {
       headers: { cookie: 'session=1' },
     })
 
-    expect((await GET(req)).status).toBe(302)
+    expect((await GET(req, { params: Promise.resolve({}) })).status).toBe(302)
     const forwarded: Request = handlerMocks.betterAuthGET.mock.calls[0][0]
     expect(new URL(forwarded.url).pathname).toBe('/api/auth/sso/saml2/sp/acs/acme-saml')
     expect(forwarded.headers.get('cookie')).toBe('session=1')

apps/sim/app/api/auth/oauth2/authorize/route.test.ts

@@ -206,7 +206,7 @@ describe('OAuth2 authorize route', () => {
     expect(new URL(forwarded.url).searchParams.get('sim_resource')).toBe(`${BASE_URL}/api/mcp`)
   })
 
-  it.each([
+  it.each<Record<string, string>>([
     { sim_resource: `${BASE_URL}/api/mcp` },
     { dpop_jkt: 'a'.repeat(43), resource: `${BASE_URL}/api/mcp` },
   ])('refuses reserved or unsupported provider parameters: %o', async (extra) => {
@@ -219,7 +219,8 @@ describe('OAuth2 authorize route', () => {
         code_challenge: 'a'.repeat(43),
         code_challenge_method: 'S256',
         ...extra,
-      })
+      }),
+      { params: Promise.resolve({}) }
     )
     expect(response.status).toBe(400)
     expect(mocks.betterAuthGET).not.toHaveBeenCalled()

apps/sim/app/api/auth/oauth2/register/route.test.ts

@@ -110,7 +110,9 @@ describe('MCP public client registration', () => {
         { status: 201 }
       )
     )
-    const response = await POST(request({ ...client, scope: 'search:read offline_access' }))
+    const response = await POST(request({ ...client, scope: 'search:read offline_access' }), {
+      params: Promise.resolve({}),
+    })
     expect(response.status).toBe(201)
     expect(await response.json()).toMatchObject({ scope: 'search:read offline_access' })
     expect(mocks.markPublic).toHaveBeenCalledWith('client-1', ['search:read', 'offline_access'])

apps/sim/lib/auth/sso/application/provider-registration.ts

@@ -64,9 +64,9 @@ function trimTrailingSlashes(url: string): string {
  */
 function selectTokenEndpointAuthMethod(
   supportedMethods: unknown,
-  existing?: TokenEndpointAuthMethod
+  existing?: string
 ): TokenEndpointAuthMethod {
-  if (existing) return existing
+  if (existing === 'client_secret_basic' || existing === 'client_secret_post') return existing
   if (!Array.isArray(supportedMethods) || supportedMethods.length === 0) {
     return 'client_secret_post'
   }

apps/sim/lib/oauth/oauth.test.ts

@@ -52,11 +52,11 @@ describe('connector callbacks without an account link', () => {
   it('yields no profile when the OAuth state does not come from /link-social', async () => {
     mockGetOAuthState.mockResolvedValue({ callbackURL: '/' })
     const fetchMock = createMockFetch({ json: { account_id: 'account-123' } })
+    const getUserInfo = getBitbucketConnector().getUserInfo
+    if (!getUserInfo) throw new Error('Bitbucket connector must define getUserInfo')
 
     const profile = await withMockFetch(fetchMock, () =>
-      getBitbucketConnector().getUserInfo?.(
-        getOAuth2Tokens({ access_token: 'bitbucket_access_token' })
-      )
+      getUserInfo(getOAuth2Tokens({ access_token: 'bitbucket_access_token' }))
     )
 
     expect(profile).toBeNull()