fix(files): share one served-bytes predicate between the serve route and large downloads

Author: waleedlatif1

apps/sim/app/api/files/serve/[...path]/route.ts

@@ -30,18 +30,16 @@ import {
 import { resolveServableImageBytes } from '@/lib/uploads/server/image-derivative'
 import { resolveStoredFileContext } from '@/lib/uploads/server/metadata'
 import { MAX_BUFFERED_TRANSFER_BYTES } from '@/lib/uploads/shared/types'
-import {
-  inferContextFromKey,
-  needsRenderedArtifact,
-  resolveEffectiveMimeType,
-} from '@/lib/uploads/utils/file'
+import { inferContextFromKey, resolveEffectiveMimeType } from '@/lib/uploads/utils/file'
 import { internalWorkspaceFileServeAuth } from '@/lib/workspace-files/api'
 import { fetchAuthorizedServableWorkspaceFileBuffer } from '@/lib/workspace-files/application/fetch-servable-workspace-file-buffer'
 import { finishFileDelivery } from '@/lib/workspace-files/application/finish-file-delivery'
 import { readWorkspaceFileRecordByKey } from '@/lib/workspace-files/application/read-workspace-file-record-by-key'
 import { streamAuthorizedWorkspaceFile } from '@/lib/workspace-files/application/stream-authorized-workspace-file'
-import { isSimPageSource, SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { isSimPageSource } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { renderSimPageDocumentWithAssets } from '@/lib/workspace-files/page-document.server'
+import { servesStoredBytes } from '@/lib/workspace-files/stored-bytes'
 import { type KnowledgeFileAccess, verifyFileAccess } from '@/app/api/files/authorization'
 import {
   createConditionalFileResponse,
@@ -203,10 +201,10 @@ async function resolveTransformedBytes(params: {
  * Whether a request is answered with the stored object byte-for-byte, so its bytes can stream from
  * storage instead of being read whole and capped at the transfer ceiling.
  *
- * Every other answer is produced from the bytes and stays buffered: a Sim page renders, a generated
- * document compiles, and a `preview` may be a HEIC transcode — sniffed from the content, so no name
- * or type rules it out. What streams is exactly what {@link resolveServableBytes} and the
- * workspace resolver would have passed through unchanged.
+ * Every other answer is produced from the bytes and stays buffered: see {@link servesStoredBytes},
+ * plus a `preview`, which may be a HEIC transcode — sniffed from the content, so no name or type
+ * rules it out. What streams is exactly what {@link resolveServableBytes} and the workspace
+ * resolver would have passed through unchanged.
  */
 function servesStoredObject(
   filename: string,
@@ -215,12 +213,7 @@ function servesStoredObject(
 ): boolean {
   if (options.raw) return true
   if (options.preview) return false
-  if (recordedType === SIM_PAGE_CONTENT_TYPE || filename.toLowerCase().endsWith('.html')) {
-    return false
-  }
-  // A recorded type tells a finished upload from a generation source; without one, every
-  // document name may be a source.
-  return !needsRenderedArtifact(recordedType, filename)
+  return servesStoredBytes(recordedType, filename)
 }
 
 /**

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/text-editor.tsx

@@ -27,7 +27,8 @@ import {
 import type { FileDownloadSource } from '@/lib/uploads/client/download'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
 import { getFileExtension } from '@/lib/uploads/utils/file'
-import { isSimPageSource, SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { isSimPageSource } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { EditorContextMenu } from '@/app/workspace/[workspaceId]/files/components/file-viewer/editor-context-menu'
 import { FileSaveConflict } from '@/app/workspace/[workspaceId]/files/components/file-viewer/file-save-conflict'
 import type { PreviewMode } from '@/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer'

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -48,7 +48,7 @@ import {
   isFileBrowserSize,
   isFileBrowserType,
 } from '@/lib/workspace-files/browser'
-import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { FindBar } from '@/app/workspace/[workspaceId]/components/find-bar/find-bar'
 import { useFindShortcut } from '@/app/workspace/[workspaceId]/components/find-bar/use-find-shortcut'
 import type { MoveOptionNode } from '@/app/workspace/[workspaceId]/components/folders'

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/mothership-view.tsx

@@ -11,7 +11,7 @@ import {
 } from '@/lib/mothership/resources/types'
 import type { FileDownloadSource } from '@/lib/uploads/client/download'
 import { getFileExtension } from '@/lib/uploads/utils/file'
-import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import type { PreviewMode } from '@/app/workspace/[workspaceId]/files/components/file-viewer'
 import {
   isCsvStreamOnly,

apps/sim/lib/mothership/tools/server/files/edit-content.ts

@@ -21,8 +21,8 @@ import {
   HAND_WRITTEN_PAGE_MESSAGE,
   isHandWrittenCompiledPage,
   isSimPageSource,
-  SIM_PAGE_CONTENT_TYPE,
 } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { buildEmbeddedImageRefWarning } from './embedded-image-refs'
 import { waitForLatestFileIntent } from './intent-store'
 import { compileDocForWrite, getDocumentFormatInfo, inferContentType } from './workspace-file'

apps/sim/lib/projects/files/application/artifacts.ts

@@ -56,11 +56,8 @@ import {
   textExtractionUnsupportedError,
 } from '@/lib/workspace-files/application/read-workspace-file-text'
 import { fileOwnerCondition } from '@/lib/workspace-files/ownership-query'
-import {
-  isSimPageSource,
-  ProjectPageForeignEmbedError,
-  SIM_PAGE_CONTENT_TYPE,
-} from '@/lib/workspace-files/page-compile'
+import { isSimPageSource, ProjectPageForeignEmbedError } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { renderSimPageDocument } from '@/lib/workspace-files/page-document'
 import {
   collectSimPageFileReferences,

apps/sim/lib/projects/files/application/content.ts

@@ -43,7 +43,7 @@ import {
 import { parseWorkspaceFileRevision } from '@/lib/workspace-files/application/file-revision'
 import { resolveWorkspaceFileVersionWrite } from '@/lib/workspace-files/application/file-version-write'
 import { MAX_WORKSPACE_FILE_CONTENT_BYTES } from '@/lib/workspace-files/orchestration'
-import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { restoreSimPageSourceBuffer } from '@/lib/workspace-files/page-source-embed'
 
 interface ContentUseCaseArgs<I, P = undefined> {

apps/sim/lib/projects/files/application/downloads.ts

@@ -59,7 +59,7 @@ import {
 } from '@/lib/workspace-files/download-selection'
 import { MAX_ZIP_DOWNLOAD_BYTES, MAX_ZIP_DOWNLOAD_FILES } from '@/lib/workspace-files/limits'
 import { fileOwnerCondition } from '@/lib/workspace-files/ownership-query'
-import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import {
   createFileReadReceipt,
   type FileReadReceipt,

apps/sim/lib/projects/files/application/uploads.ts

@@ -56,7 +56,7 @@ import {
   type UploadSessionRecord,
 } from '@/lib/uploads/upload-session/service'
 import type { WorkspaceFileUploadSource } from '@/lib/uploads/upload-session/workspace-file-provenance'
-import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import {
   MAX_SIM_PAGE_UPLOAD_SNIFF_BYTES,
   restoreSimPageSourceBuffer,

apps/sim/lib/public-shares/application/read.ts

@@ -37,11 +37,8 @@ import { resolveEffectiveMimeType } from '@/lib/uploads/utils/file'
 import { sniffImageContentType } from '@/lib/uploads/utils/validation'
 import { reportWorkspaceFileDelivery } from '@/lib/workspace-files/application/file-delivery-observer'
 import { fileOwnerCondition } from '@/lib/workspace-files/ownership-query'
-import {
-  isSimPageSource,
-  ProjectPageForeignEmbedError,
-  SIM_PAGE_CONTENT_TYPE,
-} from '@/lib/workspace-files/page-compile'
+import { isSimPageSource, ProjectPageForeignEmbedError } from '@/lib/workspace-files/page-compile'
+import { SIM_PAGE_CONTENT_TYPE } from '@/lib/workspace-files/page-content-type'
 import { renderSimPageDocument } from '@/lib/workspace-files/page-document'
 import {
   collectSimPageFileReferences,