improvement(ci): advance extension access polling in acceptance tests

Author: waleedlatif1

apps/sim/scripts/test-browser-extension-e2e.ts

@@ -269,70 +269,76 @@ try {
   // Only the synthetic page is pregranted; native permission prompts are a separate acceptance check.
   manifest.host_permissions.push(`${fixtureOrigin}/*`)
   await writeFile(resolve(extensionPath, 'manifest.json'), JSON.stringify(manifest))
-  context = await chromium.launchPersistentContext(resolve(temporary, 'profile'), {
-    channel: 'chromium',
-    headless: process.env.EXTENSION_APP_E2E_HEADED !== '1',
-    viewport: { width: 390, height: 844 },
-    args: [
-      `--disable-extensions-except=${extensionPath}`,
-      `--load-extension=${extensionPath}`,
-      '--use-fake-device-for-media-stream',
-    ],
-  })
-  const browserContext = context
+  const launchBrowserContext = () =>
+    chromium.launchPersistentContext(resolve(temporary, 'profile'), {
+      channel: 'chromium',
+      headless: process.env.EXTENSION_APP_E2E_HEADED !== '1',
+      viewport: { width: 390, height: 844 },
+      args: [
+        `--disable-extensions-except=${extensionPath}`,
+        `--load-extension=${extensionPath}`,
+        '--use-fake-device-for-media-stream',
+      ],
+    })
+  context = await launchBrowserContext()
+  let browserContext = context
   context.setDefaultTimeout(30_000)
   context.setDefaultNavigationTimeout(120_000)
-  const worker = context.serviceWorkers()[0] ?? (await context.waitForEvent('serviceworker'))
+  let worker = context.serviceWorkers()[0] ?? (await context.waitForEvent('serviceworker'))
   const extensionId = worker.url().split('/')[2]
-  panel = await context.newPage()
-  const shell = panel
-  await shell.route('**/api/settings/voice', (route) =>
-    route.fulfill({ json: { sttAvailable: true } })
-  )
-  panel.on('pageerror', (error) => browserErrors.push(error.message))
-  panel.on('request', (request) => pendingRequests.add(request))
-  panel.on('requestfinished', (request) => pendingRequests.delete(request))
-  panel.on('requestfailed', (request) => {
-    pendingRequests.delete(request)
-    failedRequests.push({
-      path: new URL(request.url()).pathname,
-      error: request.failure()?.errorText ?? null,
+  const openPanel = async () => {
+    const page = await browserContext.newPage()
+    await page.route('**/api/settings/voice', (route) =>
+      route.fulfill({ json: { sttAvailable: true } })
+    )
+    page.on('pageerror', (error) => browserErrors.push(error.message))
+    page.on('request', (request) => pendingRequests.add(request))
+    page.on('requestfinished', (request) => pendingRequests.delete(request))
+    page.on('requestfailed', (request) => {
+      pendingRequests.delete(request)
+      failedRequests.push({
+        path: new URL(request.url()).pathname,
+        error: request.failure()?.errorText ?? null,
+      })
     })
-  })
-  panel.on('response', (response) => {
-    const url = new URL(response.url())
-    if (url.origin === base.origin && url.pathname === '/api/mothership/chat') {
-      const entry: (typeof chatResponses)[number] = {
-        status: response.status(),
-        chatId: response.headers()[MOTHERSHIP_CHAT_ID_HEADER.toLowerCase()] ?? null,
-        events: [],
+    page.on('response', (response) => {
+      const url = new URL(response.url())
+      if (url.origin === base.origin && url.pathname === '/api/mothership/chat') {
+        const entry: (typeof chatResponses)[number] = {
+          status: response.status(),
+          chatId: response.headers()[MOTHERSHIP_CHAT_ID_HEADER.toLowerCase()] ?? null,
+          events: [],
+        }
+        chatResponses.push(entry)
+        responseDiagnostics.push(
+          response
+            .text()
+            .then((body) => {
+              for (const line of body.split('\n')) {
+                if (!line.startsWith('data: ')) continue
+                const event = toRecord(JSON.parse(line.slice(6)))
+                entry.events.push({
+                  type: toStringOrNull(event.type),
+                  seq: toNumberOrNull(event.seq),
+                })
+              }
+            })
+            .catch((error) => {
+              entry.error = getErrorMessage(error)
+            })
+        )
       }
-      chatResponses.push(entry)
-      responseDiagnostics.push(
-        response
-          .text()
-          .then((body) => {
-            for (const line of body.split('\n')) {
-              if (!line.startsWith('data: ')) continue
-              const event = toRecord(JSON.parse(line.slice(6)))
-              entry.events.push({
-                type: toStringOrNull(event.type),
-                seq: toNumberOrNull(event.seq),
-              })
-            }
-          })
-          .catch((error) => {
-            entry.error = getErrorMessage(error)
-          })
-      )
-    }
-    if (url.origin === base.origin && response.status() >= 400)
-      httpErrors.push({
-        path: url.pathname,
-        status: response.status(),
-        injected: injectedRequests.has(response.request()),
-      })
-  })
+      if (url.origin === base.origin && response.status() >= 400)
+        httpErrors.push({
+          path: url.pathname,
+          status: response.status(),
+          injected: injectedRequests.has(response.request()),
+        })
+    })
+    return page
+  }
+  panel = await openPanel()
+  let shell = panel
   await panel.goto(`chrome-extension://${extensionId}/sidepanel.html`)
   const frame = () => {
     const app = shell.frames().find((candidate) => candidate.url().startsWith(base.origin))
@@ -390,7 +396,7 @@ try {
       timeout: 120_000,
     })
   })
-  const source = await context.newPage()
+  let source = await context.newPage()
   await source.goto(`${fixtureOrigin}/page?private=QUERY_SECRET#FRAGMENT_SECRET`)
   const observeCaptureReceipts = () =>
     shell.evaluate((origin) => {
@@ -1143,6 +1149,81 @@ try {
     await expect(attachments()).toHaveCount(0)
     await screenshot('shared-workspace-organization-navigation')
   })
+  await check(
+    'A first-open toolbar capture survives authenticated organization landing',
+    async () => {
+      await source.bringToFront()
+      await shell.goto('about:blank')
+      const intent = await worker.evaluate(async () => {
+        const [tab] = await chrome.tabs.query({ active: true, currentWindow: true })
+        if (tab.id === undefined || !tab.url) throw new Error('Missing source tab')
+        const digest = await crypto.subtle.digest('SHA-256', new TextEncoder().encode(tab.url))
+        const [result] = await chrome.scripting.executeScript({
+          target: { tabId: tab.id, frameIds: [0] },
+          func: () => null,
+        })
+        return {
+          tabId: tab.id,
+          windowId: tab.windowId,
+          kind: 'page',
+          createdAt: Date.now(),
+          documentId: result.documentId,
+          urlDigest: Array.from(new Uint8Array(digest), (byte) =>
+            byte.toString(16).padStart(2, '0')
+          ).join(''),
+        }
+      })
+      await worker.evaluate(async (pending) => {
+        await chrome.storage.session.set({
+          [`captureIntent:${pending.windowId}:first-open`]: pending,
+        })
+      }, intent)
+      await shell.goto(`chrome-extension://${extensionId}/sidepanel.html`)
+      await observeCaptureReceipts()
+      await expect
+        .poll(() => new URL(frame().url()).pathname)
+        .toBe(`/extension/o/${organizationId}`)
+      await expect(attachments()).toHaveCount(1)
+      await screenshot('organization-first-open-capture')
+    }
+  )
+  if (liveChat) {
+    await check(
+      'Organization live admission preserves queued pages, files, and the admitted conversation mode',
+      () =>
+        verifyLiveChat({
+          name: 'organization',
+          url: `${base.origin}/extension/o/${organizationId}`,
+          inputLabel: 'Ask Sim',
+          draftKey: `extension:${userId}:organization:${organizationId}:home`,
+          organizationId,
+        })
+    )
+  }
+  if (!liveChat) {
+    // Install timers before app code in a fresh context; live provider checks keep native timing.
+    await browserContext.close()
+    context = await launchBrowserContext()
+    browserContext = context
+    browserContext.setDefaultTimeout(30_000)
+    browserContext.setDefaultNavigationTimeout(120_000)
+    worker =
+      browserContext.serviceWorkers()[0] ?? (await browserContext.waitForEvent('serviceworker'))
+    assert.equal(worker.url().split('/')[2], extensionId)
+    panel = await openPanel()
+    shell = panel
+    await shell.clock.install()
+    source = await browserContext.newPage()
+    await source.goto(`${fixtureOrigin}/page?private=QUERY_SECRET#FRAGMENT_SECRET`)
+    await shell.goto(`chrome-extension://${extensionId}/sidepanel.html`)
+    await observeCaptureReceipts()
+  }
+  const advanceAccessRevalidation = async () => {
+    if (liveChat) return
+    await shell.clock.fastForward(ACCESS_REVALIDATION_TIMEOUT_MS)
+    // Capture timestamps come from Chromium's isolated world, outside Playwright's clock.
+    await shell.clock.setSystemTime(Date.now())
+  }
   for (const allowRequests of [false, true]) {
     await check(
       `Workspace Chat policy revocation and regrant work with access requests ${allowRequests ? 'enabled' : 'disabled'}`,
@@ -1173,11 +1254,13 @@ try {
           )
           assert.equal(policy.status(), 200)
           assert.equal(toRecord(toRecord(await policy.json()).config).hideCopilot, true)
+          await advanceAccessRevalidation()
           await expect(input).toHaveCount(0, { timeout: ACCESS_REVALIDATION_TIMEOUT_MS })
           await expect(attachments()).toHaveCount(0)
           await expect(frame().getByText('Access required', { exact: true })).toBeVisible()
           await screenshot(`workspace-chat-revoked-requests-${allowRequests}`)
           await sql`delete from permission_group where id=${permissionGroupId}`
+          await advanceAccessRevalidation()
           await expect(input).toBeVisible({ timeout: ACCESS_REVALIDATION_TIMEOUT_MS })
           await expect(input).toHaveValue(
             'Keep text, but discard the page when Chat access is revoked.'
@@ -1205,57 +1288,6 @@ try {
       }
     )
   }
-  await check(
-    'A first-open toolbar capture survives authenticated organization landing',
-    async () => {
-      await source.bringToFront()
-      await shell.goto('about:blank')
-      const intent = await worker.evaluate(async () => {
-        const [tab] = await chrome.tabs.query({ active: true, currentWindow: true })
-        if (tab.id === undefined || !tab.url) throw new Error('Missing source tab')
-        const digest = await crypto.subtle.digest('SHA-256', new TextEncoder().encode(tab.url))
-        const [result] = await chrome.scripting.executeScript({
-          target: { tabId: tab.id, frameIds: [0] },
-          func: () => null,
-        })
-        return {
-          tabId: tab.id,
-          windowId: tab.windowId,
-          kind: 'page',
-          createdAt: Date.now(),
-          documentId: result.documentId,
-          urlDigest: Array.from(new Uint8Array(digest), (byte) =>
-            byte.toString(16).padStart(2, '0')
-          ).join(''),
-        }
-      })
-      await worker.evaluate(async (pending) => {
-        await chrome.storage.session.set({
-          [`captureIntent:${pending.windowId}:first-open`]: pending,
-        })
-      }, intent)
-      await shell.goto(`chrome-extension://${extensionId}/sidepanel.html`)
-      await observeCaptureReceipts()
-      await expect
-        .poll(() => new URL(frame().url()).pathname)
-        .toBe(`/extension/o/${organizationId}`)
-      await expect(attachments()).toHaveCount(1)
-      await screenshot('organization-first-open-capture')
-    }
-  )
-  if (liveChat) {
-    await check(
-      'Organization live admission preserves queued pages, files, and the admitted conversation mode',
-      () =>
-        verifyLiveChat({
-          name: 'organization',
-          url: `${base.origin}/extension/o/${organizationId}`,
-          inputLabel: 'Ask Sim',
-          draftKey: `extension:${userId}:organization:${organizationId}:home`,
-          organizationId,
-        })
-    )
-  }
   await check(
     'Organization permission changes switch a new chat to Assistant without losing its draft',
     async () => {
@@ -1271,6 +1303,7 @@ try {
       await sql`insert into permission_group (id, organization_id, name, config, created_by, is_default)
       values (${generateId()}, ${organizationId}, 'Search only',
       ${sql.json({ disableWorkspaceCreation: true })}, ${userId}, true)`
+      await advanceAccessRevalidation()
       await expect(frame().getByRole('button', { name: 'Attach image', exact: true })).toBeVisible({
         timeout: ACCESS_REVALIDATION_TIMEOUT_MS,
       })
@@ -1348,7 +1381,9 @@ try {
             [401, 403, 404].includes(response.status()),
           { timeout: ACCESS_REVALIDATION_TIMEOUT_MS }
         ),
-        sql`delete from member where organization_id=${organizationId} and user_id=${userId}`,
+        sql`delete from member where organization_id=${organizationId} and user_id=${userId}`.then(
+          advanceAccessRevalidation
+        ),
       ])
       await expect(frame().getByText('This organization is unavailable.')).toBeVisible()
       await expect(frame().getByRole('textbox', { name: 'Ask Sim', exact: true })).toHaveCount(0)
@@ -1373,7 +1408,9 @@ try {
               response.status() === 403,
             { timeout: ACCESS_REVALIDATION_TIMEOUT_MS }
           ),
-          sql`delete from permissions where user_id=${userId} and entity_type='workspace' and entity_id=${alphaId}`,
+          sql`delete from permissions where user_id=${userId} and entity_type='workspace' and entity_id=${alphaId}`.then(
+            advanceAccessRevalidation
+          ),
         ])
         await expect(frame().getByText('This workspace is unavailable.')).toBeVisible()
         await expect(frame().getByRole('textbox', { name: 'Message', exact: true })).toHaveCount(0)
@@ -1386,7 +1423,6 @@ try {
       await expect(frame().getByRole('textbox', { name: 'Message', exact: true })).toBeVisible()
     }
   )
-  // Clock APIs replace animation timing, so native streaming checks must run first.
   const reconnect = async () => {
     await frame().evaluate(() => {
       window.dispatchEvent(new Event('offline'))