Repository navigation
Commit 23f493e
committed
fix(desktop-e2e): rescue only a click whose final release hit a tab that then closed
- cdp.clickAt raises TabClosedOnReleaseError only when the final mouseReleased
was sent to a live tab and the tab is destroyed when it rejects; the driver
rescues only that error (no string match, no pre-input/press/hold cases),
with a note that does not claim the page closed itself and doNotRetry
- background-executor A: assert each call is claimed within Sim's 15 s pickup
window measured from issue, and always release the gated commands1 parent ba9238d commit 23f493e
3 files changed
Lines changed: 71 additions & 47 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
144 | 151 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
151 | 160 | | |
152 | 161 | | |
153 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1093 | 1093 | | |
1094 | 1094 | | |
1095 | 1095 | | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
1096 | 1107 | | |
1097 | 1108 | | |
1098 | 1109 | | |
| |||
1140 | 1151 | | |
1141 | 1152 | | |
1142 | 1153 | | |
1143 | | - | |
1144 | | - | |
1145 | | - | |
1146 | | - | |
1147 | | - | |
1148 | | - | |
1149 | | - | |
1150 | | - | |
1151 | | - | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
1152 | 1169 | | |
1153 | 1170 | | |
1154 | 1171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1803 | 1803 | | |
1804 | 1804 | | |
1805 | 1805 | | |
1806 | | - | |
1807 | | - | |
1808 | | - | |
1809 | | - | |
| 1806 | + | |
| 1807 | + | |
| 1808 | + | |
1810 | 1809 | | |
1811 | 1810 | | |
1812 | | - | |
1813 | 1811 | | |
1814 | 1812 | | |
1815 | 1813 | | |
1816 | | - | |
| 1814 | + | |
1817 | 1815 | | |
1818 | | - | |
1819 | 1816 | | |
1820 | 1817 | | |
1821 | 1818 | | |
1822 | 1819 | | |
1823 | 1820 | | |
1824 | 1821 | | |
1825 | 1822 | | |
| 1823 | + | |
1826 | 1824 | | |
1827 | 1825 | | |
1828 | | - | |
1829 | | - | |
| 1826 | + | |
| 1827 | + | |
1830 | 1828 | | |
1831 | | - | |
| 1829 | + | |
1832 | 1830 | | |
1833 | 1831 | | |
1834 | 1832 | | |
| |||
3329 | 3327 | | |
3330 | 3328 | | |
3331 | 3329 | | |
3332 | | - | |
| 3330 | + | |
3333 | 3331 | | |
3334 | 3332 | | |
3335 | 3333 | | |
| |||
3371 | 3369 | | |
3372 | 3370 | | |
3373 | 3371 | | |
3374 | | - | |
| 3372 | + | |
3375 | 3373 | | |
3376 | 3374 | | |
3377 | 3375 | | |
| |||
4796 | 4794 | | |
4797 | 4795 | | |
4798 | 4796 | | |
4799 | | - | |
| 4797 | + | |
4800 | 4798 | | |
4801 | 4799 | | |
4802 | 4800 | | |
| |||
0 commit comments