fix(people): pass an out-of-range date serial through instead of failing the import

Author: waleedlatif1

apps/sim/app/o/[organizationId]/people/read-people-sheet.test.ts

@@ -50,6 +50,17 @@ describe('readPeopleSheet', () => {
     expect(sheet.rows).toEqual([['ada@example.com', '2024-01-31']])
   })
 
+  it('passes an out-of-range date serial through as text for the server to refuse', async () => {
+    const sheet = await readPeopleSheet(
+      workbookFile([
+        ['email', 'start date'],
+        ['ada@example.com', -5],
+      ])
+    )
+    expect(sheet.rows[0]?.[0]).toBe('ada@example.com')
+    expect(sheet.rows[0]?.[1]).not.toMatch(/^\d{4}-\d{2}-\d{2}$/)
+  })
+
   it('keeps blank rows in place so issue row numbers match the sheet', async () => {
     const sheet = await readPeopleSheet(
       workbookFile([

apps/sim/app/o/[organizationId]/people/read-people-sheet.ts

@@ -39,8 +39,10 @@ export async function readPeopleSheet(file: File): Promise<PeopleSheet> {
     const cell = grid[row]?.[column]
     if (!cell || cell.v === undefined || cell.v === null) return ''
     if (cell.t === 'n' && XLSX.SSF.is_date(cell.z ?? '')) {
+      // A serial outside Excel's calendar has no date; its text goes on for the server to refuse.
       const date = XLSX.SSF.parse_date_code(Number(cell.v), dateSystem)
-      return `${date.y}-${String(date.m).padStart(2, '0')}-${String(date.d).padStart(2, '0')}`
+      if (date)
+        return `${date.y}-${String(date.m).padStart(2, '0')}-${String(date.d).padStart(2, '0')}`
     }
     return String(cell.w ?? cell.v).trim()
   }