fix(account-deletion): keep a public object a stored URL with a fragment still names

A relative /api/files/serve/<key>#frag kept the fragment in its candidate key,
so a live reference could be missed and the object purged. The guard now also
reads the path without its fragment, on both the decoded and fallback paths.

Author: waleedlatif1

apps/sim/lib/users/storage-reference-guard.ts

@@ -40,6 +40,7 @@ const SERVE_PATH = '/api/files/serve/'
 /**
  * The storage keys a stored URL can name: a `/api/files/serve/...` path (relative or absolute,
  * with or without a provider segment), or a direct bucket URL in virtual-host or path style.
+ * A relative path is also read without its `#fragment`, which a key may hold literally.
  * Over-matching only keeps an object. Never throws: a value whose percent-encoding is malformed
  * yields its raw path and that path with each valid escape decoded (a legacy key can hold a
  * literal `%`), so one bad stored string cannot disable every purge.
@@ -72,10 +73,13 @@ function keysNamedByUrl(value: string): string[] {
     const serveAt = raw.indexOf(SERVE_PATH)
     path = serveAt >= 0 ? raw.slice(serveAt + SERVE_PATH.length) : raw
   }
-  path = path.replace(/^\/+/, '')
-  add(path)
-  const slash = path.indexOf('/')
-  if (slash > 0) add(path.slice(slash + 1))
+  const fragmentAt = path.indexOf('#')
+  for (const candidate of fragmentAt >= 0 ? [path, path.slice(0, fragmentAt)] : [path]) {
+    const key = candidate.replace(/^\/+/, '')
+    add(key)
+    const slash = key.indexOf('/')
+    if (slash > 0) add(key.slice(slash + 1))
+  }
   return [...keys]
 }
 

apps/sim/lib/users/storage-sweep.test.ts

@@ -524,6 +524,26 @@ describe('account storage object cleanup', () => {
     expect(await exists('workspace-logos/wsforeign9/icon.png')).toBe(true)
   })
 
+  it.each([
+    {
+      key: 'workspace-logos/wsforeign9/icon.png',
+      url: '/api/files/serve/workspace-logos%2Fwsforeign9%2Ficon.png#v2',
+    },
+    {
+      key: 'workspace-logos/wsforeign9/brand logo%.png',
+      url: '/api/files/serve/workspace-logos/wsforeign9/brand%20logo%.png#v2',
+    },
+  ])('keeps a public key a relative URL with a fragment names: $url', async ({ key, url }) => {
+    const storedAs = key.replace(/[ %]/g, '_')
+    await put(storedAs)
+    queueTableRows(schemaMock.user, [])
+    queueTableRows(schemaMock.user, [{ value: url }])
+
+    await cleanup(payload([{ key, context: 'workspace-logos' }]), outboxContext())
+
+    expect(await exists(storedAs)).toBe(true)
+  })
+
   it('keeps a public key without an owner id to narrow on, reading no URL column', async () => {
     await put('og-images/logo.png')