Merge pull request #30 from simplesamlphp/feature/php83

Feature/php83

Author: tvdijen

.github/workflows/php.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: ['8.2', '8.3', '8.4', '8.5']
+        php-version: ['8.3', '8.4', '8.5']
 
     uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.11.0
     with:
@@ -45,7 +45,7 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.2', '8.3', '8.4', '8.5']
+        php-versions: ['8.3', '8.4', '8.5']
 
     steps:
       - name: Setup PHP, with composer and extensions
@@ -107,15 +107,15 @@ jobs:
       fail-fast: true
       matrix:
         operating-system: [windows-latest]
-        php-versions: ['8.2', '8.3', '8.4', '8.5']
+        php-versions: ['8.3', '8.4', '8.5']
 
     steps:
       - name: Setup PHP, with composer and extensions
         # https://github.com/shivammathur/setup-php
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
-          extensions: ctype, date, filter, intl, pcre, spl
+          extensions: ctype, date, filter, intl, pcre, sodium, spl
           tools: composer
           ini-values: error_reporting=E_ALL
           coverage: none
@@ -164,7 +164,7 @@ jobs:
           # Should be the higest supported version, so we can use the newest tools
           php-version: '8.5'
           tools: composer, composer-require-checker, composer-unused
-          extensions: ctype, date, filter, pcre, spl
+          extensions: ctype, date, filter, pcre, sodium, spl
           coverage: none
 
       - name: Setup problem matchers for PHP
@@ -216,8 +216,8 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           # Should be the lowest supported version
-          php-version: '8.2'
-          extensions: ctype, date, filter, pcre, spl
+          php-version: '8.3'
+          extensions: ctype, date, filter, pcre, sodium, spl
           tools: composer
           coverage: none
 

composer.json

@@ -13,7 +13,7 @@
         }
     ],
     "require": {
-        "php": "^8.2",
+        "php": "^8.3",
         "ext-date": "*",
         "ext-filter": "*",
         "ext-pcre": "*",
@@ -25,7 +25,7 @@
     "require-dev": {
         "ext-intl": "*",
 
-        "simplesamlphp/simplesamlphp-test-framework": "~1.10"
+        "simplesamlphp/simplesamlphp-test-framework": "~1.11"
     },
     "autoload": {
         "psr-4": {

src/Assert.php

@@ -16,13 +16,17 @@
 use function array_unshift;
 use function call_user_func_array;
 use function end;
+use function is_array;
+use function is_callable;
 use function is_object;
 use function is_resource;
 use function is_string;
 use function is_subclass_of;
 use function lcfirst;
 use function method_exists;
 use function preg_match; // Requires ext-pcre
+use function reset;
+use function sprintf;
 use function strval;
 
 /**
@@ -389,7 +393,6 @@ public static function __callStatic(string $name, array $arguments): void
      *
      * @param callable $method
      * @param mixed[] $arguments
-     * @return void
      */
     private static function nullOr(callable $method, array $arguments): void
     {
@@ -403,7 +406,6 @@ private static function nullOr(callable $method, array $arguments): void
      *
      * @param callable $method
      * @param mixed[] $arguments
-     * @return void
      */
     private static function all(callable $method, array $arguments): void
     {

src/Base64Trait.php

@@ -16,7 +16,6 @@
  */
 trait Base64Trait
 {
-    /** @var string */
     private static string $base64_regex = '/^(?:[a-z0-9+\/]{4})*(?:[a-z0-9+\/]{2}==|[a-z0-9+\/]{3}=)?$/i';