Failing test test_memory_attribute_for_existing_connection with --sqlite-autocommit

[simonw]

This command:

uv run pytest --sqlite-autocommit -k test_memory_attribute_for_existing_connection

Fails like this:

            autocommit = getattr(self.conn, "autocommit", None)
            if autocommit is not None and autocommit != getattr(
                sqlite3, "LEGACY_TRANSACTION_CONTROL", -1
            ):
>               raise TransactionError(
                    "sqlite-utils requires a connection that uses the default "
                    "transaction handling - connections created with "
                    "autocommit=True or autocommit=False are not supported"
                )
E               sqlite_utils.db.TransactionError: sqlite-utils requires a connection that uses the default transaction handling - connections created with autocommit=True or autocommit=False are not supported

Since: d302835

[simonw]

Here's that test:

sqlite-utils/tests/test_constructor.py

Lines 116 to 120 in 7a52214

	def test_memory_attribute_for_existing_connection():
	conn = sqlite3.connect(":memory:")
	db = Database(conn)
	assert db.memory is False
	assert db.memory_name is None

[simonw]

It's because of this code (which only runs on --sqlite-autocommit):

sqlite-utils/tests/conftest.py

Lines 28 to 39 in 0f2d525

	if config.getoption("--sqlite-autocommit"):
	if sys.version_info < (3, 12):
	raise pytest.UsageError(
	"--sqlite-autocommit requires Python 3.12 or higher"
	)
	real_connect = sqlite3.connect
	def autocommit_connect(*args, **kwargs):
	kwargs.setdefault("autocommit", True)
	return real_connect(*args, **kwargs)
	sqlite3.connect = autocommit_connect

[simonw]

The reason this is happening is that very few of our tests have the connection created separately and then passed to the Database() constructor.

I'm going to ditch this test entirely. This other test already confirms what we care about:

sqlite-utils/tests/test_constructor.py

Lines 92 to 95 in 7a52214

	def test_memory_attribute_for_memory_true():
	db = Database(memory=True)
	assert db.memory is True
	assert db.memory_name is None