Increasing code coverage (#6)

* Creating bases

* Implementing visitor pattern

* Making KMLObjects visitable

* Code quality fix

* Adding parser scaffolding

* Refactoring code formatting

* Increasing testing

* Fixing travis integration

* Setting php minimum version

* Adding CI badges

* Refactoring comments, simplification

* Code quality fix

* Increasing code coverage and refactoring domain classes

* Increasing code coverage

* Increasing code coverage and domain classes refactoring

* Increasing code coverage and domain classes refactoring

* Increasing code coverage and domain classes refactoring

* Increasing code coverage

* Increasing code coverage and filling gaps in domain

* Increasing code coverage and filling gaps in domain

Author: earelin

composer.json

@@ -31,7 +31,7 @@
   },
   "scripts": {
     "clean": "rm -Rf reports vendor",
-    "test": "phpunit --bootstrap vendor/autoload.php -c phpunit.xml --testdox",
+    "test": "phpunit --bootstrap vendor/autoload.php -c phpunit.xml",
     "phpcs": "phpcs --bootstrap=vendor/autoload.php --standard=vendor/drupal/coder/coder_sniffer/Drupal --exclude=Drupal.Commenting.FunctionComment src",
     "phpcbf": "phpcbf --bootstrap=vendor/autoload.php --standard=vendor/drupal/coder/coder_sniffer/Drupal --exclude=Drupal.Commenting.FunctionComment,Drupal.Commenting.ClassComment src"
   }

composer.lock

@@ -21,55 +21,55 @@ public function getLongitude(): float {
     return $this->longitude;
   }
 
-  public function setLongitude(float $longitude) {
+  public function setLongitude(float $longitude): void {
     $this->longitude = $longitude;
   }
 
   public function getLatitude(): float {
     return $this->latitude;
   }
 
-  public function setLatitude(float $latitude) {
+  public function setLatitude(float $latitude): void {
     $this->latitude = $latitude;
   }
 
   public function getAltitude(): float {
     return $this->altitude;
   }
 
-  public function setAltitude(float $altitude) {
+  public function setAltitude(float $altitude): void {
     $this->altitude = $altitude;
   }
 
   public function getHeading(): float {
     return $this->heading;
   }
 
-  public function setHeading(float $heading) {
+  public function setHeading(float $heading): void {
     $this->heading = $heading;
   }
 
   public function getTilt(): float {
     return $this->tilt;
   }
 
-  public function setTilt(float $tilt) {
+  public function setTilt(float $tilt): void {
     $this->tilt = $tilt;
   }
 
   public function getRoll(): float {
     return $this->roll;
   }
 
-  public function setRoll(float $roll) {
+  public function setRoll(float $roll): void {
     $this->roll = $roll;
   }
 
-  public function getAltitudeMode() {
+  public function getAltitudeMode(): string {
     return $this->altitudeMode;
   }
 
-  public function setAltitudeMode($altitudeMode) {
+  public function setAltitudeMode(string $altitudeMode): void {
     $this->altitudeMode = $altitudeMode;
   }
 

src/Domain/AbstractView/AbstractView.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace LibKml\Domain\Feature\ExtendedData;
+
+class Data {
+
+  private $name;
+  private $value;
+  private $displayName;
+
+  public function getName(): string {
+    return $this->name;
+  }
+
+  public function setName(string $name): void {
+    $this->name = $name;
+  }
+
+  public function getValue(): string {
+    return $this->value;
+  }
+
+  public function setValue(string $value): void {
+    $this->value = $value;
+  }
+
+  public function getDisplayName(): string {
+    return $this->displayName;
+  }
+
+  public function setDisplayName(string $displayName): void {
+    $this->displayName = $displayName;
+  }
+
+}

src/Domain/Feature/ExtendedData/Data.php

@@ -0,0 +1,54 @@
+<?php
+
+namespace LibKml\Domain\Feature\ExtendedData;
+
+/**
+ * Allows to add custom data to a Feature.
+ */
+class ExtendedData {
+
+  private $data = [];
+  private $schemaData = [];
+  private $other = [];
+
+  public function addData(Data $data): void {
+    $this->data[] = $data;
+  }
+
+  public function clearData(): void {
+    $this->data = [];
+  }
+
+  public function getData(): array {
+    return $this->data;
+  }
+
+  public function setData(array $data): void {
+    $this->data = $data;
+  }
+
+  public function addSchemaData(SchemaData $schemaData): void {
+    $this->schemaData[] = $schemaData;
+  }
+
+  public function clearSchemaData(): void {
+    $this->schemaData = [];
+  }
+
+  public function getSchemaData(): array {
+    return $this->schemaData;
+  }
+
+  public function setSchemaData(array $schemaData): void {
+    $this->schemaData = $schemaData;
+  }
+
+  public function getOther(): array {
+    return $this->other;
+  }
+
+  public function setOther(array $other): void {
+    $this->other = $other;
+  }
+
+}

src/Domain/Feature/ExtendedData/ExtendedData.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace LibKml\Domain\Feature\ExtendedData;
+
+class Other {
+
+  private $namespace;
+  private $name;
+  private $value;
+
+  public function getNamespace(): string {
+    return $this->namespace;
+  }
+
+  public function setNamespace(string $namespace): void {
+    $this->namespace = $namespace;
+  }
+
+  public function getName(): string {
+    return $this->name;
+  }
+
+  public function setName(string $name): void {
+    $this->name = $name;
+  }
+
+  public function getValue(): string {
+    return $this->value;
+  }
+
+  public function setValue(string $value): void {
+    $this->value = $value;
+  }
+
+}

src/Domain/Feature/ExtendedData/Other.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace LibKml\Domain\Feature\ExtendedData;
+
+class SchemaData {
+
+  private $schemaUrl;
+  private $simpleData = [];
+
+  public function getSchemaUrl() {
+    return $this->schemaUrl;
+  }
+
+  public function setSchemaUrl($schemaUrl): void {
+    $this->schemaUrl = $schemaUrl;
+  }
+
+  public function getSimpleData(): array {
+    return $this->simpleData;
+  }
+
+  public function setSimpleData(array $simpleData): void {
+    $this->simpleData = $simpleData;
+  }
+
+}

src/Domain/Feature/ExtendedData/SchemaData.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace LibKml\Domain\Feature\ExtendedData;
+
+class SimpleData {
+
+  private $name;
+  private $value;
+
+  public function getName() {
+    return $this->name;
+  }
+
+  public function setName($name): void {
+    $this->name = $name;
+  }
+
+  public function getValue() {
+    return $this->value;
+  }
+
+  public function setValue($value): void {
+    $this->value = $value;
+  }
+
+}

src/Domain/Feature/ExtendedData/SimpleData.php

@@ -3,11 +3,13 @@
 namespace LibKml\Domain\Feature;
 
 use LibKml\Domain\AbstractView\AbstractView;
+use LibKml\Domain\Feature\ExtendedData\ExtendedData;
 use LibKml\Domain\FieldType\Atom\Author;
 use LibKml\Domain\KmlObject;
-use LibKml\Domain\Link\Link;
+use LibKml\Domain\FieldType\Atom\Link;
 use LibKml\Domain\Region;
 use LibKml\Domain\StyleSelector\StyleSelector;
+use LibKml\Domain\TimePrimitive\TimePrimitive;
 
 /**
  * Feature abstract class.
@@ -39,21 +41,11 @@ public function clearStyleSelectors(): void {
     $this->styleSelector = array();
   }
 
-  public function getAllStyles(): array {
-    $all_styles = array();
-
-    foreach ($this->styleSelector as $style) {
-      $all_styles[] = $style;
-    }
-
-    return $all_styles;
-  }
-
   public function getName(): string {
     return $this->name;
   }
 
-  public function setName(string $name) {
+  public function setName(string $name): void {
     $this->name = $name;
   }
 
@@ -109,71 +101,71 @@ public function getPhoneNumber(): string {
     return $this->phoneNumber;
   }
 
-  public function setPhoneNumber(string $phoneNumber) {
+  public function setPhoneNumber(string $phoneNumber): void {
     $this->phoneNumber = $phoneNumber;
   }
 
   public function getSnippet(): string {
     return $this->snippet;
   }
 
-  public function setSnippet(string $snippet) {
+  public function setSnippet(string $snippet): void {
     $this->snippet = $snippet;
   }
 
   public function getDescription(): string {
     return $this->description;
   }
 
-  public function setDescription(string $description) {
+  public function setDescription(string $description): void {
     $this->description = $description;
   }
 
   public function getAbstractView(): AbstractView {
     return $this->abstractView;
   }
 
-  public function setAbstractView(AbstractView $abstractView) {
+  public function setAbstractView(AbstractView $abstractView): void {
     $this->abstractView = $abstractView;
   }
 
-  public function getTimePrimitive() {
+  public function getTimePrimitive(): TimePrimitive {
     return $this->timePrimitive;
   }
 
-  public function setTimePrimitive($timePrimitive) {
+  public function setTimePrimitive(TimePrimitive $timePrimitive): void {
     $this->timePrimitive = $timePrimitive;
   }
 
-  public function getStyleUrl() {
+  public function getStyleUrl(): string {
     return $this->styleUrl;
   }
 
-  public function setStyleUrl($styleUrl) {
+  public function setStyleUrl(string $styleUrl): void {
     $this->styleUrl = $styleUrl;
   }
 
-  public function getStyleSelector() {
+  public function getStyleSelector(): array {
     return $this->styleSelector;
   }
 
-  public function setStyleSelector(array $styleSelector) {
+  public function setStyleSelector(array $styleSelector): void {
     $this->styleSelector = $styleSelector;
   }
 
-  public function getRegion() {
+  public function getRegion(): Region {
     return $this->region;
   }
 
-  public function setRegion(Region $region) {
+  public function setRegion(Region $region): void {
     $this->region = $region;
   }
 
-  public function getExtendedData() {
+  public function getExtendedData(): ExtendedData {
     return $this->extendedData;
   }
 
-  public function setExtendedData($extendedData) {
+  public function setExtendedData(ExtendedData $extendedData): void {
     $this->extendedData = $extendedData;
   }