Improving code coverage

Author: earelin

src/Domain/Feature/Feature.php

@@ -22,7 +22,6 @@ abstract class Feature extends KmlObject {
   protected $atomAuthor;
   protected $atomLink;
   protected $address;
-  protected $addressDetails;
   protected $phoneNumber;
   protected $snippet;
   protected $description;
@@ -89,14 +88,6 @@ public function setAtomLink(?Link $atomLink): void {
     $this->atomLink = $atomLink;
   }
 
-  public function getAddressDetails() {
-    return $this->addressDetails;
-  }
-
-  public function setAddressDetails($addressDetails) {
-    $this->addressDetails = $addressDetails;
-  }
-
   public function getPhoneNumber(): ?string {
     return $this->phoneNumber;
   }

src/Domain/TimePrimitive/TimeStamp.php

@@ -11,6 +11,12 @@ class TimeStamp extends TimePrimitive {
 
   private $when;
 
+  public static function fromInteger(int $unixTimestamp) {
+    $timeStamp = new TimeStamp();
+    $timeStamp->when = date(DATE_ISO8601, $unixTimestamp);
+    return $timeStamp;
+  }
+
   public function accept(KmlObjectVisitorInterface $visitor): void {
     $visitor->visitTimeStamp($this);
   }

tests/src/Domain/AbstractView/CameraTest.php

@@ -3,7 +3,9 @@
 namespace LibKml\Tests\Domain\AbstractView;
 
 use LibKml\Domain\AbstractView\Camera;
+use LibKml\Domain\FieldType\AltitudeMode;
 use LibKml\Domain\KmlObjectVisitorInterface;
+use LibKml\Domain\TimePrimitive\TimeStamp;
 use PHPUnit\Framework\TestCase;
 
 class CameraTest extends TestCase {
@@ -39,4 +41,20 @@ public function testRollField() {
     $this->assertEquals($roll, $this->camera->getRoll());
   }
 
+  public function testAltitudeModeField() {
+    $altitudeMode = AltitudeMode::ABSOLUTE;
+
+    $this->camera->setAltitudeMode($altitudeMode);
+
+    $this->assertEquals($altitudeMode, $this->camera->getAltitudeMode());
+  }
+
+  public function testTimePrimitive() {
+    $timeStamp = TimeStamp::fromInteger(time());
+
+    $this->camera->setTimePrimitive($timeStamp);
+
+    $this->assertEquals($timeStamp, $this->camera->getTimePrimitive());
+  }
+
 }

tests/src/Domain/TimePrimitive/TimeStampTest.php

@@ -37,5 +37,13 @@ public function testWhenField() {
 
     $this->assertEquals($when, $this->timeStamp->getWhen());
   }
+
+  public function testFromInteger() {
+    $unixTimestamp = time();
+
+    $timeStamp = TimeStamp::fromInteger($unixTimestamp);
+
+    $this->assertEquals(date(DATE_ISO8601, $unixTimestamp), $timeStamp->getWhen());
+  }
 
 }