Fix confusing ".." in log filenames for local deploys.

Author: sharpjs

PSql.Deploy.Engine/Core/Target.cs

@@ -54,7 +54,7 @@ public Target(
 
         ServerDisplayName
             =  serverDisplayName
-            ?? builder.DataSource.NullIfEmpty()
+            ?? builder.DataSource.NullIfEmpty().NullIf(".")
             ?? "local";
 
         DatabaseDisplayName

PSql.Deploy.Engine/Utilities/StringExtensions.cs

@@ -1,9 +1,6 @@
 // Copyright Subatomix Research Inc.
 // SPDX-License-Identifier: MIT
 
-using System.Diagnostics.CodeAnalysis;
-using System.Text;
-
 namespace PSql.Deploy;
 
 /// <summary>
@@ -26,7 +23,7 @@ public static bool IsNullOrEmpty([NotNullWhen(false)] this string? s)
         => string.IsNullOrEmpty(s);
 
     /// <summary>
-    ///   Replaces an empty string with <see langword="null"/>.
+    ///   Replaces the string with <see langword="null"/> if it is empty.
     /// </summary>
     /// <param name="s">
     ///   The string to transform.
@@ -36,7 +33,28 @@ public static bool IsNullOrEmpty([NotNullWhen(false)] this string? s)
     ///   <paramref name="s"/> otherwise.
     /// </returns>
     public static string? NullIfEmpty(this string? s)
-        => string.IsNullOrEmpty(s) ? null : s;
+        => s.NullIf(string.Empty);
+
+    /// <summary>
+    ///   Replaces the string with <see langword="null"/> if it is equal to the
+    ///   specified string.
+    /// </summary>
+    /// <param name="s">
+    ///   The string to transform.
+    /// </param>
+    /// <param name="nullish">
+    ///   The string against which to compare <paramref name="s"/>.
+    /// </param>
+    /// <returns>
+    ///   <see langword="null"/>
+    ///     if <paramref name="s"/> is equal to <paramref name="nullish"/>;
+    ///   <paramref name="s"/>
+    ///     otherwise.
+    /// </returns>
+    ///   This method performs a case-sensitive ordinal comparison.
+    /// <remarks>
+    public static string? NullIf(this string? s, string? nullish)
+        => s == nullish ? null : s;
 
     /// <summary>
     ///   Escapes the string for inclusing in a SQL string literal.

PSql.Deploy.Tests/Integration/InvokeSqlMigrationsCommandTests.cs

@@ -77,12 +77,12 @@ void ShouldBeMigrations(int n, MigrationState state)
         ShouldBeMigrations(3, MigrationState.AppliedPost);
         ShouldBeMigrations(6, MigrationState.AppliedPost);
 
-        File.ReadAllText("..PSqlDeployTestA.0_Pre.log" ).ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestA.1_Core.log").ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestA.2_Post.log").ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestB.0_Pre.log" ).ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestB.1_Core.log").ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestB.2_Post.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestA.0_Pre.log" ).ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestA.1_Core.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestA.2_Post.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestB.0_Pre.log" ).ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestB.1_Core.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestB.2_Post.log").ShouldNotBeNullOrEmpty();
     }
 
     [Test]

PSql.Deploy.Tests/Integration/InvokeSqlSeedCommandIntegrationTests.cs

@@ -33,8 +33,8 @@ public void Invoke()
 
         exception.ShouldBeNull();
 
-        File.ReadAllText("..PSqlDeployTestA.Typical.log").ShouldNotBeNullOrEmpty();
-        File.ReadAllText("..PSqlDeployTestB.Typical.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestA.Typical.log").ShouldNotBeNullOrEmpty();
+        File.ReadAllText("local.PSqlDeployTestB.Typical.log").ShouldNotBeNullOrEmpty();
     }
 
     [Test]