Plug coverage hole.

Author: sharpjs

PSql.Deploy.Tests/Commands/GetSqlMigrationsCommandTests.cs

@@ -8,14 +8,15 @@ namespace PSql.Deploy.Commands;
 using static ScriptExecutor;
 
 [TestFixture]
+[FixtureLifeCycle(LifeCycle.SingleInstance)]
 public class GetSqlMigrationsCommandTests
 {
     // This test fixture tests only discovery of migrations defined on disk.
     // Discovery of migrations registered in a target database is tested in
     // InvokeSqlMigrationsCommandIntegrationTests.
 
     [Test]
-    public void Invoke()
+    public void Invoke_Path()
     {
         var (output, exception) = Execute(
             """
@@ -32,9 +33,34 @@ public void Invoke()
             .Select(o => o.BaseObject.ShouldBeOfType<Migration>())
             .ToList();
 
+        ShouldBeTestDbADefinedMigrations(migrations);
+    }
+
+    [Test]
+    public void Invoke_Path_FromPipeline()
+    {
+        var (output, exception) = Execute(
+            """
+            Join-Path TestDbs A | Get-SqlMigrations
+            """
+        );
+
+        exception.ShouldBeNull();
+
+        output.Count.ShouldBe(5);
+
+        var migrations = output
+            .Select(o => o.ShouldNotBeNull())
+            .Select(o => o.BaseObject.ShouldBeOfType<Migration>())
+            .ToList();
+
+        ShouldBeTestDbADefinedMigrations(migrations);
+    }
+
+    private void ShouldBeTestDbADefinedMigrations(List<Migration> migrations)
+    {
         var path = Path.Combine(TestContext.CurrentContext.TestDirectory, "TestDbs", "A");
 
-        // From Pre+Core run
         migrations[0].Name    .ShouldBe("_Begin");
         migrations[0].Hash    .ShouldBe("1FA5BB132E282E92E49B1F3C73E5CA91977D1B7A");
         migrations[0].Path    .ShouldBe(Path.Combine(path, "Migrations", "_Begin", "_Main.sql"));

PSql.Deploy.Tests/Integration/InvokeSqlMigrationsCommandTests.cs

@@ -41,7 +41,9 @@ public void Invoke()
                 -Path     $Path    `
                 -Confirm: $false
 
-            Get-SqlMigrations -Target $TargetA
+            # Test pipeline input
+            $TargetA | Get-SqlMigrations
+            [PSql.Deploy.SqlTargetDatabase]::new($TargetA) | Get-SqlMigrations
             """
         );
 
@@ -51,33 +53,29 @@ public void Invoke()
 
         var migrations = output.Select(o => o?.BaseObject).OfType<Migration>().ToList();
 
-        migrations.Count.ShouldBe(6);
-
-        // From Pre+Core run
-        migrations[0].Name .ShouldBe("Migration0");
-        migrations[0].Hash .ShouldBe("D8462C316FD72659FB11FA7C9727D05707F8332B");
-        migrations[0].State.ShouldBe(MigrationState.AppliedCore);
+        migrations.Count.ShouldBe(9);
 
-        migrations[1].Name .ShouldBe("Migration1");
-        migrations[1].Hash .ShouldBe("2909F7C67C9B831FFCD4655F31683941F700A205");
-        migrations[1].State.ShouldBe(MigrationState.AppliedCore);
+        void ShouldBeMigrations(int n, MigrationState state)
+        {
+            migrations[n + 0].Name .ShouldBe("Migration0");
+            migrations[n + 0].Hash .ShouldBe("D8462C316FD72659FB11FA7C9727D05707F8332B");
+            migrations[n + 0].State.ShouldBe(state);
 
-        migrations[2].Name .ShouldBe("Migration2");
-        migrations[2].Hash .ShouldBe("FB049E6EA9DC10019088850C94E9C5D2661A6DE7");
-        migrations[2].State.ShouldBe(MigrationState.AppliedCore);
+            migrations[n + 1].Name .ShouldBe("Migration1");
+            migrations[n + 1].Hash .ShouldBe("2909F7C67C9B831FFCD4655F31683941F700A205");
+            migrations[n + 1].State.ShouldBe(state);
 
-        // From Post run
-        migrations[3].Name .ShouldBe("Migration0");
-        migrations[3].Hash .ShouldBe("D8462C316FD72659FB11FA7C9727D05707F8332B");
-        migrations[3].State.ShouldBe(MigrationState.AppliedPost);
+            migrations[n + 2].Name .ShouldBe("Migration2");
+            migrations[n + 2].Hash .ShouldBe("FB049E6EA9DC10019088850C94E9C5D2661A6DE7");
+            migrations[n + 2].State.ShouldBe(state);
+        }
 
-        migrations[4].Name .ShouldBe("Migration1");
-        migrations[4].Hash .ShouldBe("2909F7C67C9B831FFCD4655F31683941F700A205");
-        migrations[4].State.ShouldBe(MigrationState.AppliedPost);
+        // From Pre+Core run
+        ShouldBeMigrations(0, MigrationState.AppliedCore);
 
-        migrations[5].Name .ShouldBe("Migration2");
-        migrations[5].Hash .ShouldBe("FB049E6EA9DC10019088850C94E9C5D2661A6DE7");
-        migrations[5].State.ShouldBe(MigrationState.AppliedPost);
+        // From Post run
+        ShouldBeMigrations(3, MigrationState.AppliedPost);
+        ShouldBeMigrations(6, MigrationState.AppliedPost);
 
         File.ReadAllText("..PSqlDeployTestA.0_Pre.log" ).ShouldNotBeNullOrEmpty();
         File.ReadAllText("..PSqlDeployTestA.1_Core.log").ShouldNotBeNullOrEmpty();

PSql.Deploy/Commands/GetSqlMigrationsCommand.cs

@@ -106,12 +106,9 @@ private bool IsForTarget()
                 return false;
 
             case nameof(Target):
-                Assume.NotNull(Target);
+                Assume.NotNull(Target); // due to [ValidateNotNullOrEmpty]
                 return true;
 
-            case nameof(InputObject) when InputObject is null:
-                return false;
-
             case nameof(InputObject) when InputObject is string path && !path.Contains(';'):
                 Path = path;
                 return false;
@@ -121,7 +118,8 @@ private bool IsForTarget()
                 return true;
 
             default:
-                Target = new SqlTargetDatabase(InputObject!);
+                Assume.NotNull(InputObject); // due to [ValidateNotNullOrEmpty]
+                Target = new SqlTargetDatabase(InputObject);
                 return true;
         }
     }