Skip to content

Commit 65bc286

Browse files
committed
Clarify cpflow workflow safety tradeoffs
1 parent 0a148a4 commit 65bc286

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

.github/actions/cpflow-setup-environment/action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ runs:
6363
exit 1
6464
fi
6565
66-
# Make the token available to later workflow steps without putting it on argv.
66+
# Later workflow steps call cpflow/cpln, so persist the token without putting it on argv.
67+
# This intentionally gives subsequent trusted steps in the same job a CPLN_TOKEN env var.
6768
token_delimiter="CPLN_TOKEN_$(openssl rand -hex 8)"
6869
{
6970
echo "CPLN_TOKEN<<${token_delimiter}"

.github/workflows/cpflow-delete-review-app.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Delete Review App
22

33
on:
4+
# Use pull_request_target for close cleanup so fork PR review apps can be deleted with
5+
# base-repo secrets. This workflow checks out the base repository, not untrusted PR code.
46
pull_request_target:
57
types: [closed]
68
issue_comment:

.github/workflows/cpflow-deploy-review-app.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ jobs:
191191
run: |
192192
set -euo pipefail
193193
194+
# Keep this in sync with delete-app.sh. `cpflow exists` does not yet expose
195+
# distinct structured signals for not-found vs. auth/API failures.
194196
exists_output=""
195197
if exists_output="$(cpflow exists -a "${APP_NAME}" --org "${CPLN_ORG}" 2>&1)"; then
196198
if [[ -n "${exists_output}" ]]; then

0 commit comments

Comments
 (0)