Skip to content

⚠️ Broken interface contract #68

@serkor1

Description

@serkor1

📚 What?

The README promises this:

{talib} comes with a composable charting API built on two core functions: indicator() and chart()—both functions are built on model.frame for maximum flexibility:

The code does this (both back-ends):

ta-lib-R/R/chart.R

Lines 268 to 279 in c072867

## initialize the plotly object
## with OHLC data
base <- plotly::plot_ly(
data = data,
x = ~idx,
open = ~open,
close = ~close,
high = ~high,
low = ~low,
showlegend = FALSE,
...
)

Both can be true at the same time. But at the moment ellipsis is only passing down to plotly::plot_ly()

📋 TODO

  • Determine on a direction: model.frame, arguments passed to underlying function or both.
  • Implement

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions