Skip to content

Commit e535a7f

Browse files
committed
fix(core): disable batch inserting
1 parent 46b1f80 commit e535a7f

1 file changed

Lines changed: 2 additions & 13 deletions

File tree

services/core/measurements/infra/store_psql.go

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@ import (
55
"database/sql"
66
"errors"
77
"fmt"
8-
"log"
98
"time"
109

1110
sq "github.com/Masterminds/squirrel"
1211
"github.com/google/uuid"
13-
"github.com/jackc/pgx/v5"
1412
"github.com/jackc/pgx/v5/pgxpool"
1513

1614
"sensorbucket.nl/sensorbucket/internal/pagination"
@@ -353,9 +351,8 @@ func (s *MeasurementStorePSQL) FindOrCreateDatastream(ctx context.Context, tenan
353351
}
354352

355353
func (s *MeasurementStorePSQL) StoreMeasurements(ctx context.Context, measurements []measurements.Measurement) error {
356-
var batch pgx.Batch
357354
for _, measurement := range measurements {
358-
batch.Queue(`
355+
_, err := s.databasePool.Exec(ctx, `
359356
INSERT INTO measurements (
360357
uplink_message_id,
361358
organisation_id,
@@ -485,17 +482,9 @@ INSERT INTO measurements (
485482
measurement.FeatureOfInterestProperties,
486483
measurement.CreatedAt,
487484
)
488-
}
489-
490-
batchResult := s.databasePool.SendBatch(ctx, &batch)
491-
defer batchResult.Close()
492-
493-
for range len(measurements) {
494-
_, err := batchResult.Exec()
495485
if err != nil {
496-
log.Printf("Batch inser resulted in an error: %s\n", err.Error())
486+
logger.Error("Measurement insert failed", "error", err, "tracing_id", measurement.UplinkMessageID)
497487
}
498488
}
499-
500489
return nil
501490
}

0 commit comments

Comments
 (0)