remove some more nolints

Author: pdschubert

include/phasar/PhasarLLVM/Passes/ValueAnnotationPass.h

@@ -40,8 +40,8 @@ class ValueAnnotationPass
     : public llvm::AnalysisInfoMixin<ValueAnnotationPass> {
 private:
   friend llvm::AnalysisInfoMixin<ValueAnnotationPass>;
-  static llvm::AnalysisKey Key; // NOLINT
-  static size_t UniqueValueId;  // NOLINT
+  static llvm::AnalysisKey Key;
+  static size_t UniqueValueId;
 
 public:
   explicit ValueAnnotationPass();

include/phasar/PhasarPass/Options.h

@@ -15,25 +15,25 @@
 
 #include "llvm/Support/CommandLine.h"
 
-extern llvm::cl::OptionCategory PhASARCategory; // NOLINT
+extern llvm::cl::OptionCategory PhASARCategory;
 
 namespace psr {
 
-extern std::string DataFlowAnalysis; // NOLINT
+extern std::string DataFlowAnalysis;
 
-extern std::string PointerAnalysis; // NOLINT
+extern std::string PointerAnalysis;
 
-extern std::string CallGraphAnalysis; // NOLINT
+extern std::string CallGraphAnalysis;
 
-extern std::vector<std::string> EntryPoints; // NOLINT
+extern std::vector<std::string> EntryPoints;
 
-extern std::string PammOutputFile; // NOLINT
+extern std::string PammOutputFile;
 
-extern bool PrintEdgeRecorder; // NOLINT
+extern bool PrintEdgeRecorder;
 
-extern bool InitLogger; // NOLINT
+extern bool InitLogger;
 
-extern bool DumpResults; // NOLINT
+extern bool DumpResults;
 
 } // namespace psr
 

include/phasar/PhasarPass/PhasarPass.h

@@ -22,7 +22,7 @@ namespace psr {
 
 class PhasarPass : public llvm::ModulePass {
 public:
-  static inline char ID = 12; // NOLINT FIXME: make const when LLVM supports it
+  static inline char ID = 12;
 
   explicit PhasarPass();
   PhasarPass(const PhasarPass &) = delete;

lib/PhasarLLVM/Passes/ExampleModulePass.cpp

@@ -18,7 +18,7 @@ using namespace psr;
 
 namespace psr {
 
-llvm::AnalysisKey ExampleModulePass::Key; // NOLINT
+llvm::AnalysisKey ExampleModulePass::Key;
 
 ExampleModulePass::ExampleModulePass() = default;
 

lib/PhasarLLVM/Passes/ValueAnnotationPass.cpp

@@ -35,9 +35,9 @@ using namespace psr;
 
 namespace psr {
 
-llvm::AnalysisKey ValueAnnotationPass::Key; // NOLINT
+llvm::AnalysisKey ValueAnnotationPass::Key;
 
-size_t ValueAnnotationPass::UniqueValueId = 0; // NOLINT
+size_t ValueAnnotationPass::UniqueValueId = 0;
 
 ValueAnnotationPass::ValueAnnotationPass() = default;
 

lib/PhasarPass/PhasarPrinterPass.cpp

@@ -48,7 +48,7 @@ void PhasarPrinterPass::getAnalysisUsage(llvm::AnalysisUsage &AU) const {
 void PhasarPrinterPass::releaseMemory() {}
 
 static llvm::RegisterPass<PhasarPrinterPass>
-    Phasar("phasar-printer", "PhASAR Printer Pass", // NOLINT
+    Phasar("phasar-printer", "PhASAR Printer Pass",
            false /* Only looks at CFG */, false /* Analysis Pass */);
 
 } // namespace psr