Fixes linking issue, where PTS requires getNumGlobals

We need to move getNumGlobals into the ProjectIRDB header because the
current implementation of the PointsToSet constructor uses it, however,
phasar_db(ProjectIRDB) links against phasar_pointer, so we cannot link
PointsToSet against phasar_db. By defining the function in the header we
cirmumvent this issue, however, we should be careful to not introduce
cyclic dependencies in the future.

Author: vulder

include/phasar/DB/ProjectIRDB.h

@@ -172,7 +172,13 @@ class ProjectIRDB {
     return IDInstructionMapping.size();
   }
 
-  [[nodiscard]] std::size_t getNumGlobals() const;
+  [[nodiscard]] std::size_t getNumGlobals() const {
+    std::size_t Ret = 0;
+    for (const auto &[File, Module] : Modules) {
+      Ret += Module->global_size();
+    }
+    return Ret;
+  }
 
   [[nodiscard]] llvm::Instruction *getInstruction(std::size_t Id);
 

lib/DB/ProjectIRDB.cpp

@@ -237,14 +237,6 @@ llvm::Module *ProjectIRDB::getModule(const std::string &ModuleName) {
   return nullptr;
 }
 
-std::size_t ProjectIRDB::getNumGlobals() const {
-  std::size_t Ret = 0;
-  for (const auto &[File, Module] : Modules) {
-    Ret += Module->global_size();
-  }
-  return Ret;
-}
-
 llvm::Instruction *ProjectIRDB::getInstruction(std::size_t Id) {
   if (IDInstructionMapping.count(Id)) {
     return IDInstructionMapping[Id];