incorporate feedback from Fabian in PR

Martin Mory · Martin Mory · commit acab8c179af7 · 2021-09-28T11:57:00.000+02:00
diff --git a/lib/Utils/LLVMShorthands.cpp b/lib/Utils/LLVMShorthands.cpp
@@ -435,14 +435,15 @@ ModulesToSlotTracker::getSlotTrackerForModule(const llvm::Module *M) {
   if (M == nullptr && ret == nullptr) {
     ret = std::make_unique<llvm::ModuleSlotTracker>(M);
   }
+  assert(ret != nullptr && "no ModuleSlotTracker instance for module cached");
   return *ret;
 }
 
 void ModulesToSlotTracker::updateMSTForModule(const llvm::Module *M) {
   MToST[M] = std::make_unique<llvm::ModuleSlotTracker>(M);
 }
 void ModulesToSlotTracker::deleteMSTForModule(const llvm::Module *M) {
-  MToST[M] = nullptr;
+  MToST.erase(M);
 }
 
 } // namespace psr

Original file line number	Diff line number	Diff line change
`@@ -435,14 +435,15 @@ ModulesToSlotTracker::getSlotTrackerForModule(const llvm::Module *M) {`
`435`	`435`	`if (M == nullptr && ret == nullptr) {`
`436`	`436`	`ret = std::make_unique<llvm::ModuleSlotTracker>(M);`
`437`	`437`	`}`
	`438`	`+ assert(ret != nullptr && "no ModuleSlotTracker instance for module cached");`
`438`	`439`	`return *ret;`
`439`	`440`	`}`
`440`	`441`
`441`	`442`	`void ModulesToSlotTracker::updateMSTForModule(const llvm::Module *M) {`
`442`	`443`	`MToST[M] = std::make_unique<llvm::ModuleSlotTracker>(M);`
`443`	`444`	`}`
`444`	`445`	`void ModulesToSlotTracker::deleteMSTForModule(const llvm::Module *M) {`
`445`		`- MToST[M] = nullptr;`
	`446`	`+ MToST.erase(M);`
`446`	`447`	`}`
`447`	`448`
`448`	`449`	`} // namespace psr`