Merge branch 'f-ClangTidyFixIDEXTaint' into f-ClangTidyFixIDEGeneralizedLCA

Author: Martin Mory

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/IFDSFieldSensTaintAnalysis/FlowFunctions/MapTaintedValuesToCaller.h

@@ -20,8 +20,7 @@ class MapTaintedValuesToCaller : public FlowFunction<ExtendedValue> {
   MapTaintedValuesToCaller(const llvm::CallInst *CallInst,
                            const llvm::ReturnInst *RetInst,
                            TraceStats &TraceStats, const ExtendedValue &ZV)
-      : CallInst(CallInst), RetInst(RetInst), TraceStats(TraceStats),
-        ZV(ZV) {}
+      : CallInst(CallInst), RetInst(RetInst), TraceStats(TraceStats), ZV(ZV) {}
   ~MapTaintedValuesToCaller() override = default;
 
   std::set<ExtendedValue> computeTargets(ExtendedValue Fact) override;

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/IFDSFieldSensTaintAnalysis/Utils/Log.h

@@ -10,9 +10,8 @@
 #define LOG_INFO(x)                                                            \
   do {                                                                         \
     llvm::outs() << "[ENV_TRACE] " << x << "\n"; /*NOLINT*/                    \
-    \
-    llvm::outs()                                                               \
-        .flush();                                                              \
+                                                                               \
+    llvm::outs().flush();                                                      \
   } while (0)
 
 #ifdef DEBUG_BUILD

include/phasar/PhasarLLVM/DataFlowSolver/Mono/Contexts/CallStringCTX.h

@@ -99,4 +99,4 @@ template <typename N, unsigned K> struct hash<psr::CallStringCTX<N, K>> {
 
 } // namespace std
 
-#endif
+#endif

lib/PhasarLLVM/ControlFlow/Resolver/Resolver.cpp

@@ -77,7 +77,7 @@ Resolver::Resolver(ProjectIRDB &IRDB, LLVMTypeHierarchy &TH)
 
 const llvm::Function *
 Resolver::getNonPureVirtualVFTEntry(const llvm::StructType *T, unsigned Idx,
-                                    const llvm::CallBase */*CallSite*/) {
+                                    const llvm::CallBase * /*CallSite*/) {
   if (TH && TH->hasVFTable(T)) {
     const auto *Target = TH->getVFTable(T)->getFunction(Idx);
     if (Target && Target->getName() != "__cxa_pure_virtual") {

lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/ComposeEdgeFunction.cpp

@@ -18,7 +18,8 @@ namespace psr::XTaint {
 ComposeEdgeFunction::ComposeEdgeFunction(BasicBlockOrdering &BBO,
                                          EdgeFunctionPtrType F,
                                          EdgeFunctionPtrType G)
-    : EdgeFunctionBase(EFKind::Compose, BBO), F(std::move(F)), G(std::move(G)) {}
+    : EdgeFunctionBase(EFKind::Compose, BBO), F(std::move(F)), G(std::move(G)) {
+}
 
 auto ComposeEdgeFunction::computeTarget(l_t Source) -> l_t {
   return G->computeTarget(F->computeTarget(Source));

lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/JoinEdgeFunction.cpp

@@ -23,7 +23,8 @@ namespace psr::XTaint {
 JoinEdgeFunction::JoinEdgeFunction(BasicBlockOrdering &BBO,
                                    SubEdgeFuctionsTy &&SubEF,
                                    const EdgeDomain &Seed)
-    : EdgeFunctionBase(EFKind::Join, BBO), SubEF(std::move(SubEF)), Seed(Seed) {}
+    : EdgeFunctionBase(EFKind::Join, BBO), SubEF(std::move(SubEF)), Seed(Seed) {
+}
 JoinEdgeFunction::JoinEdgeFunction(
     BasicBlockOrdering &BBO, std::initializer_list<EdgeFunctionPtrType> SubEF,
     const EdgeDomain &Seed)

lib/PhasarLLVM/Plugins/IDETabulationProblemTestPlugin.h

@@ -84,4 +84,5 @@ makeIDETabulationProblemtestPlugin(const ProjectIRDB *IRDB,
                                    std::set<std::string> EntryPoints);
 
 } // namespace psr
-#endif
+
+#endif

unittests/PhasarLLVM/ControlFlow/LLVMBasedICFGGlobCtorDtorTest.cpp

@@ -455,7 +455,8 @@ TEST(LLVMBasedICFGGlobCtorDtorTest, LCATest5) {
 
   IDESolver Solver(Problem);
 
-  const auto *GlobalDtor = ICFG.getRegisteredDtorsCallerOrNull(IRDB.getWPAModule());
+  const auto *GlobalDtor =
+      ICFG.getRegisteredDtorsCallerOrNull(IRDB.getWPAModule());
 
   ASSERT_NE(nullptr, GlobalDtor);
 

unittests/PhasarLLVM/DataFlowSolver/IfdsIde/EdgeFunctionSingletonFactoryTest.cpp

@@ -19,7 +19,8 @@ struct TestEdgeFunction
 
   int computeTarget(int /*Source*/) override { return 42; }
 
-  EdgeFunctionPtrType composeWith(EdgeFunctionPtrType /*SecondFunction*/) override {
+  EdgeFunctionPtrType
+  composeWith(EdgeFunctionPtrType /*SecondFunction*/) override {
     return this->shared_from_this();
   };