few minor things

Author: pdschubert

include/phasar/PhasarLLVM/Plugins/Interfaces/IfdsIde/IDETabulationProblemPlugin.h

@@ -91,7 +91,7 @@ extern std::map<std::string,
                     const ProjectIRDB *IRDB, const LLVMTypeHierarchy *TH,
                     const LLVMBasedICFG *ICF, LLVMPointsToInfo *PT,
                     std::set<std::string> EntryPoints)>
-    IDETabulationProblemPluginFactory; // NOLINT
+    IDETabulationProblemPluginFactory;
 
 } // namespace psr
 

include/phasar/PhasarLLVM/Plugins/Interfaces/Mono/InterMonoProblemPlugin.h

@@ -56,7 +56,7 @@ extern std::map<std::string,
                     const ProjectIRDB *IRDB, const LLVMTypeHierarchy *TH,
                     const LLVMBasedICFG *ICF, LLVMPointsToInfo *PT,
                     std::set<std::string> EntryPoints)>
-    InterMonoProblemPluginFactory; // NOLINT
+    InterMonoProblemPluginFactory;
 
 } // namespace psr
 

include/phasar/PhasarLLVM/Plugins/Interfaces/Mono/IntraMonoProblemPlugin.h

@@ -55,7 +55,7 @@ extern std::map<std::string,
                     const ProjectIRDB *IRDB, const LLVMTypeHierarchy *TH,
                     const LLVMBasedCFG *CF, LLVMPointsToInfo *PT,
                     std::set<std::string> EntryPoints)>
-    IntraMonoProblemPluginFactory; // NOLINT
+    IntraMonoProblemPluginFactory;
 
 } // namespace psr
 

include/phasar/PhasarLLVM/Plugins/PluginFactories.h

@@ -7,8 +7,8 @@
  *     Philipp Schubert and others
  *****************************************************************************/
 
-#ifndef PHASAR_PHASARLLVM_PLUGINS_PLUGINFACTORIES_H_
-#define PHASAR_PHASARLLVM_PLUGINS_PLUGINFACTORIES_H_
+#ifndef PHASAR_PHASARLLVM_PLUGINS_PLUGINFACTORIES_H
+#define PHASAR_PHASARLLVM_PLUGINS_PLUGINFACTORIES_H
 
 // Problem constructors
 #include "phasar/PhasarLLVM/Plugins/PluginCtors.h"

lib/PhasarLLVM/Plugins/IDETabulationProblemTestPlugin.cxx

@@ -40,7 +40,7 @@ IDETabulationProblemTestPlugin::IDETabulationProblemTestPlugin(
 }
 
 const FlowFact *IDETabulationProblemTestPlugin::createZeroValue() const {
-  static auto *Zero = new ValueFlowFactWrapper(nullptr); // NOLINT
+  static auto *Zero = new ValueFlowFactWrapper(nullptr);
   return Zero;
 }
 

lib/PhasarLLVM/Plugins/IFDSSFB901TaintAnalysis.cxx

@@ -58,7 +58,7 @@ const FlowFact *IFDSSFB901TaintAnalysis::createZeroValue() const {
   // static auto zero =
   //     std::make_unique<ValueFlowFactWrapper>(LLVMZeroValue::getInstance());
   // return zero.get();
-  static auto *Zero = new ValueFlowFactWrapper(nullptr); // NOLINT
+  static auto *Zero = new ValueFlowFactWrapper(nullptr);
   return Zero;
 }
 

lib/PhasarLLVM/Plugins/PluginFactories.cpp

@@ -7,24 +7,26 @@
  *     Philipp Schubert and others
  *****************************************************************************/
 
+#include <memory>
+
 #include "phasar/PhasarLLVM/Plugins/PluginFactories.h"
 
-using namespace std;
 using namespace psr;
 
 namespace psr {
 
 // Maps for registering the plugins
-map<string, IFDSPluginConstructor> IFDSTabulationProblemPluginFactory; // NOLINT
+std::map<std::string, IFDSPluginConstructor> IFDSTabulationProblemPluginFactory;
 
-map<string, IDEPluginConstructor> IDETabulationProblemPluginFactory; // NOLINT
+std::map<std::string, IDEPluginConstructor> IDETabulationProblemPluginFactory;
 
-map<string, IntraMonoPluginConstructor> IntraMonoProblemPluginFactory; // NOLINT
+std::map<std::string, IntraMonoPluginConstructor> IntraMonoProblemPluginFactory;
 
-map<string, InterMonoPluginConstructor> InterMonoProblemPluginFactory; // NOLINT
+std::map<std::string, InterMonoPluginConstructor> InterMonoProblemPluginFactory;
 
-map<string, unique_ptr<ICFGPlugin> (*)(ProjectIRDB &,
-                                       const vector<string> &EntryPoints)>
-    ICFGPluginFactory; // NOLINT
+std::map<std::string,
+         std::unique_ptr<ICFGPlugin> (*)(
+             ProjectIRDB &, const std::vector<std::string> &EntryPoints)>
+    ICFGPluginFactory;
 
 } // namespace psr