pass StringRef by value, make Logger.cpp compile again after github screwup

Author: MMory

include/phasar/Utils/Logger.h

@@ -55,7 +55,7 @@ class Logger final {
   getLogStream(std::optional<SeverityLevel> Level,
                const std::optional<llvm::StringRef> &Category);
 
-  static bool logCategory(const llvm::StringRef &Category,
+  static bool logCategory(llvm::StringRef Category,
                           std::optional<SeverityLevel> Level);
 
   static void addLinePrefix(llvm::raw_ostream &,
@@ -71,7 +71,7 @@ class Logger final {
       const std::optional<std::string> &Category = std::nullopt);
 
   [[nodiscard]] static bool initializeFileLogger(
-      const llvm::StringRef &Filename,
+      llvm::StringRef Filename,
       std::optional<SeverityLevel> Level = std::nullopt,
       const std::optional<std::string> &Category = std::nullopt,
       bool Append = false);

lib/Utils/Logger.cpp

@@ -68,7 +68,7 @@ void Logger::initializeStderrLogger(
 }
 
 [[nodiscard]] bool Logger::initializeFileLogger(
-    const llvm::StringRef &Filename, std::optional<SeverityLevel> Level,
+    llvm::StringRef Filename, std::optional<SeverityLevel> Level,
     const std::optional<std::string> &Category, bool Append) {
   LoggingEnabled = true;
   if (Category.has_value()) {
@@ -100,7 +100,6 @@ void Logger::initializeStderrLogger(
     llvm::errs() << EC.message() << '\n';
     return false;
   }
-  }
   return true;
 }
 
@@ -161,7 +160,7 @@ llvm::raw_ostream &Logger::getLogStreamFromStreamVariant(
   return It->second;
 }
 
-bool Logger::logCategory(const llvm::StringRef &Category,
+bool Logger::logCategory(llvm::StringRef Category,
                          std::optional<SeverityLevel> Level) {
   auto CategoryLookupIt = CategoriesToStreamVariant.find(Category);
   if (CategoryLookupIt == CategoriesToStreamVariant.end()) {