Fix edge functions

fabianbs96 · fabianbs96 · commit 49d438ae66c2 · 2022-10-26T15:40:35.000+02:00
diff --git a/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/EdgeFunctions.h b/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/EdgeFunctions.h
@@ -119,7 +119,7 @@ class AllTop : public EdgeFunction<L>,
   const L TopElement;
 
 public:
-  AllTop(const L TopElement) : TopElement(std::move(TopElement)) {}
+  AllTop(L TopElement) : TopElement(std::move(TopElement)) {}
 
   ~AllTop() override = default;
 
@@ -160,33 +160,18 @@ class AllBottom : public EdgeFunction<L>,
   const L BottomElement;
 
 public:
-  AllBottom(const L BottomElement) : BottomElement(std::move(BottomElement)) {}
+  AllBottom(L BottomElement) : BottomElement(std::move(BottomElement)) {}
 
   ~AllBottom() override = default;
 
   L computeTarget(L /*Source*/) override { return BottomElement; }
 
-  EdgeFunctionPtrType composeWith(EdgeFunctionPtrType SecondFunction) override {
-    if (auto *AB = dynamic_cast<AllBottom<L> *>(SecondFunction.get())) {
-      return this->shared_from_this();
-    }
-    if (auto *EI = dynamic_cast<EdgeIdentity<L> *>(SecondFunction.get())) {
-      return this->shared_from_this();
-    }
-    return SecondFunction->composeWith(this->shared_from_this());
+  EdgeFunctionPtrType
+  composeWith(EdgeFunctionPtrType /*SecondFunction*/) override {
+    return this->shared_from_this();
   }
 
-  EdgeFunctionPtrType joinWith(EdgeFunctionPtrType OtherFunction) override {
-    if (OtherFunction.get() == this ||
-        OtherFunction->equal_to(this->shared_from_this())) {
-      return this->shared_from_this();
-    }
-    if (auto *Alltop = dynamic_cast<AllTop<L> *>(OtherFunction.get())) {
-      return this->shared_from_this();
-    }
-    if (auto *EI = dynamic_cast<EdgeIdentity<L> *>(OtherFunction.get())) {
-      return this->shared_from_this();
-    }
+  EdgeFunctionPtrType joinWith(EdgeFunctionPtrType /*OtherFunction*/) override {
     return this->shared_from_this();
   }
 
diff --git a/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEInstInteractionAnalysis.h b/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEInstInteractionAnalysis.h
@@ -675,7 +675,7 @@ class IDEInstInteractionAnalysisT
     //                     0
     //
     if (isZeroValue(CurrNode) && isZeroValue(SuccNode)) {
-      return std::make_shared<AllBottom<l_t>>(bottomElement());
+      return EdgeIdentity<l_t>::getInstance();
     }
     // check if the user has registered a fact generator function
     l_t UserEdgeFacts = BitVectorSet<e_t>();
diff --git a/include/phasar/PhasarLLVM/Utils/LLVMShorthands.h b/include/phasar/PhasarLLVM/Utils/LLVMShorthands.h
@@ -24,13 +24,12 @@
 #include "llvm/IR/Instructions.h"
 #include "llvm/IR/ModuleSlotTracker.h"
 #include "llvm/IR/Value.h"
+#include "llvm/Support/Compiler.h"
 
 #include "phasar/Utils/Utilities.h"
 
 namespace psr {
 
-static inline void deleteValue(llvm::Value *V) { V->deleteValue(); }
-
 /**
  * @brief Checks if the given LLVM Value is a LLVM Function Pointer.
  * @param V LLVM Value.
@@ -73,6 +72,9 @@ std::string llvmIRToStableString(const llvm::Value *V);
  */
 std::string llvmIRToShortString(const llvm::Value *V);
 
+LLVM_DUMP_METHOD void dumpIRValue(const llvm::Value *V);
+LLVM_DUMP_METHOD void dumpIRValue(const llvm::Instruction *V);
+
 /**
  * @brief Returns all LLVM Global Values that are used in the given LLVM
  * Function.
diff --git a/lib/PhasarLLVM/ControlFlow/Resolver/DTAResolver.cpp b/lib/PhasarLLVM/ControlFlow/Resolver/DTAResolver.cpp
@@ -22,6 +22,7 @@
 #include "llvm/IR/InstIterator.h"
 #include "llvm/IR/Instruction.h"
 #include "llvm/IR/Module.h"
+#include "llvm/IR/Operator.h"
 
 #include "phasar/PhasarLLVM/ControlFlow/Resolver/DTAResolver.h"
 #include "phasar/PhasarLLVM/TypeHierarchy/LLVMTypeHierarchy.h"
@@ -113,10 +114,7 @@ bool DTAResolver::heuristicAntiConstructorVtablePos(
         if (BitcastExpr->isCast()) {
           if (auto *ConstGep = llvm::dyn_cast<llvm::ConstantExpr>(
                   BitcastExpr->getOperand(0))) {
-            std::unique_ptr<llvm::Instruction, decltype(&deleteValue)>
-                GepAsInst(ConstGep->getAsInstruction(), &deleteValue);
-            if (auto *Gep =
-                    llvm::dyn_cast<llvm::GetElementPtrInst>(GepAsInst.get())) {
+            if (auto *Gep = llvm::dyn_cast<llvm::GEPOperator>(ConstGep)) {
               if (auto *Vtable = llvm::dyn_cast<llvm::Constant>(
                       Gep->getPointerOperand())) {
                 // We can here assume that we found a vtable
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/BinaryEdgeFunction.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/BinaryEdgeFunction.cpp
@@ -35,7 +35,7 @@ BinaryEdgeFunction::composeWith(
   if (dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {
     // print(std::cout << "Compose ");
     // std::cout << " with ALLBOT" << std::endl;
-    return shared_from_this();
+    return SecondFunction;
   }
   return std::make_shared<LCAEdgeFunctionComposer>(this->shared_from_this(),
                                                    SecondFunction, MaxSize);
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/GenConstant.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/GenConstant.cpp
@@ -39,8 +39,7 @@ std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> GenConstant::composeWith(
     std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {
   // std::cout << "GenConstant composing" << std::endl;
   if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(
-          SecondFunction.get()) ||
-      dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {
+          SecondFunction.get())) {
 
     return shared_from_this();
   }
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/IDEGeneralizedLCA.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/IDEGeneralizedLCA.cpp
@@ -301,8 +301,7 @@ IDEGeneralizedLCA::getNormalEdgeFunction(IDEGeneralizedLCA::n_t Curr,
 
   // All_Bottom for zero value
   if (isZeroValue(CurrNode) && isZeroValue(SuccNode)) {
-    static auto AllBot = std::make_shared<AllBottom<l_t>>(bottomElement());
-    return AllBot;
+    return EdgeIdentity<l_t>::getInstance();
   }
   // Check store instruction
   if (const auto *Store = llvm::dyn_cast<llvm::StoreInst>(Curr)) {
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/JoinEdgeFunction.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/JoinEdgeFunction.cpp
@@ -63,7 +63,8 @@ JoinEdgeFunction::composeWith(
     std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {
   // std::cout << "JoinFn composing" << std::endl;
   // TODO be more precise here
-  if (dynamic_cast<GenConstant *>(SecondFunction.get())) {
+  if (dynamic_cast<GenConstant *>(SecondFunction.get()) ||
+      AllBot::isBot(SecondFunction)) {
     return SecondFunction;
   }
   if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(
@@ -81,7 +82,7 @@ JoinEdgeFunction::joinWith(
     return shared_from_this();
   }
   if (AllBot::isBot(OtherFunction)) {
-    return AllBot::getInstance();
+    return OtherFunction;
   }
 
   return std::make_shared<JoinEdgeFunction>(shared_from_this(), OtherFunction,
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/LCAEdgeFunctionComposer.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/LCAEdgeFunctionComposer.cpp
@@ -34,16 +34,12 @@ LCAEdgeFunctionComposer::composeWith(
     std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {
   // see <phasar/PhasarLVM/IfdsIde/IDELinearConstantAnalysis.h>
 
-  if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(
-          SecondFunction.get()) ||
-      dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {
-    return shared_from_this();
-  }
   if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(
           SecondFunction.get())) {
     return shared_from_this();
   }
-  if (dynamic_cast<GenConstant *>(SecondFunction.get())) {
+  if (dynamic_cast<GenConstant *>(SecondFunction.get()) ||
+      AllBot::isBot(SecondFunction)) {
     return SecondFunction;
   }
   auto GPrime = G->composeWith(SecondFunction);
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/TypecastEdgeFunction.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/TypecastEdgeFunction.cpp
@@ -8,6 +8,7 @@
  *****************************************************************************/
 
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/TypecastEdgeFunction.h"
+#include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/AllBot.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/JoinEdgeFunction.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEGeneralizedLCA/LCAEdgeFunctionComposer.h"
 
@@ -21,8 +22,8 @@ TypecastEdgeFunction::computeTarget(IDEGeneralizedLCA::l_t Source) {
 std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>>
 TypecastEdgeFunction::composeWith(
     std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {
-  if (dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {
-    return shared_from_this();
+  if (AllBot::isBot(SecondFunction)) {
+    return SecondFunction;
   }
   return std::make_shared<LCAEdgeFunctionComposer>(shared_from_this(),
                                                    SecondFunction, MaxSize);
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysis.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysis.cpp
@@ -7,37 +7,34 @@
  *     Philipp Schubert and others
  *****************************************************************************/
 
-// #include <functional>
-#include <limits>
-#include <memory>
-#include <utility>
-
-#include "llvm/IR/AbstractCallSite.h"
-#include "llvm/IR/Constants.h"
-#include "llvm/IR/Function.h"
-#include "llvm/IR/Instruction.h"
-#include "llvm/IR/Instructions.h"
-#include "llvm/IR/LLVMContext.h"
-#include "llvm/IR/Type.h"
-#include "llvm/IR/Value.h"
-#include "llvm/Support/Casting.h"
-#include "llvm/Support/MathExtras.h"
-
+#include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysis.h"
 #include "phasar/DB/ProjectIRDB.h"
 #include "phasar/PhasarLLVM/ControlFlow/LLVMBasedICFG.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/EdgeFunctions.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/FlowFunctions.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/LLVMFlowFunctions.h"
 #include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/LLVMZeroValue.h"
-#include "phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysis.h"
 #include "phasar/PhasarLLVM/Pointer/LLVMPointsToInfo.h"
 #include "phasar/PhasarLLVM/TypeHierarchy/LLVMTypeHierarchy.h"
 #include "phasar/PhasarLLVM/Utils/LLVMIRToSrc.h"
 #include "phasar/PhasarLLVM/Utils/LLVMShorthands.h"
 #include "phasar/PhasarPass/Options.h"
 #include "phasar/Utils/Logger.h"
 
-using namespace psr;
+#include "llvm/IR/AbstractCallSite.h"
+#include "llvm/IR/Constants.h"
+#include "llvm/IR/Function.h"
+#include "llvm/IR/Instruction.h"
+#include "llvm/IR/Instructions.h"
+#include "llvm/IR/LLVMContext.h"
+#include "llvm/IR/Type.h"
+#include "llvm/IR/Value.h"
+#include "llvm/Support/Casting.h"
+#include "llvm/Support/MathExtras.h"
+
+#include <limits>
+#include <memory>
+#include <utility>
 
 namespace psr {
 // Initialize debug counter for edge functions
@@ -312,9 +309,12 @@ bool IDELinearConstantAnalysis::isZeroValue(d_t Fact) const {
 std::shared_ptr<EdgeFunction<IDELinearConstantAnalysis::l_t>>
 IDELinearConstantAnalysis::getNormalEdgeFunction(n_t Curr, d_t CurrNode,
                                                  n_t /*Succ*/, d_t SuccNode) {
+  if (isZeroValue(CurrNode) && isZeroValue(SuccNode)) {
+    return EdgeIdentity<l_t>::getInstance();
+  }
+
   // ALL_BOTTOM for zero value
-  if ((isZeroValue(CurrNode) && isZeroValue(SuccNode)) ||
-      (llvm::isa<llvm::AllocaInst>(Curr) && isZeroValue(CurrNode))) {
+  if ((llvm::isa<llvm::AllocaInst>(Curr) && isZeroValue(CurrNode))) {
     PHASAR_LOG_LEVEL(DEBUG, "Case: Zero value.");
     PHASAR_LOG_LEVEL(DEBUG, ' ');
     return std::make_shared<AllBottom<l_t>>(BOTTOM);
@@ -453,14 +453,13 @@ std::shared_ptr<EdgeFunction<IDELinearConstantAnalysis::l_t>>
 IDELinearConstantAnalysis::LCAEdgeFunctionComposer::composeWith(
     std::shared_ptr<EdgeFunction<l_t>> SecondFunction) {
   if (dynamic_cast<AllBottom<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
-  }
-  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
+    return SecondFunction;
   }
-  if (dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
+  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get()) ||
+      dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
     return this->shared_from_this();
   }
+
   return F->composeWith(G->composeWith(SecondFunction));
 }
 
@@ -489,13 +488,9 @@ IDELinearConstantAnalysis::GenConstant::computeTarget(
 std::shared_ptr<EdgeFunction<IDELinearConstantAnalysis::l_t>>
 IDELinearConstantAnalysis::GenConstant::composeWith(
     std::shared_ptr<EdgeFunction<l_t>> SecondFunction) {
-  if (dynamic_cast<AllBottom<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
-  }
-  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
-  }
-  if (dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
+
+  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get()) ||
+      dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
     return this->shared_from_this();
   }
 
@@ -611,18 +606,17 @@ IDELinearConstantAnalysis::BinOp::computeTarget(l_t Source) {
 std::shared_ptr<EdgeFunction<IDELinearConstantAnalysis::l_t>>
 IDELinearConstantAnalysis::BinOp::composeWith(
     std::shared_ptr<EdgeFunction<l_t>> SecondFunction) {
-  if (dynamic_cast<AllBottom<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
-  }
-  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get())) {
-    return this->shared_from_this();
+  if (dynamic_cast<AllBottom<l_t> *>(SecondFunction.get()) ||
+      dynamic_cast<GenConstant *>(SecondFunction.get())) {
+    return SecondFunction;
   }
-  if (dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
+  if (dynamic_cast<EdgeIdentity<l_t> *>(SecondFunction.get()) ||
+      dynamic_cast<LCAIdentity *>(SecondFunction.get())) {
     return this->shared_from_this();
   }
-  if (dynamic_cast<GenConstant *>(SecondFunction.get())) {
-    return SecondFunction;
-  }
+
+  // TODO: Optimize Binop::composeWith(BinOp)
+
   return std::make_shared<LCAEdgeFunctionComposer>(this->shared_from_this(),
                                                    SecondFunction);
 }
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDESecureHeapPropagation.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDESecureHeapPropagation.cpp
@@ -254,9 +254,6 @@ void IDESecureHeapPropagation::IdentityEdgeFunction::print(
 std::shared_ptr<EdgeFunction<IDESecureHeapPropagation::l_t>>
 IDESecureHeapPropagation::IdentityEdgeFunction::composeWith(
     std::shared_ptr<EdgeFunction<l_t>> SecondFunction) {
-  if (dynamic_cast<AllBottom<l_t> *>(SecondFunction.get())) {
-    return shared_from_this();
-  }
   return SecondFunction;
 }
 std::shared_ptr<IDESecureHeapPropagation::IdentityEdgeFunction>
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDETypeStateAnalysis.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDETypeStateAnalysis.cpp
@@ -507,7 +507,7 @@ IDETypeStateAnalysis::TSEdgeFunction::composeWith(
 
   if (auto *AB = dynamic_cast<AllBottom<IDETypeStateAnalysis::l_t> *>(
           SecondFunction.get())) {
-    return this->shared_from_this();
+    return SecondFunction;
   }
   if (auto *EI = dynamic_cast<EdgeIdentity<IDETypeStateAnalysis::l_t> *>(
           SecondFunction.get())) {
diff --git a/lib/PhasarLLVM/TypeHierarchy/LLVMTypeHierarchy.cpp b/lib/PhasarLLVM/TypeHierarchy/LLVMTypeHierarchy.cpp
@@ -32,6 +32,7 @@
 #include "llvm/IR/InstIterator.h"
 #include "llvm/IR/Instructions.h"
 #include "llvm/IR/Module.h"
+#include "llvm/IR/Operator.h"
 
 #include "phasar/Config/Configuration.h"
 #include "phasar/DB/ProjectIRDB.h"
@@ -168,14 +169,13 @@ LLVMTypeHierarchy::getSubTypes(const llvm::Module & /*M*/,
             llvm::dyn_cast<llvm::ConstantStruct>(TI->getInitializer())) {
       for (const auto &Op : I->operands()) {
         if (auto *CE = llvm::dyn_cast<llvm::ConstantExpr>(Op)) {
-          std::unique_ptr<llvm::Instruction, decltype(&deleteValue)> AsI(
-              CE->getAsInstruction(), &deleteValue);
-          if (auto *BC = llvm::dyn_cast<llvm::BitCastInst>(AsI.get())) {
+
+          if (auto *BC = llvm::dyn_cast<llvm::BitCastOperator>(CE)) {
             if (BC->getOperand(0)->hasName()) {
               auto Name = BC->getOperand(0)->getName();
               if (Name.find(TypeInfoPrefix) != llvm::StringRef::npos) {
                 auto ClearName =
-                    removeTypeInfoPrefix(llvm::demangle(Name.str().c_str()));
+                    removeTypeInfoPrefix(llvm::demangle(Name.str()));
                 if (const auto *Type = ClearNameTypeMap[ClearName]) {
                   SubTypes.push_back(Type);
                 }
diff --git a/lib/PhasarLLVM/Utils/LLVMShorthands.cpp b/lib/PhasarLLVM/Utils/LLVMShorthands.cpp
@@ -212,6 +212,13 @@ std::string llvmIRToShortString(const llvm::Value *V) {
   return IRBuffer;
 }
 
+void dumpIRValue(const llvm::Value *V) {
+  llvm::outs() << llvmIRToString(V) << '\n';
+}
+void dumpIRValue(const llvm::Instruction *V) {
+  llvm::outs() << llvmIRToString(V) << '\n';
+}
+
 std::vector<const llvm::Value *>
 globalValuesUsedinFunction(const llvm::Function *F) {
   std::vector<const llvm::Value *> GlobalsUsed;
diff --git a/test/llvm_test_code/linear_constant/while_05.cpp b/test/llvm_test_code/linear_constant/while_05.cpp
@@ -0,0 +1,14 @@
+extern int rand();
+
+int foo(int x) {
+  while (rand()) {
+    x++;
+  }
+  return x;
+}
+
+int main() {
+  int a = 3;
+  int b = foo(a);
+  return b;
+}
diff --git a/unittests/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysisTest.cpp b/unittests/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDELinearConstantAnalysisTest.cpp
diff --git a/unittests/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDETSAnalysisFileIOTest.cpp b/unittests/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDETSAnalysisFileIOTest.cpp

Original file line number	Diff line number	Diff line change
`@@ -675,7 +675,7 @@ class IDEInstInteractionAnalysisT`
`675`	`675`	`// 0`
`676`	`676`	`//`
`677`	`677`	`if (isZeroValue(CurrNode) && isZeroValue(SuccNode)) {`
`678`		`- return std::make_shared<AllBottom<l_t>>(bottomElement());`
	`678`	`+ return EdgeIdentity<l_t>::getInstance();`
`679`	`679`	`}`
`680`	`680`	`// check if the user has registered a fact generator function`
`681`	`681`	`l_t UserEdgeFacts = BitVectorSet<e_t>();`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ BinaryEdgeFunction::composeWith(`
`35`	`35`	`if (dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {`
`36`	`36`	`// print(std::cout << "Compose ");`
`37`	`37`	`// std::cout << " with ALLBOT" << std::endl;`
`38`		`- return shared_from_this();`
	`38`	`+ return SecondFunction;`
`39`	`39`	`}`
`40`	`40`	`return std::make_shared<LCAEdgeFunctionComposer>(this->shared_from_this(),`
`41`	`41`	`SecondFunction, MaxSize);`
Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,7 @@ std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> GenConstant::composeWith(`
`39`	`39`	`std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {`
`40`	`40`	`// std::cout << "GenConstant composing" << std::endl;`
`41`	`41`	`if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(`
`42`		`- SecondFunction.get()) \|\|`
`43`		`- dynamic_cast<AllBottom<IDEGeneralizedLCA::l_t> *>(SecondFunction.get())) {`
	`42`	`+ SecondFunction.get())) {`
`44`	`43`
`45`	`44`	`return shared_from_this();`
`46`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -301,8 +301,7 @@ IDEGeneralizedLCA::getNormalEdgeFunction(IDEGeneralizedLCA::n_t Curr,`
`301`	`301`
`302`	`302`	`// All_Bottom for zero value`
`303`	`303`	`if (isZeroValue(CurrNode) && isZeroValue(SuccNode)) {`
`304`		`- static auto AllBot = std::make_shared<AllBottom<l_t>>(bottomElement());`
`305`		`- return AllBot;`
	`304`	`+ return EdgeIdentity<l_t>::getInstance();`
`306`	`305`	`}`
`307`	`306`	`// Check store instruction`
`308`	`307`	`if (const auto *Store = llvm::dyn_cast<llvm::StoreInst>(Curr)) {`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,8 @@ JoinEdgeFunction::composeWith(`
`63`	`63`	`std::shared_ptr<EdgeFunction<IDEGeneralizedLCA::l_t>> SecondFunction) {`
`64`	`64`	`// std::cout << "JoinFn composing" << std::endl;`
`65`	`65`	`// TODO be more precise here`
`66`		`- if (dynamic_cast<GenConstant *>(SecondFunction.get())) {`
	`66`	`+ if (dynamic_cast<GenConstant *>(SecondFunction.get()) \|\|`
	`67`	`+ AllBot::isBot(SecondFunction)) {`
`67`	`68`	`return SecondFunction;`
`68`	`69`	`}`
`69`	`70`	`if (dynamic_cast<EdgeIdentity<IDEGeneralizedLCA::l_t> *>(`
`@@ -81,7 +82,7 @@ JoinEdgeFunction::joinWith(`
`81`	`82`	`return shared_from_this();`
`82`	`83`	`}`
`83`	`84`	`if (AllBot::isBot(OtherFunction)) {`
`84`		`- return AllBot::getInstance();`
	`85`	`+ return OtherFunction;`
`85`	`86`	`}`
`86`	`87`
`87`	`88`	`return std::make_shared<JoinEdgeFunction>(shared_from_this(), OtherFunction,`