minor fixes

Author: pdschubert

.clang-tidy

@@ -53,6 +53,8 @@ CheckOptions:
     value:           (c|d|d1|d2|d3|d4|d5|d5_restoredCtx|eP|f|f3|f4|f5|fCalleeSummary|g|n|dPrime|fPrime)
   - key:             readability-identifier-naming.ParameterIgnoredRegexp
     value:           (d|d1|d2|d3|d4|d5|eP|f|n)
+  - key:             readability-identifier-naming.FunctionIgnoredRegexp
+    value:           (try_emplace|from_json|to_json)
   - key:             cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
     value:           1
   - key:             cppcoreguidelines-special-member-functions.AllowMissingMoveFunctions

include/phasar/Utils/EquivalenceClassMap.h

@@ -99,7 +99,7 @@ template <typename KeyT, typename ValueT> struct EquivalenceClassMap {
   // Inserts Key into the corresponding equivalence class for Value. If Value
   // is not already in the map a new equivalence class is created.
   template <typename... Ts>
-  insert_return_type try_emplace(KeyT &&Key, Ts &&...Args) { // NOLINT
+  insert_return_type try_emplace(KeyT &&Key, Ts &&...Args) {
     ValueT Val{std::forward<Ts...>(Args...)};
 
     for (auto &KVPair : StoredData) {
@@ -115,7 +115,7 @@ template <typename KeyT, typename ValueT> struct EquivalenceClassMap {
   // Inserts Key into the corresponding equivalence class for Value. If Value
   // is not already in the map a new equivalence class is created.
   template <typename... Ts>
-  insert_return_type try_emplace(const KeyT &Key, Ts &&...Args) { // NOLINT
+  insert_return_type try_emplace(const KeyT &Key, Ts &&...Args) {
     ValueT Val{std::forward<Ts...>(Args...)};
 
     for (auto &KVPair : StoredData) {

include/phasar/Utils/LLVMIRToSrc.h

@@ -71,10 +71,10 @@ struct SourceCodeInfo {
 
 /// Used from the JSON library internally to implicitly convert between json and
 /// SourceCodeInfo
-void from_json(const nlohmann::json &J, SourceCodeInfo &Info); // NOLINT
+void from_json(const nlohmann::json &J, SourceCodeInfo &Info);
 /// Used from the JSON library internally to implicitly convert between json and
 /// SourceCodeInfo
-void to_json(nlohmann::json &J, const SourceCodeInfo &Info); // NOLINT
+void to_json(nlohmann::json &J, const SourceCodeInfo &Info);
 
 SourceCodeInfo getSrcCodeInfoFromIR(const llvm::Value *V);
 

include/phasar/Utils/Logger.h

@@ -51,7 +51,7 @@ SeverityLevel toSeverityLevel(const std::string &S);
 
 std::ostream &operator<<(std::ostream &OS, const SeverityLevel &Level);
 
-extern SeverityLevel LogFilterLevel; // NOLINT
+extern SeverityLevel LogFilterLevel;
 
 #ifdef DYNAMIC_LOG
 BOOST_LOG_INLINE_GLOBAL_LOGGER_DEFAULT(