optimize LLVMZeroValue::isLLVMZeroValue() according to Fabian's suggestion in GitHub

Martin Mory · Martin Mory · commit 493ed9cadcf4 · 2021-12-24T01:09:20.000+01:00
diff --git a/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/LLVMZeroValue.h b/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/LLVMZeroValue.h
@@ -69,12 +69,7 @@ class LLVMZeroValue : public llvm::GlobalVariable {
   }
 
   static bool isLLVMZeroValue(const llvm::Value *V) {
-    if (V && V->hasName()) {
-      // checks if V's name start with "zero_value"
-      return V->getName().find(LLVMZeroValueInternalName) !=
-             llvm::StringRef::npos;
-    }
-    return false;
+    return V == getInstance();
   }
 
   // Do not specify a destructor (at all)!

Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,7 @@ class LLVMZeroValue : public llvm::GlobalVariable {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`static bool isLLVMZeroValue(const llvm::Value *V) {`
`72`		`- if (V && V->hasName()) {`
`73`		`- // checks if V's name start with "zero_value"`
`74`		`- return V->getName().find(LLVMZeroValueInternalName) !=`
`75`		`- llvm::StringRef::npos;`
`76`		`- }`
`77`		`- return false;`
	`72`	`+ return V == getInstance();`
`78`	`73`	`}`
`79`	`74`
`80`	`75`	`// Do not specify a destructor (at all)!`