Merge pull request #500 from secure-software-engineering/f-FixUninitVars

pdschubert · web-flow · commit 33cc0ca48296 · 2022-05-09T15:35:36.000+02:00
fix unreachable code in IFDSUninitializedVariables, fixing #410
diff --git a/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IFDSUninitializedVariables.cpp b/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IFDSUninitializedVariables.cpp
@@ -231,9 +231,6 @@ IFDSUninitializedVariables::getNormalFlowFunction(
     }
   };
   return make_shared<UVFF>(Curr, UndefValueUses);
-
-  // otherwise we do not care and nothing changes
-  return Identity<IFDSUninitializedVariables::d_t>::getInstance();
 }
 
 IFDSUninitializedVariables::FlowFunctionPtrType

Original file line number	Diff line number	Diff line change
`@@ -231,9 +231,6 @@ IFDSUninitializedVariables::getNormalFlowFunction(`
`231`	`231`	`}`
`232`	`232`	`};`
`233`	`233`	`return make_shared<UVFF>(Curr, UndefValueUses);`
`234`		`-`
`235`		`- // otherwise we do not care and nothing changes`
`236`		`- return Identity<IFDSUninitializedVariables::d_t>::getInstance();`
`237`	`234`	`}`
`238`	`235`
`239`	`236`	`IFDSUninitializedVariables::FlowFunctionPtrType`