style

Author: fabianbs96

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/AbstractMemoryLocation.h

@@ -78,6 +78,7 @@ class AbstractMemoryLocationImpl final
 
   AbstractMemoryLocationImpl(const AbstractMemoryLocationImpl &) = delete;
   AbstractMemoryLocationImpl(AbstractMemoryLocationImpl &&) = delete;
+  ~AbstractMemoryLocationImpl() = default;
 
   AbstractMemoryLocationImpl &
   operator=(const AbstractMemoryLocationImpl &) = delete;
@@ -201,8 +202,10 @@ class AbstractMemoryLocation {
   const detail::AbstractMemoryLocationImpl *PImpl = nullptr;
 };
 
+// NOLINTNEXTLINE(readability-identifier-naming)
 std::string DToString(const AbstractMemoryLocation &AML);
 
+// NOLINTNEXTLINE(readability-identifier-naming)
 llvm::hash_code hash_value(psr::AbstractMemoryLocation Val);
 } // namespace psr
 

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/AbstractMemoryLocationFactory.h

@@ -89,7 +89,7 @@ class AbstractMemoryLocationFactoryBase {
   const llvm::DataLayout *DL = nullptr;
 
   const detail::AbstractMemoryLocationImpl *
-  getOrCreateImpl(const llvm::Value *V, llvm::SmallVectorImpl<ptrdiff_t> &&offs,
+  getOrCreateImpl(const llvm::Value *V, llvm::SmallVectorImpl<ptrdiff_t> &&Offs,
                   unsigned BOUND);
 
   const detail::AbstractMemoryLocationImpl *
@@ -152,6 +152,9 @@ class AbstractMemoryLocationFactory<AbstractMemoryLocation>
                                 size_t InitialCapacity)
       : detail::AbstractMemoryLocationFactoryBase(DL, InitialCapacity) {}
   AbstractMemoryLocationFactory(const AbstractMemoryLocationFactory &) = delete;
+  ~AbstractMemoryLocationFactory() = default;
+  AbstractMemoryLocationFactory &
+  operator=(const AbstractMemoryLocationFactory &) = delete;
 
   [[nodiscard]] AbstractMemoryLocation Create(const llvm::Value *V,
                                               unsigned BOUND) {

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/DebugEdgeIdentity.h

@@ -15,7 +15,7 @@
 
 namespace llvm {
 class Instruction;
-}
+} // namespace llvm
 
 namespace psr::XTaint {
 class DebugEdgeIdentity

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/EdgeDomain.h

@@ -20,7 +20,7 @@
 
 namespace psr {
 class BasicBlockOrdering;
-}
+} // namespace psr
 
 namespace psr::XTaint {
 class Sanitized {};
@@ -43,11 +43,12 @@ class EdgeDomain final {
   inline EdgeDomain(std::nullptr_t) noexcept
       : Value(nullptr, Kind::WithSanitizer) {}
 
-  inline EdgeDomain(psr::Bottom) noexcept : Value(nullptr, Kind::Bot) {}
+  inline EdgeDomain(psr::Bottom /*unused*/) noexcept
+      : Value(nullptr, Kind::Bot) {}
 
-  inline EdgeDomain(psr::Top) noexcept : Value(nullptr, Kind::Top) {}
+  inline EdgeDomain(psr::Top /*unused*/) noexcept : Value(nullptr, Kind::Top) {}
 
-  inline EdgeDomain(psr::XTaint::Sanitized) noexcept
+  inline EdgeDomain(psr::XTaint::Sanitized /*unused*/) noexcept
       : Value(nullptr, Kind::Sanitized) {}
 
   inline EdgeDomain(const llvm::Instruction *Sani) noexcept

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/GenEdgeFunction.h

@@ -14,7 +14,7 @@
 
 namespace llvm {
 class Instruction;
-}
+} // namespace llvm
 
 namespace psr::XTaint {
 class GenEdgeFunction : public EdgeFunctionBase {

include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/JoinEdgeFunction.h

@@ -22,14 +22,14 @@ class JoinEdgeFunction : public EdgeFunctionBase {
     static inline EdgeFunctionPtrType getEmptyKey() {
       static EdgeFunctionPtrType EmptyKey(
           llvm::DenseMapInfo<EdgeFunction<l_t> *>::getEmptyKey(),
-          [](const EdgeFunction<l_t> *) {});
+          [](const EdgeFunction<l_t> * /*unused*/) {});
 
       return EmptyKey;
     }
     static inline EdgeFunctionPtrType getTombstoneKey() {
       static EdgeFunctionPtrType TombstoneKey(
           llvm::DenseMapInfo<EdgeFunction<l_t> *>::getTombstoneKey(),
-          [](const EdgeFunction<l_t> *) {});
+          [](const EdgeFunction<l_t> * /*unused*/) {});
 
       return TombstoneKey;
     }

lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEExtendedTaintAnalysis.cpp

@@ -215,7 +215,8 @@ IDEExtendedTaintAnalysis::getStoreFF(const llvm::Value *PointerOp,
       allTaintedValues.insert(ret.begin(), ret.end());
 #endif
 
-      std::cerr << "StoreFF(" << Source << ") = " << PrettyPrinter{Ret} << '\n';
+      // std::cerr << "StoreFF(" << Source << ") = " << PrettyPrinter{Ret} <<
+      // '\n';
 
       return Ret;
     }
@@ -856,15 +857,15 @@ void IDEExtendedTaintAnalysis::doPostProcessing(
   llvm::SmallVector<const llvm::Instruction *> RemInst;
   for (auto &[Inst, PotentialLeaks] : Leaks) {
     llvm::SmallVector<const llvm::Value *, 2> Rem;
-    std::cerr << "At " << llvmIRToString(Inst) << ":" << std::endl;
+    // std::cerr << "At " << llvmIRToString(Inst) << ":" << std::endl;
 
     auto Results = SR.resultsAt(Inst);
 
     for (const auto *L : PotentialLeaks) {
       auto Found = Results.find(makeFlowFact(L));
       if (Found == Results.end()) {
         // The sanitizer has been killed, so we must assume the fact as tainted
-        std::cerr << "No results for " << makeFlowFact(L) << std::endl;
+        // std::cerr << "No results for " << makeFlowFact(L) << std::endl;
         continue;
       }
 
@@ -875,27 +876,28 @@ void IDEExtendedTaintAnalysis::doPostProcessing(
       switch (Sani.getKind()) {
       case EdgeDomain::Sanitized:
         Rem.push_back(L);
-        std::cerr << "Sanitize " << llvmIRToShortString(L) << " from parent "
-                  << std::endl;
+        // std::cerr << "Sanitize " << llvmIRToShortString(L) << " from parent "
+        //          << std::endl;
         break;
       case EdgeDomain::WithSanitizer:
         if (!Sani.getSanitizer()) {
           break;
         }
         if (!Load || BBO.mustComeBefore(Sani.getSanitizer(), Load)) {
           Rem.push_back(L);
-          std::cerr << "Sanitize " << llvmIRToShortString(L) << " with "
-                    << llvmIRToString(Sani.getSanitizer()) << std::endl;
+          // std::cerr << "Sanitize " << llvmIRToShortString(L) << " with "
+          //          << llvmIRToString(Sani.getSanitizer()) << std::endl;
           break;
         }
         [[fallthrough]];
       default:
-        std::cerr << " Sani: " << Sani
-                  << "; Load: " << (Load ? llvmIRToString(Load) : "null")
-                  << " for FlowFact: " << makeFlowFact(L) << std::endl;
+        // std::cerr << " Sani: " << Sani
+        //           << "; Load: " << (Load ? llvmIRToString(Load) : "null")
+        //           << " for FlowFact: " << makeFlowFact(L) << std::endl;
+        break;
       }
     }
-    std::cerr << "----------------------------" << std::endl;
+    // std::cerr << "----------------------------" << std::endl;
 
     for (const auto *R : Rem) {
       PotentialLeaks.erase(R);